| Message ID | 1486928328-25870-1-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
Stefan Wahren <stefan.wahren@i2se.com> writes: > Add a thermal zone in order to make the example complete. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> This looks fine to me. Eduardo, will this be enough to get the driver in?
On Sun, Feb 12, 2017 at 07:38:47PM +0000, Stefan Wahren wrote: > Add a thermal zone in order to make the example complete. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > > Changes in V2: > - add missing thermal-sensor-cells property > - change gpu-thermal to cpu-thermal > > .../bindings/thermal/brcm,bcm2835-thermal.txt | 29 +++++++++++++++++--- > 1 file changed, 25 insertions(+), 4 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/thermal/brcm,bcm2835-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,bcm2835-thermal.txt index 474531d..6b8607a 100644 --- a/Documentation/devicetree/bindings/thermal/brcm,bcm2835-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/brcm,bcm2835-thermal.txt @@ -3,15 +3,36 @@ Binding for Thermal Sensor driver for BCM2835 SoCs. Required parameters: ------------------- -compatible: should be one of: "brcm,bcm2835-thermal", - "brcm,bcm2836-thermal" or "brcm,bcm2837-thermal" -reg: Address range of the thermal registers. -clocks: Phandle of the clock used by the thermal sensor. +compatible: should be one of: "brcm,bcm2835-thermal", + "brcm,bcm2836-thermal" or "brcm,bcm2837-thermal" +reg: Address range of the thermal registers. +clocks: Phandle of the clock used by the thermal sensor. +#thermal-sensor-cells: should be 0 (see thermal.txt) Example: +thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <0>; + polling-delay = <1000>; + + thermal-sensors = <&thermal>; + + trips { + cpu-crit { + temperature = <80000>; + hysteresis = <0>; + type = "critical"; + }; + }; + cooling-maps { + }; + }; +}; + thermal: thermal@7e212000 { compatible = "brcm,bcm2835-thermal"; reg = <0x7e212000 0x8>; clocks = <&clocks BCM2835_CLOCK_TSENS>; + #thermal-sensor-cells = <0>; };
Add a thermal zone in order to make the example complete. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- Changes in V2: - add missing thermal-sensor-cells property - change gpu-thermal to cpu-thermal .../bindings/thermal/brcm,bcm2835-thermal.txt | 29 +++++++++++++++++--- 1 file changed, 25 insertions(+), 4 deletions(-)