| Message ID | 1487187731-10293-5-git-send-email-jonathan.derrick@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Jon Derrick <jonathan.derrick@intel.com> writes: > PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks > like the 'arch/powerpc' file pattern should be enough to match powerpc > opal code by itself. Remove the opal regex pattern from powerpc. We thought of it first. Can't you just rename your driver, Opal Storage Specification, so "oss", that should be pretty unique? ... :) I don't like this version, but I'll merge the one from Stewart which drops the pattern and adds the paths for the existing drivers. cheers > diff --git a/MAINTAINERS b/MAINTAINERS > index b983b25..430dd02 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7404,7 +7404,6 @@ F: drivers/pci/hotplug/pnv_php.c > F: drivers/pci/hotplug/rpa* > F: drivers/scsi/ibmvscsi/ > F: tools/testing/selftests/powerpc > -N: opal > N: /pmac > N: powermac > N: powernv > -- > 1.8.3.1
Thanks everyone. Sorry about the mess :) On 02/15/2017 10:23 PM, Michael Ellerman wrote: > Jon Derrick <jonathan.derrick@intel.com> writes: > >> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks >> like the 'arch/powerpc' file pattern should be enough to match powerpc >> opal code by itself. Remove the opal regex pattern from powerpc. > > We thought of it first. > > Can't you just rename your driver, Opal Storage Specification, so "oss", > that should be pretty unique? > > ... :) > > I don't like this version, but I'll merge the one from Stewart which > drops the pattern and adds the paths for the existing drivers. > > cheers > >> diff --git a/MAINTAINERS b/MAINTAINERS >> index b983b25..430dd02 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -7404,7 +7404,6 @@ F: drivers/pci/hotplug/pnv_php.c >> F: drivers/pci/hotplug/rpa* >> F: drivers/scsi/ibmvscsi/ >> F: tools/testing/selftests/powerpc >> -N: opal >> N: /pmac >> N: powermac >> N: powernv >> -- >> 1.8.3.1
> -----Original Message----- > From: linux-block-owner@vger.kernel.org [mailto:linux-block- > owner@vger.kernel.org] On Behalf Of Jon Derrick > Sent: Thursday, February 16, 2017 10:15 AM > To: Michael Ellerman <mpe@ellerman.id.au> > Cc: Jens Axboe <axboe@kernel.dk>; Rafael Antognolli > <rafael.antognolli@intel.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; linux-kernel@vger.kernel.org; linux- > block@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Christoph Hellwig > <hch@lst.de>; Scott Bauer <scott.bauer@intel.com> > Subject: Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match > > Thanks everyone. Sorry about the mess :) > > On 02/15/2017 10:23 PM, Michael Ellerman wrote: > > Jon Derrick <jonathan.derrick@intel.com> writes: > > > >> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks > >> like the 'arch/powerpc' file pattern should be enough to match powerpc > >> opal code by itself. Remove the opal regex pattern from powerpc. > > > > We thought of it first. > > > > Can't you just rename your driver, Opal Storage Specification, so "oss", > > that should be pretty unique? > > > > ... :) The library could easily be used for devices supporting the Opalite and Pyrite SSCs, not just the Opal SSC. With some effort, I suspect that Enterprise SSC could also be supported. So, a broader name might indeed be useful. The full names of the specifications are: TCG Storage Security Subsystem Class: Opal TCG Storage Security Subsystem Class: Opalite TCG Storage Security Subsystem Class: Pyrite TCG Storage Security Subsystem Class: Enterprise --- Robert Elliott, HPE Persistent Memory
diff --git a/MAINTAINERS b/MAINTAINERS index b983b25..430dd02 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7404,7 +7404,6 @@ F: drivers/pci/hotplug/pnv_php.c F: drivers/pci/hotplug/rpa* F: drivers/scsi/ibmvscsi/ F: tools/testing/selftests/powerpc -N: opal N: /pmac N: powermac N: powernv
PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks like the 'arch/powerpc' file pattern should be enough to match powerpc opal code by itself. Remove the opal regex pattern from powerpc. Signed-off-by: Jon Derrick <jonathan.derrick@intel.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-)