diff mbox

net/utils: fix semicolon.cocci warnings

Message ID 20170216213400.GA47728@lkp-hsx03.lkp.intel.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

kernel test robot Feb. 16, 2017, 9:34 p.m. UTC
net/core/utils.c:388:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 utils.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Feb. 17, 2017, 6:52 p.m. UTC | #1
From: kbuild test robot <lkp@intel.com>
Date: Fri, 17 Feb 2017 05:34:03 +0800

> net/core/utils.c:388:2-3: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> CC: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  utils.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/net/core/utils.c
> +++ b/net/core/utils.c
> @@ -385,7 +385,7 @@ int inet_pton_with_scope(struct net *net

I have no idea what tree this could be against, as net/core/utils.c doesn't
have more than 351 lines in any tree I maintain.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keith Busch Feb. 17, 2017, 7:19 p.m. UTC | #2
On Fri, Feb 17, 2017 at 01:52:54PM -0500, David Miller wrote:
> From: kbuild test robot <lkp@intel.com>
> Date: Fri, 17 Feb 2017 05:34:03 +0800
> 
> > net/core/utils.c:388:2-3: Unneeded semicolon
> > 
> > 
> >  Remove unneeded semicolon.
> > 
> > Generated by: scripts/coccinelle/misc/semicolon.cocci
> > 
> > CC: Sagi Grimberg <sagi@grimberg.me>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> > 
> >  utils.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/net/core/utils.c
> > +++ b/net/core/utils.c
> > @@ -385,7 +385,7 @@ int inet_pton_with_scope(struct net *net
> 
> I have no idea what tree this could be against, as net/core/utils.c doesn't
> have more than 351 lines in any tree I maintain.

I think this is just an auto-generated patch based on a 0-day internal
tree that applied the patch it's proposing to fix. The robot script may
be a jumping the gun here for sending this.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kernel test robot Feb. 18, 2017, 12:39 a.m. UTC | #3
Hi Dave,

On Fri, Feb 17, 2017 at 01:52:54PM -0500, David Miller wrote:
>From: kbuild test robot <lkp@intel.com>
>Date: Fri, 17 Feb 2017 05:34:03 +0800
>
>> net/core/utils.c:388:2-3: Unneeded semicolon
>>
>>
>>  Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> CC: Sagi Grimberg <sagi@grimberg.me>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>
>>  utils.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/net/core/utils.c
>> +++ b/net/core/utils.c
>> @@ -385,7 +385,7 @@ int inet_pton_with_scope(struct net *net
>
>I have no idea what tree this could be against, as net/core/utils.c doesn't
>have more than 351 lines in any tree I maintain.

You can ignore it -- the cocci fix is for Sagi Grimberg's RFC patch
which can be judged by looking at the thread:

  Feb 17 To Sagi Grimber (  22:0) -->Re: [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper
  Feb 17 To Sagi Grimber (  29:0) `->[PATCH] net/utils: fix semicolon.cocci warnings

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/net/core/utils.c
+++ b/net/core/utils.c
@@ -385,7 +385,7 @@  int inet_pton_with_scope(struct net *net
 		break;
 	default:
 		pr_err("unexpected address family %d\n", af);
-	};
+	}
 
 	return -EINVAL;
 }