diff mbox

x86/apicv: move posted_intr_vector handler to pi_notification_interrupt

Message ID E0A769A898ADB6449596C41F51EF62C6AE8087@SZXEMI506-MBX.china.huawei.com (mailing list archive)
State New, archived
Headers show

Commit Message

Xuquan (Euler) Feb. 23, 2017, 8:50 a.m. UTC 
From e101539e18625cb70dfaee58ae7e73aa5df7b8a9 Mon Sep 17 00:00:00 2001
From: Quan Xu <xuquan8@huawei.com>
Date: Fri, 24 Feb 2017 08:43:16 +0800
Subject: [PATCH] x86/apicv: move posted_intr_vector handler to
 pi_notification_interrupt

event_check_interrupt is likely used in pair with original delivery logic.
Now since delivery path is changed, we should move to pi_notification_interrupt
always.

Signed-off-by: Quan Xu <xuquan8@huawei.com>
---
 xen/arch/x86/hvm/vmx/vmx.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--
1.8.3.1

Comments

Jan Beulich Feb. 23, 2017, 9:33 a.m. UTC | #1 
>>> On 23.02.17 at 09:50, <xuquan8@huawei.com> wrote:
> event_check_interrupt is likely used in pair with original delivery logic.
> Now since delivery path is changed, we should move to pi_notification_interrupt
> always.

I don't think this is sufficient explanation. What change in the
delivery path are you talking about? Which earlier commit
should have done this right away?

Jan
diff mbox

Patch

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 61925cf..1b026fa 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -2279,13 +2279,9 @@  const struct hvm_function_table * __init start_vmx(void)

     if ( cpu_has_vmx_posted_intr_processing )
     {
+        alloc_direct_apic_vector(&posted_intr_vector, pi_notification_interrupt);
         if ( iommu_intpost )
-        {
-            alloc_direct_apic_vector(&posted_intr_vector, pi_notification_interrupt);
             alloc_direct_apic_vector(&pi_wakeup_vector, pi_wakeup_interrupt);
-        }
-        else
-            alloc_direct_apic_vector(&posted_intr_vector, event_check_interrupt);
     }
     else
     {