| Message ID | 1488252276-2425-1-git-send-email-timur@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>--- a/drivers/acpi/spcr.c >+++ b/drivers/acpi/spcr.c >@@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct >acpi_table_header *h) > return true; > > if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) && >- h->oem_revision == 0) >+ h->oem_revision == 1) You might want to make this <= 1 and also change firmware to 0 so that new firmware with old kernels, new kernels with old firmware, and new kernels with new firmware all get the workaround applied. Regards, Cov
Christopher Covington wrote: > You might want to make this <= 1 and also change firmware to 0 so that new > firmware with old kernels, new kernels with old firmware, and new kernels > with new firmware all get the workaround applied. I thought about that, but there is apparently no firmware that sets the value to 0.
On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote: > For Qualcomm Technologies QDF2400 SOCs that are affected by > erratum E44, the ACPI oem_revision field is actually set to 1, > not 0. Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm QDF2400 and QDF2432")' ? -dann
On 02/28/2017 02:19 PM, dann frazier wrote: > On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote: >> For Qualcomm Technologies QDF2400 SOCs that are affected by >> erratum E44, the ACPI oem_revision field is actually set to 1, >> not 0. > > Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm > QDF2400 and QDF2432")' ? Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit") I will post a v2.
On Tue, Feb 28, 2017 at 1:23 PM, Timur Tabi <timur@codeaurora.org> wrote: > On 02/28/2017 02:19 PM, dann frazier wrote: >> >> On Mon, Feb 27, 2017 at 8:24 PM, Timur Tabi <timur@codeaurora.org> wrote: >>> >>> For Qualcomm Technologies QDF2400 SOCs that are affected by >>> erratum E44, the ACPI oem_revision field is actually set to 1, >>> not 0. >> >> >> Should this 'Fixes: d8a4995bcea1 ("PCI: Add ACS quirk for Qualcomm >> QDF2400 and QDF2432")' ? > > > Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit") oops.. right. Pulled the long line from my git --grep QDF2400 :( -dann > I will post a v2. > > > -- > Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm > Technologies, Inc. Qualcomm Technologies, Inc. is a member of the > Code Aurora Forum, a Linux Foundation Collaborative Project.
diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c index 2b5d0fa..2051a8c 100644 --- a/drivers/acpi/spcr.c +++ b/drivers/acpi/spcr.c @@ -30,7 +30,7 @@ static bool qdf2400_erratum_44_present(struct acpi_table_header *h) return true; if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) && - h->oem_revision == 0) + h->oem_revision == 1) return true; return false;
For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44, the ACPI oem_revision field is actually set to 1, not 0. Signed-off-by: Timur Tabi <timur@codeaurora.org> --- drivers/acpi/spcr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)