diff mbox

[3/3] Remove unnecessary newline

Message ID 59e71d8abf46dc0e9e928924a317e80aa15f6f0c.1488844291.git.linda.knippers@hpe.com (mailing list archive)
State Accepted
Commit f2668fa7f6fb
Headers show

Commit Message

Linda Knippers March 7, 2017, 12:25 a.m. UTC 
The newline in MODULE_PARM_DESC causes modinfo to print the parameter
data type on a separate line, which is different from all the other
module parameters and could potentially cause a problem for someone
parsing the output of modinfo.

Signed-off-by: Linda Knippers <linda.knippers@hpe.com>
---
 drivers/acpi/nfit/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johannes Thumshirn March 7, 2017, 8:53 a.m. UTC | #1 
On 03/07/2017 01:25 AM, Linda Knippers wrote:
> The newline in MODULE_PARM_DESC causes modinfo to print the parameter
> data type on a separate line, which is different from all the other
> module parameters and could potentially cause a problem for someone
> parsing the output of modinfo.
> 
> Signed-off-by: Linda Knippers <linda.knippers@hpe.com>
> ---

Thanks,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff mbox

Patch

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 78c46a7..7a4c549 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -49,7 +49,7 @@ 
 static bool disable_vendor_specific;
 module_param(disable_vendor_specific, bool, S_IRUGO);
 MODULE_PARM_DESC(disable_vendor_specific,
-		"Limit commands to the publicly specified set\n");
+		"Limit commands to the publicly specified set");
 
 static unsigned long override_dsm_mask;
 module_param(override_dsm_mask, ulong, S_IRUGO);