| Message ID | a3161cfc-56f7-4577-c37f-3798cdb03713@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello! On 3/9/2017 11:39 AM, Sekhar Nori wrote: >>> It took a while to get to it but here is the draft driver patch >>> against v4.11-rc1. Please test. >> >> I tested this on DM6446 EVM. I was able to mount existing partitions on >> the hard disk and see that the directory listing looks good[1]. I will do >> more tests (including comparing performance with old driver) tomorrow. I > > I completed the tests I wanted to, including some read/write/data > integrity tests. Performance is same as before too. > > Tested-by: Sekhar Nori <nsekhar@ti.com> > > Here are the additional changes I did. These changes do not clash with > what I have already queued for v4.12. That said, its probably better if > I carry the platform pieces through my tree. Let me know how you want > to proceed. > > Thanks, > Sekhar > > ---8<--- > diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig > index b9a7cb98ffda..67db82999c06 100644 > --- a/arch/arm/configs/davinci_all_defconfig > +++ b/arch/arm/configs/davinci_all_defconfig [...] > diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c > index 023480b75244..60a1f23890cd 100644 > --- a/arch/arm/mach-davinci/board-dm644x-evm.c > +++ b/arch/arm/mach-davinci/board-dm644x-evm.c > @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device *phydev) > return 0; > } > > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) I think it would be more correct to check for both libata and IDE drivers here... > #define HAS_NOR IS_ENABLED(CONFIG_MTD_PHYSMAP) > > diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c > index f702d4fc8eb8..589f3c33c4a0 100644 > --- a/arch/arm/mach-davinci/board-dm646x-evm.c > +++ b/arch/arm/mach-davinci/board-dm646x-evm.c > @@ -119,7 +119,7 @@ static struct platform_device davinci_nand_device = { > }, > }; > > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) And here... > > #ifdef CONFIG_I2C > /* CPLD Register 0 bits to control ATA */ > diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c > index 0a7838852649..075e304ce7be 100644 > --- a/arch/arm/mach-davinci/board-neuros-osd2.c > +++ b/arch/arm/mach-davinci/board-neuros-osd2.c > @@ -163,7 +163,7 @@ static struct davinci_mmc_config davinci_ntosd2_mmc_config = { > .wires = 4, > }; > > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) And here... [...] MBR, Sergei
Hi Sekhar, On Thursday, March 09, 2017 02:09:30 PM Sekhar Nori wrote: > Hi Bartlomiej, > > On Wednesday 08 March 2017 08:30 PM, Sekhar Nori wrote: > > >> It took a while to get to it but here is the draft driver patch > >> against v4.11-rc1. Please test. > > > > I tested this on DM6446 EVM. I was able to mount existing partitions on > > the hard disk and see that the directory listing looks good[1]. I will do > > more tests (including comparing performance with old driver) tomorrow. I > > I completed the tests I wanted to, including some read/write/data > integrity tests. Performance is same as before too. > > Tested-by: Sekhar Nori <nsekhar@ti.com> Thanks for testing! > Here are the additional changes I did. These changes do not clash with I'll split the draft patch on ATA & platform changes and make a proper submission. I'll also include your changes (can I have your Signed-by for them?). > what I have already queued for v4.12. That said, its probably better if > I carry the platform pieces through my tree. Let me know how you want > to proceed. I think that it would be the best to ask Tejun to make a separate branch with a pata_bk3710 driver so it can be pulled into your tree to preserve bisectability. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On Thursday 09 March 2017 05:17 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi Sekhar, > > On Thursday, March 09, 2017 02:09:30 PM Sekhar Nori wrote: >> Hi Bartlomiej, >> >> On Wednesday 08 March 2017 08:30 PM, Sekhar Nori wrote: >> >>>> It took a while to get to it but here is the draft driver patch >>>> against v4.11-rc1. Please test. >>> >>> I tested this on DM6446 EVM. I was able to mount existing partitions on >>> the hard disk and see that the directory listing looks good[1]. I will do >>> more tests (including comparing performance with old driver) tomorrow. I >> >> I completed the tests I wanted to, including some read/write/data >> integrity tests. Performance is same as before too. >> >> Tested-by: Sekhar Nori <nsekhar@ti.com> > > Thanks for testing! > >> Here are the additional changes I did. These changes do not clash with > > I'll split the draft patch on ATA & platform changes and make a proper > submission. I'll also include your changes (can I have your Signed-by > for them?). Signed-of-by: Sekhar Nori <nsekhar@ti.com> >> what I have already queued for v4.12. That said, its probably better if >> I carry the platform pieces through my tree. Let me know how you want >> to proceed. > > I think that it would be the best to ask Tejun to make a separate branch > with a pata_bk3710 driver so it can be pulled into your tree to preserve > bisectability. Sounds good. What about removal of IDE driver? Do you want to have both drivers existing in v4.12 and get rid of the IDE driver in v4.13 ? Thanks, Sekhar
On Thursday, March 09, 2017 05:27:12 PM Sekhar Nori wrote: > On Thursday 09 March 2017 05:17 PM, Bartlomiej Zolnierkiewicz wrote: > > > > Hi Sekhar, > > > > On Thursday, March 09, 2017 02:09:30 PM Sekhar Nori wrote: > >> Hi Bartlomiej, > >> > >> On Wednesday 08 March 2017 08:30 PM, Sekhar Nori wrote: > >> > >>>> It took a while to get to it but here is the draft driver patch > >>>> against v4.11-rc1. Please test. > >>> > >>> I tested this on DM6446 EVM. I was able to mount existing partitions on > >>> the hard disk and see that the directory listing looks good[1]. I will do > >>> more tests (including comparing performance with old driver) tomorrow. I > >> > >> I completed the tests I wanted to, including some read/write/data > >> integrity tests. Performance is same as before too. > >> > >> Tested-by: Sekhar Nori <nsekhar@ti.com> > > > > Thanks for testing! > > > >> Here are the additional changes I did. These changes do not clash with > > > > I'll split the draft patch on ATA & platform changes and make a proper > > submission. I'll also include your changes (can I have your Signed-by > > for them?). > > Signed-of-by: Sekhar Nori <nsekhar@ti.com> Thanks. > >> what I have already queued for v4.12. That said, its probably better if > >> I carry the platform pieces through my tree. Let me know how you want > >> to proceed. > > > > I think that it would be the best to ask Tejun to make a separate branch > > with a pata_bk3710 driver so it can be pulled into your tree to preserve > > bisectability. > > Sounds good. What about removal of IDE driver? Do you want to have both > drivers existing in v4.12 and get rid of the IDE driver in v4.13 ? Sounds good to me. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On Thursday 09 March 2017 02:55 PM, Sergei Shtylyov wrote: [...] >> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c >> b/arch/arm/mach-davinci/board-dm644x-evm.c >> index 023480b75244..60a1f23890cd 100644 >> --- a/arch/arm/mach-davinci/board-dm644x-evm.c >> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c >> @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device >> *phydev) >> return 0; >> } >> >> -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) >> +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) > > I think it would be more correct to check for both libata and IDE > drivers here... As I understand, the plan is to remove the IDE driver soon. Thanks, Sekhar
Hi, On Thursday, March 09, 2017 12:25:47 PM Sergei Shtylyov wrote: > Hello! > > On 3/9/2017 11:39 AM, Sekhar Nori wrote: > > >>> It took a while to get to it but here is the draft driver patch > >>> against v4.11-rc1. Please test. > >> > >> I tested this on DM6446 EVM. I was able to mount existing partitions on > >> the hard disk and see that the directory listing looks good[1]. I will do > >> more tests (including comparing performance with old driver) tomorrow. I > > > > I completed the tests I wanted to, including some read/write/data > > integrity tests. Performance is same as before too. > > > > Tested-by: Sekhar Nori <nsekhar@ti.com> > > > > Here are the additional changes I did. These changes do not clash with > > what I have already queued for v4.12. That said, its probably better if > > I carry the platform pieces through my tree. Let me know how you want > > to proceed. > > > > Thanks, > > Sekhar > > > > ---8<--- > > diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig > > index b9a7cb98ffda..67db82999c06 100644 > > --- a/arch/arm/configs/davinci_all_defconfig > > +++ b/arch/arm/configs/davinci_all_defconfig > [...] > > diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c > > index 023480b75244..60a1f23890cd 100644 > > --- a/arch/arm/mach-davinci/board-dm644x-evm.c > > +++ b/arch/arm/mach-davinci/board-dm644x-evm.c > > @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device *phydev) > > return 0; > > } > > > > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) > > I think it would be more correct to check for both libata and IDE drivers > here... Thanks for noticing. To make both drivers work depending on config options selected I'll: - fix these HAS_ATA macros - use "palm_bk3710" as platform driver name in the new driver - drop IDE platform device & IDE clock name changes Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On 03/09/2017 03:20 PM, Sekhar Nori wrote: > [...] >>> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c >>> b/arch/arm/mach-davinci/board-dm644x-evm.c >>> index 023480b75244..60a1f23890cd 100644 >>> --- a/arch/arm/mach-davinci/board-dm644x-evm.c >>> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c >>> @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device >>> *phydev) >>> return 0; >>> } >>> >>> -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) >>> +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) >> >> I think it would be more correct to check for both libata and IDE >> drivers here... > > As I understand, the plan is to remove the IDE driver soon. I'm not sure DaveM would support any removals in drivers/ide/. He has explicitly expressed his will to maintain the IDE driuver forever. > Thanks, > Sekhar MBR, Sergei
On 03/09/2017 03:24 PM, Sergei Shtylyov wrote: >>>> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c >>>> b/arch/arm/mach-davinci/board-dm644x-evm.c >>>> index 023480b75244..60a1f23890cd 100644 >>>> --- a/arch/arm/mach-davinci/board-dm644x-evm.c >>>> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c >>>> @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device >>>> *phydev) >>>> return 0; >>>> } >>>> >>>> -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) >>>> +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) >>> >>> I think it would be more correct to check for both libata and IDE >>> drivers here... >> >> As I understand, the plan is to remove the IDE driver soon. > > I'm not sure DaveM would support any removals in drivers/ide/. He has > explicitly expressed his will to maintain the IDE driuver forever. s/driuver/drivers/, sorry. :-) >> Thanks, >> Sekhar MBR, Sergei
On Thursday, March 09, 2017 03:24:56 PM Sergei Shtylyov wrote: > On 03/09/2017 03:20 PM, Sekhar Nori wrote: > > > [...] > > >>> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c > >>> b/arch/arm/mach-davinci/board-dm644x-evm.c > >>> index 023480b75244..60a1f23890cd 100644 > >>> --- a/arch/arm/mach-davinci/board-dm644x-evm.c > >>> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c > >>> @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device > >>> *phydev) > >>> return 0; > >>> } > >>> > >>> -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > >>> +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) > >> > >> I think it would be more correct to check for both libata and IDE > >> drivers here... > > > > As I understand, the plan is to remove the IDE driver soon. > > I'm not sure DaveM would support any removals in drivers/ide/. He has > explicitly expressed his will to maintain the IDE driuver forever. Well, he can always change his opinion. :-) Especially if the request for removal is for platform specific code only and it is agreed with the maintainers of the given platform.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig index b9a7cb98ffda..67db82999c06 100644 --- a/arch/arm/configs/davinci_all_defconfig +++ b/arch/arm/configs/davinci_all_defconfig @@ -74,12 +74,10 @@ CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_COUNT=1 CONFIG_BLK_DEV_RAM_SIZE=32768 CONFIG_EEPROM_AT24=y -CONFIG_IDE=m -CONFIG_BLK_DEV_PALMCHIP_BK3710=m -CONFIG_SCSI=m CONFIG_BLK_DEV_SD=m CONFIG_ATA=m CONFIG_AHCI_DA850=m +CONFIG_PATA_BK3710=m CONFIG_NETDEVICES=y CONFIG_NETCONSOLE=y CONFIG_TUN=m diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c index 023480b75244..60a1f23890cd 100644 --- a/arch/arm/mach-davinci/board-dm644x-evm.c +++ b/arch/arm/mach-davinci/board-dm644x-evm.c @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device *phydev) return 0; } -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) #define HAS_NOR IS_ENABLED(CONFIG_MTD_PHYSMAP) diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c index f702d4fc8eb8..589f3c33c4a0 100644 --- a/arch/arm/mach-davinci/board-dm646x-evm.c +++ b/arch/arm/mach-davinci/board-dm646x-evm.c @@ -119,7 +119,7 @@ static struct platform_device davinci_nand_device = { }, }; -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) #ifdef CONFIG_I2C /* CPLD Register 0 bits to control ATA */ diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c index 0a7838852649..075e304ce7be 100644 --- a/arch/arm/mach-davinci/board-neuros-osd2.c +++ b/arch/arm/mach-davinci/board-neuros-osd2.c @@ -163,7 +163,7 @@ static struct davinci_mmc_config davinci_ntosd2_mmc_config = { .wires = 4, }; -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) #define HAS_NAND IS_ENABLED(CONFIG_MTD_NAND_DAVINCI)