diff mbox

virtio-serial-bus: Delete timer from list before free it

Message ID 1488770972-322500-1-git-send-email-zhang.zhanghailiang@huawei.com (mailing list archive)
State New, archived
Headers show

Commit Message

Zhanghailiang March 6, 2017, 3:29 a.m. UTC 
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
 hw/char/virtio-serial-bus.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Paolo Bonzini March 6, 2017, 5:02 p.m. UTC | #1 
On 06/03/2017 04:29, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
>  hw/char/virtio-serial-bus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index d544cd9..d797a67 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -724,6 +724,7 @@ static void virtio_serial_post_load_timer_cb(void *opaque)
>          }
>      }
>      g_free(s->post_load->connected);
> +    timer_del(s->post_load->timer);
>      timer_free(s->post_load->timer);
>      g_free(s->post_load);
>      s->post_load = NULL;
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-stable@nongnu.org
Amit Shah March 7, 2017, 8:01 p.m. UTC | #2 
On (Mon) 06 Mar 2017 [11:29:31], zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>

Reviewed-by: Amit Shah <amit@kernel.org>

Michael, please pick this up.

		Amit
Zhanghailiang March 14, 2017, 12:26 p.m. UTC | #3 
ping... ?

On 2017/3/8 4:01, Amit Shah wrote:
> On (Mon) 06 Mar 2017 [11:29:31], zhanghailiang wrote:
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>
> Reviewed-by: Amit Shah <amit@kernel.org>
>
> Michael, please pick this up.
>
> 		Amit
>
diff mbox

Patch

diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index d544cd9..d797a67 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -724,6 +724,7 @@  static void virtio_serial_post_load_timer_cb(void *opaque)
         }
     }
     g_free(s->post_load->connected);
+    timer_del(s->post_load->timer);
     timer_free(s->post_load->timer);
     g_free(s->post_load);
     s->post_load = NULL;