| Message ID | 20170314092302.7317-1-peter.senna@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 14, 2017 at 10:23:02AM +0100, Peter Senna Tschudin wrote: > Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE > B850v3 dts file. > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Martyn Welch <martyn.welch@collabora.co.uk> > Cc: Martin Donnelly <martin.donnelly@ge.com> > Cc: Javier Martinez Canillas <javier@dowhile0.org> > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Rob Herring <robh@kernel.org> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com> To match i.MX patch style, the subject prefix should be something like 'ARM: dts: imx6q-b850v3: ...'. > --- > Subject was [PATCH V4 4/4] ... > But patches 1, 2, and 3 are already upstream and were not resent. > > Changes from V3: > - Newline fixes > - Removed 'status = "okay";' from '&mux2_i2c2' > - Sorted device nodes in order of unit address > > Unchanged since V1. > arch/arm/boot/dts/imx6q-b850v3.dts | 66 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-b850v3.dts b/arch/arm/boot/dts/imx6q-b850v3.dts > index d78514c..ef67b47 100644 > --- a/arch/arm/boot/dts/imx6q-b850v3.dts > +++ b/arch/arm/boot/dts/imx6q-b850v3.dts > @@ -72,6 +72,14 @@ > fsl,data-mapping = "spwg"; > fsl,data-width = <24>; > status = "okay"; > + > + port@4 { > + reg = <4>; > + Great, it's been fixed. > + lvds0_out: endpoint { > + remote-endpoint = <&stdp4028_in>; > + }; > + }; > }; > }; > > @@ -142,3 +150,61 @@ > reg = <0x4a>; > }; > }; > + > +&mux2_i2c2 { > + clock-frequency = <100000>; > + > + stdp2690@72 { > + compatible = "megachips,stdp2690-ge-b850v3-fw"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x72>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; But this one ... > + stdp2690_in: endpoint { > + remote-endpoint = <&stdp4028_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; ... here ... > + stdp2690_out: endpoint { > + /* Connector for external display */ > + }; > + }; > + }; > + }; > + > + stdp4028@73 { > + compatible = "megachips,stdp4028-ge-b850v3-fw"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x73>; > + interrupt-parent = <&gpio2>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; ... here ... > + stdp4028_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; ... and here. I fixed up all of them and applied patch. Shawn > + stdp4028_out: endpoint { > + remote-endpoint = <&stdp2690_in>; > + }; > + }; > + }; > + }; > +}; > -- > 2.9.3 >
On Thu, Mar 16, 2017 at 10:34:59AM +0800, Shawn Guo wrote:
> I fixed up all of them and applied patch.
+1 on doing review like this. And for committers you can do "with all that
fixed r-b: me" and let them fix it up & push themselves, even less work
:-)
Cheers, Daniel
On Thu, Mar 16, 2017 at 09:41:03AM +0100, Daniel Vetter wrote: > On Thu, Mar 16, 2017 at 10:34:59AM +0800, Shawn Guo wrote: > > I fixed up all of them and applied patch. > > +1 on doing review like this. And for committers you can do "with all that > fixed r-b: me" and let them fix it up & push themselves, even less work > :-) Thank you Shawn! [...]
diff --git a/arch/arm/boot/dts/imx6q-b850v3.dts b/arch/arm/boot/dts/imx6q-b850v3.dts index d78514c..ef67b47 100644 --- a/arch/arm/boot/dts/imx6q-b850v3.dts +++ b/arch/arm/boot/dts/imx6q-b850v3.dts @@ -72,6 +72,14 @@ fsl,data-mapping = "spwg"; fsl,data-width = <24>; status = "okay"; + + port@4 { + reg = <4>; + + lvds0_out: endpoint { + remote-endpoint = <&stdp4028_in>; + }; + }; }; }; @@ -142,3 +150,61 @@ reg = <0x4a>; }; }; + +&mux2_i2c2 { + clock-frequency = <100000>; + + stdp2690@72 { + compatible = "megachips,stdp2690-ge-b850v3-fw"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x72>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + stdp2690_in: endpoint { + remote-endpoint = <&stdp4028_out>; + }; + }; + + port@1 { + reg = <1>; + stdp2690_out: endpoint { + /* Connector for external display */ + }; + }; + }; + }; + + stdp4028@73 { + compatible = "megachips,stdp4028-ge-b850v3-fw"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x73>; + interrupt-parent = <&gpio2>; + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + stdp4028_in: endpoint { + remote-endpoint = <&lvds0_out>; + }; + }; + + port@1 { + reg = <1>; + stdp4028_out: endpoint { + remote-endpoint = <&stdp2690_in>; + }; + }; + }; + }; +};
Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE B850v3 dts file. Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Martyn Welch <martyn.welch@collabora.co.uk> Cc: Martin Donnelly <martin.donnelly@ge.com> Cc: Javier Martinez Canillas <javier@dowhile0.org> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Rob Herring <robh@kernel.org> Cc: Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com> --- Subject was [PATCH V4 4/4] ... But patches 1, 2, and 3 are already upstream and were not resent. Changes from V3: - Newline fixes - Removed 'status = "okay";' from '&mux2_i2c2' - Sorted device nodes in order of unit address Unchanged since V1. arch/arm/boot/dts/imx6q-b850v3.dts | 66 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+)