diff mbox

[rdma-core] rpm: BR: python for libmlx5

Message ID 20170323021246.35786-1-jarod@redhat.com (mailing list archive)
State Accepted
Headers show

Commit Message

Jarod Wilson March 23, 2017, 2:12 a.m. UTC
The relpath python script added in commit 07764bc805ba requires python to
run, thus we must BuildRequires: python in the rpm spec files, or the
build will fail in minimal environments (such as mock).

Fixes: 07764bc805ba ("mlx5: Export mlx5 direct verbs interface")
CC: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 rdma-core.spec        | 1 +
 redhat/rdma-core.spec | 1 +
 2 files changed, 2 insertions(+)

Comments

Jason Gunthorpe March 23, 2017, 3:47 a.m. UTC | #1
On Wed, Mar 22, 2017 at 10:12:46PM -0400, Jarod Wilson wrote:
> The relpath python script added in commit 07764bc805ba requires python to
> run, thus we must BuildRequires: python in the rpm spec files, or the
> build will fail in minimal environments (such as mock).
> 
> Fixes: 07764bc805ba ("mlx5: Export mlx5 direct verbs interface")
> CC: Leon Romanovsky <leonro@mellanox.com>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
>  rdma-core.spec        | 1 +
>  redhat/rdma-core.spec | 1 +
>  2 files changed, 2 insertions(+)

I suspect we need to add python to debian/control as well, for the
same reasons.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jason Gunthorpe March 23, 2017, 4:58 p.m. UTC | #2
On Wed, Mar 22, 2017 at 10:12:46PM -0400, Jarod Wilson wrote:
> The relpath python script added in commit 07764bc805ba requires python to
> run, thus we must BuildRequires: python in the rpm spec files, or the
> build will fail in minimal environments (such as mock).
> 
> Fixes: 07764bc805ba ("mlx5: Export mlx5 direct verbs interface")
> CC: Leon Romanovsky <leonro@mellanox.com>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
>  rdma-core.spec        | 1 +
>  redhat/rdma-core.spec | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/rdma-core.spec b/rdma-core.spec
> index 3f6e73a0..6a280fe1 100644
> +++ b/rdma-core.spec
> @@ -19,6 +19,7 @@ BuildRequires: pkgconfig
>  BuildRequires: pkgconfig(libnl-3.0)
>  BuildRequires: pkgconfig(libnl-route-3.0)
>  BuildRequires: valgrind-devel
> +BuildRequires: python
>  
>  # Since we recommend developers use Ninja, so should packagers, for consistency.
>  %define CMAKE_FLAGS %{nil}
> diff --git a/redhat/rdma-core.spec b/redhat/rdma-core.spec
> index 5f6ead42..6b56eae4 100644
> +++ b/redhat/rdma-core.spec
> @@ -20,6 +20,7 @@ BuildRequires: pkgconfig(libnl-3.0)
>  BuildRequires: pkgconfig(libnl-route-3.0)
>  BuildRequires: valgrind-devel
>  BuildRequires: systemd
> +BuildRequires: python
>  
>  Requires: dracut, kmod, systemd
>  # Red Hat/Fedora previously shipped redhat/ as a stand-alone

I added the debian bit and bundled it here:

https://github.com/linux-rdma/rdma-core/pull/106

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/rdma-core.spec b/rdma-core.spec
index 3f6e73a0..6a280fe1 100644
--- a/rdma-core.spec
+++ b/rdma-core.spec
@@ -19,6 +19,7 @@  BuildRequires: pkgconfig
 BuildRequires: pkgconfig(libnl-3.0)
 BuildRequires: pkgconfig(libnl-route-3.0)
 BuildRequires: valgrind-devel
+BuildRequires: python
 
 # Since we recommend developers use Ninja, so should packagers, for consistency.
 %define CMAKE_FLAGS %{nil}
diff --git a/redhat/rdma-core.spec b/redhat/rdma-core.spec
index 5f6ead42..6b56eae4 100644
--- a/redhat/rdma-core.spec
+++ b/redhat/rdma-core.spec
@@ -20,6 +20,7 @@  BuildRequires: pkgconfig(libnl-3.0)
 BuildRequires: pkgconfig(libnl-route-3.0)
 BuildRequires: valgrind-devel
 BuildRequires: systemd
+BuildRequires: python
 
 Requires: dracut, kmod, systemd
 # Red Hat/Fedora previously shipped redhat/ as a stand-alone