diff mbox

[rdma-core] fix udma_to_device_barrier on aarch64

Message ID 20170323021224.35722-1-jarod@redhat.com (mailing list archive)
State Accepted
Headers show

Commit Message

Jarod Wilson March 23, 2017, 2:12 a.m. UTC
The definition for udma_to_device_barrier on aarch64 is missing. Looks
like an oversight in the commit that removed the old barrier macros and
added this one.

Fixes: 85a5529dead5 ("Remove the old barrier macros")
CC: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 util/udma_barrier.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Gunthorpe March 23, 2017, 5 p.m. UTC | #1
On Wed, Mar 22, 2017 at 10:12:24PM -0400, Jarod Wilson wrote:
> The definition for udma_to_device_barrier on aarch64 is missing. Looks
> like an oversight in the commit that removed the old barrier macros and
> added this one.
> 
> Fixes: 85a5529dead5 ("Remove the old barrier macros")
> CC: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
>  util/udma_barrier.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/util/udma_barrier.h b/util/udma_barrier.h
> index 86578af5..9932a687 100644
> +++ b/util/udma_barrier.h
> @@ -93,7 +93,7 @@
>  #elif defined(__sparc_v9__)
>  #define udma_to_device_barrier() asm volatile("membar #StoreStore" ::: "memory")
>  #elif defined(__aarch64__)
> -#define wmb() asm volatile("dsb st" ::: "memory");
> +#define udma_to_device_barrier() asm volatile("dsb st" ::: "memory");
>  #elif defined(__sparc__) || defined(__s390x__)
>  #define udma_to_device_barrier() asm volatile("" ::: "memory")
>  #else

Doh, yep my bad.

https://github.com/linux-rdma/rdma-core/pull/106

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/util/udma_barrier.h b/util/udma_barrier.h
index 86578af5..9932a687 100644
--- a/util/udma_barrier.h
+++ b/util/udma_barrier.h
@@ -93,7 +93,7 @@ 
 #elif defined(__sparc_v9__)
 #define udma_to_device_barrier() asm volatile("membar #StoreStore" ::: "memory")
 #elif defined(__aarch64__)
-#define wmb() asm volatile("dsb st" ::: "memory");
+#define udma_to_device_barrier() asm volatile("dsb st" ::: "memory");
 #elif defined(__sparc__) || defined(__s390x__)
 #define udma_to_device_barrier() asm volatile("" ::: "memory")
 #else