| Message ID | 1490284420-26657-1-git-send-email-okaya@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 03/23/2017 10:53 AM, Sinan Kaya wrote:
> + depends on IPMI_SI||IPMI_SSIF
Blank spaces around ||.
Oops, yes, this is an issue. However, it should probably depend on IPMI_HANDLER, not the individual interface types. -corey On 03/23/2017 10:53 AM, Sinan Kaya wrote: > ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver > to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces. > > IPMI_SSIF is an alternative BMC communication method. It allows BMC to be > accessed over an I2C bus instead of a standard interface. > > Enabling ACPI_IPMI over IPMI_SSIF with this change. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 83e5f7e..8767062 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -256,7 +256,7 @@ config ACPI_PROCESSOR > > config ACPI_IPMI > tristate "IPMI" > - depends on IPMI_SI > + depends on IPMI_SI||IPMI_SSIF > default n > help > This driver enables the ACPI to access the BMC controller. And it -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/24/2017 10:56 PM, Corey Minyard wrote: > Oops, yes, this is an issue. > > However, it should probably depend on IPMI_HANDLER, not the individual interface types. > Thanks for the review. I posted V3 with your recommendation. > -corey
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 83e5f7e..8767062 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -256,7 +256,7 @@ config ACPI_PROCESSOR config ACPI_IPMI tristate "IPMI" - depends on IPMI_SI + depends on IPMI_SI||IPMI_SSIF default n help This driver enables the ACPI to access the BMC controller. And it
ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces. IPMI_SSIF is an alternative BMC communication method. It allows BMC to be accessed over an I2C bus instead of a standard interface. Enabling ACPI_IPMI over IPMI_SSIF with this change. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- drivers/acpi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)