| Message ID | 20170222144005.23447-3-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hello Dmitry, On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:<device>. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > The compatible strings don't have a vendor prefix because that's how it's > used currently, and changing this will be a Device Tree ABI break. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > What's your decision about this patch series? Best regards,
On Thu, Mar 23, 2017 at 04:14:56PM -0300, Javier Martinez Canillas wrote: > Hello Dmitry, > > On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote: > > The driver doesn't have a struct of_device_id table but supported devices > > are registered via Device Trees. This is working on the assumption that a > > I2C device registered via OF will always match a legacy I2C device ID and > > that the MODALIAS reported will always be of the form i2c:<device>. > > > > But this could change in the future so the correct approach is to have an > > OF device ID table if the devices are registered via OF. > > > > The compatible strings don't have a vendor prefix because that's how it's > > used currently, and changing this will be a Device Tree ABI break. > > > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > > > What's your decision about this patch series? OK, I queued them for -next. Could you also make a patch to update binding docs for silead? Thanks!
Hello Dmitry, On 03/23/2017 06:45 PM, Dmitry Torokhov wrote: > On Thu, Mar 23, 2017 at 04:14:56PM -0300, Javier Martinez Canillas wrote: >> Hello Dmitry, >> >> On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote: >>> The driver doesn't have a struct of_device_id table but supported devices >>> are registered via Device Trees. This is working on the assumption that a >>> I2C device registered via OF will always match a legacy I2C device ID and >>> that the MODALIAS reported will always be of the form i2c:<device>. >>> >>> But this could change in the future so the correct approach is to have an >>> OF device ID table if the devices are registered via OF. >>> >>> The compatible strings don't have a vendor prefix because that's how it's >>> used currently, and changing this will be a Device Tree ABI break. >>> >>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>> --- >>> >> >> What's your decision about this patch series? > > OK, I queued them for -next. Could you also make a patch to update Great, thanks a lot! > binding docs for silead? > Of course, I will. > Thanks! > Best regards,
diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c index 5a5778729e37..76bb51309a78 100644 --- a/drivers/input/keyboard/qt1070.c +++ b/drivers/input/keyboard/qt1070.c @@ -274,9 +274,18 @@ static const struct i2c_device_id qt1070_id[] = { }; MODULE_DEVICE_TABLE(i2c, qt1070_id); +#ifdef CONFIG_OF +static const struct of_device_id qt1070_of_match[] = { + { .compatible = "qt1070", }, + { }, +}; +MODULE_DEVICE_TABLE(of, qt1070_of_match); +#endif + static struct i2c_driver qt1070_driver = { .driver = { .name = "qt1070", + .of_match_table = of_match_ptr(qt1070_of_match), .pm = &qt1070_pm_ops, }, .id_table = qt1070_id,
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:<device>. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. The compatible strings don't have a vendor prefix because that's how it's used currently, and changing this will be a Device Tree ABI break. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes in v2: None drivers/input/keyboard/qt1070.c | 9 +++++++++ 1 file changed, 9 insertions(+)