| Message ID | 20170327132905.23133-1-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello, There is a typing error at the subject.(LEN_ON->LED_ON) Anyway, your patch is working well and looks good to me. I reviewed and tested with this patch on TM2. Reviewed-by: Jaechul Lee <jcsing.lee@samsung.com> Tested-by: Jaechul Lee <jcsing.lee@samsung.com> Best Regards, Jaechul Lee On Mon, Mar 27, 2017 at 10:29:05PM +0900, Andi Shyti wrote: > Commit 4e552c8cb5bc ("leds: add LED_ON brightness as boolean value") > has introduced the LED_ON enumeration value that can be used > instead of LED_FULL which has more of a linear value. > > Because the tm2-touchscreen doesn't have brightness levels, but > it's a simple on/off led, use LED_ON instead of LED_FULL. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > drivers/input/keyboard/tm2-touchkey.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c > index 485900f953e0..abc266e40e17 100644 > --- a/drivers/input/keyboard/tm2-touchkey.c > +++ b/drivers/input/keyboard/tm2-touchkey.c > @@ -213,7 +213,7 @@ static int tm2_touchkey_probe(struct i2c_client *client, > /* led device */ > touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME; > touchkey->led_dev.brightness = LED_FULL; > - touchkey->led_dev.max_brightness = LED_FULL; > + touchkey->led_dev.max_brightness = LED_ON; > touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set; > > error = devm_led_classdev_register(&client->dev, &touchkey->led_dev); > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c index 485900f953e0..abc266e40e17 100644 --- a/drivers/input/keyboard/tm2-touchkey.c +++ b/drivers/input/keyboard/tm2-touchkey.c @@ -213,7 +213,7 @@ static int tm2_touchkey_probe(struct i2c_client *client, /* led device */ touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME; touchkey->led_dev.brightness = LED_FULL; - touchkey->led_dev.max_brightness = LED_FULL; + touchkey->led_dev.max_brightness = LED_ON; touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set; error = devm_led_classdev_register(&client->dev, &touchkey->led_dev);
Commit 4e552c8cb5bc ("leds: add LED_ON brightness as boolean value") has introduced the LED_ON enumeration value that can be used instead of LED_FULL which has more of a linear value. Because the tm2-touchscreen doesn't have brightness levels, but it's a simple on/off led, use LED_ON instead of LED_FULL. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/input/keyboard/tm2-touchkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)