| Message ID | 20170327094520.3129-15-kishon@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Mon, Mar 27, 2017 at 03:15:10PM +0530, Kishon Vijay Abraham I wrote: > Add documentation for the optional #syscon-cells property to determine > the number of cells that should be given in the phandle while > referencing the syscon-node. > > Suggested-by: Rob Herring <robh@kernel.org> I did? When? I'm not remembering why we need this. Generally, phandles to a syscon are for a single defined purpose. When do we need a list of them? Rob > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > Documentation/devicetree/bindings/mfd/syscon.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon.txt > index 408f768686f1..446b47e8fb71 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.txt > +++ b/Documentation/devicetree/bindings/mfd/syscon.txt > @@ -16,6 +16,8 @@ Required properties: > Optional property: > - reg-io-width: the size (in bytes) of the IO accesses that should be > performed on the device. > +- #syscon-cells: determine the number of cells that should be given in the > + phandle while referencing this syscon-node. > > Examples: > gpr: iomuxc-gpr@020e0000 { > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 31, 2017 at 01:58:52PM -0500, Rob Herring wrote: > On Mon, Mar 27, 2017 at 03:15:10PM +0530, Kishon Vijay Abraham I wrote: > > Add documentation for the optional #syscon-cells property to determine > > the number of cells that should be given in the phandle while > > referencing the syscon-node. > > > > Suggested-by: Rob Herring <robh@kernel.org> > > I did? When? > > I'm not remembering why we need this. Generally, phandles to a syscon > are for a single defined purpose. When do we need a list of them? Ah, I remember now the context. I suggested using standard parsing function rather than open coding. I wasn't suggesting changing the binding. Instead of of_parse_phandle_with_args, can't of_parse_phandle_with_fixed_args work? Rob
Hi Rob, On Saturday 01 April 2017 12:36 AM, Rob Herring wrote: > On Fri, Mar 31, 2017 at 01:58:52PM -0500, Rob Herring wrote: >> On Mon, Mar 27, 2017 at 03:15:10PM +0530, Kishon Vijay Abraham I wrote: >>> Add documentation for the optional #syscon-cells property to determine >>> the number of cells that should be given in the phandle while >>> referencing the syscon-node. >>> >>> Suggested-by: Rob Herring <robh@kernel.org> >> >> I did? When? >> >> I'm not remembering why we need this. Generally, phandles to a syscon >> are for a single defined purpose. When do we need a list of them? > > Ah, I remember now the context. I suggested using standard parsing > function rather than open coding. I wasn't suggesting changing the > binding. Instead of of_parse_phandle_with_args, can't > of_parse_phandle_with_fixed_args work? yes, it can be used. Will change it my next revision. Thanks Kishon
diff --git a/Documentation/devicetree/bindings/mfd/syscon.txt b/Documentation/devicetree/bindings/mfd/syscon.txt index 408f768686f1..446b47e8fb71 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.txt +++ b/Documentation/devicetree/bindings/mfd/syscon.txt @@ -16,6 +16,8 @@ Required properties: Optional property: - reg-io-width: the size (in bytes) of the IO accesses that should be performed on the device. +- #syscon-cells: determine the number of cells that should be given in the + phandle while referencing this syscon-node. Examples: gpr: iomuxc-gpr@020e0000 {
Add documentation for the optional #syscon-cells property to determine the number of cells that should be given in the phandle while referencing the syscon-node. Suggested-by: Rob Herring <robh@kernel.org> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- Documentation/devicetree/bindings/mfd/syscon.txt | 2 ++ 1 file changed, 2 insertions(+)