diff mbox

[v3,1/2] ASoC: fsl_ssi: Remove FSLSSI_I2S_RATES definition

Message ID 1491421446-13799-1-git-send-email-festevam@gmail.com (mailing list archive)
State Accepted
Commit 580556774ad33adf427765d560f95f66cb01c295
Headers show

Commit Message

Fabio Estevam April 5, 2017, 7:44 p.m. UTC
From: Fabio Estevam <fabio.estevam@nxp.com>

The comment for the FSLSSI_I2S_RATES definition states that the
driver currently only supports I2S slave mode, which is no longer
correct.

As FSLSSI_I2S_RATES is the same as the standard SNDRV_PCM_RATE_CONTINUOUS,
just remove its definition and its comments to make the code simpler.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Chnages since v1:
- Simply remove FSLSSI_I2S_RATES

 sound/soc/fsl/fsl_ssi.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

Comments

Timur Tabi April 5, 2017, 7:51 p.m. UTC | #1
On 04/05/2017 02:44 PM, Fabio Estevam wrote:
> 
> The comment for the FSLSSI_I2S_RATES definition states that the
> driver currently only supports I2S slave mode, which is no longer
> correct.
> 
> As FSLSSI_I2S_RATES is the same as the standard SNDRV_PCM_RATE_CONTINUOUS,
> just remove its definition and its comments to make the code simpler.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

ACK
diff mbox

Patch

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index fde08660..0b74d1c 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -55,16 +55,6 @@ 
 #include "imx-pcm.h"
 
 /**
- * FSLSSI_I2S_RATES: sample rates supported by the I2S
- *
- * This driver currently only supports the SSI running in I2S slave mode,
- * which means the codec determines the sample rate.  Therefore, we tell
- * ALSA that we support all rates and let the codec driver decide what rates
- * are really supported.
- */
-#define FSLSSI_I2S_RATES SNDRV_PCM_RATE_CONTINUOUS
-
-/**
  * FSLSSI_I2S_FORMATS: audio formats supported by the SSI
  *
  * The SSI has a limitation in that the samples must be in the same byte
@@ -1212,14 +1202,14 @@  static struct snd_soc_dai_driver fsl_ssi_dai_template = {
 		.stream_name = "CPU-Playback",
 		.channels_min = 1,
 		.channels_max = 32,
-		.rates = FSLSSI_I2S_RATES,
+		.rates = SNDRV_PCM_RATE_CONTINUOUS,
 		.formats = FSLSSI_I2S_FORMATS,
 	},
 	.capture = {
 		.stream_name = "CPU-Capture",
 		.channels_min = 1,
 		.channels_max = 32,
-		.rates = FSLSSI_I2S_RATES,
+		.rates = SNDRV_PCM_RATE_CONTINUOUS,
 		.formats = FSLSSI_I2S_FORMATS,
 	},
 	.ops = &fsl_ssi_dai_ops,