diff mbox

clk: aggregate return codes of notify chains

Message ID 1490091386-4014-1-git-send-email-pdeschrijver@nvidia.com (mailing list archive)
State Accepted
Delegated to: Stephen Boyd
Headers show

Commit Message

Peter De Schrijver March 21, 2017, 10:16 a.m. UTC
In case there are multiple notify chains for the same clocks (because they
were registered by different users), we need to propagate potential failure
of any single one of them to the caller. Otherwise we eg risk violating the
V/f curve when a notifier is used for DVFS.

Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
---
 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stephen Boyd April 7, 2017, 7:47 p.m. UTC | #1
On 03/21, Peter De Schrijver wrote:
> In case there are multiple notify chains for the same clocks (because they
> were registered by different users), we need to propagate potential failure
> of any single one of them to the caller. Otherwise we eg risk violating the
> V/f curve when a notifier is used for DVFS.
> 
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> ---

Applied to clk-next. Let's see if anything blows up.
diff mbox

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 67201f6..f5f2bcd 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -966,6 +966,8 @@  static int __clk_notify(struct clk_core *core, unsigned long msg,
 			cnd.clk = cn->clk;
 			ret = srcu_notifier_call_chain(&cn->notifier_head, msg,
 					&cnd);
+			if (ret & NOTIFY_STOP_MASK)
+				return ret;
 		}
 	}