| Message ID | 20170405172224.38c1f9fb@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> In fact "internet" label on the case is uppercase, would this matter > for you for new bindings, or would you still use the lowercase version? I would use lower case, just to fix with the general convention that interface names are lower case. > > I would say, this is now too late. Changing an interface name will > > break configuration scripts. We are stuck with it. > > > > If it weren't for commit cb4f71c42988 that would have been obvious for > me as well. Yes, that was not nice. But it was also very earlier in the life of 38x, so it just affected a few developers with reference boards, not real products out in the wild, as far as i remember. Andrew
Hi Andrew, On Wed, 5 Apr 2017 17:50:32 +0200 Andrew Lunn <andrew@lunn.ch> wrote: > > In fact "internet" label on the case is uppercase, would this matter > > for you for new bindings, or would you still use the lowercase > > version? > > I would use lower case, just to fix with the general convention that > interface names are lower case. Thanks > > > > I would say, this is now too late. Changing an interface name will > > > break configuration scripts. We are stuck with it. > > > > > > > If it weren't for commit cb4f71c42988 that would have been obvious > > for me as well. > > Yes, that was not nice. But it was also very earlier in the life of > 38x, so it just affected a few developers with reference boards, not > real products out in the wild, as far as i remember. > > Andrew The mentioned commit bit me amongst others, see https://lkml.org/lkml/2016/8/21/62 In fact I expect the impact to be much lower this time around, before 4.10 DSA was no contender for swconfig (out of tree switch driver as used by OpenWrt and others). On Mamba ~200Mbit was top speed. Now they perform roughly the same. Thanks Ralph
On Wed, 5 Apr 2017 18:08:08 +0200 Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote: > Hi Andrew, > > On Wed, 5 Apr 2017 17:50:32 +0200 > Andrew Lunn <andrew@lunn.ch> wrote: > > > > I would say, this is now too late. Changing an interface name > > > > will break configuration scripts. We are stuck with it. > > > > > > > > > > If it weren't for commit cb4f71c42988 that would have been obvious > > > for me as well. > > > > Yes, that was not nice. But it was also very earlier in the life of > > 38x, so it just affected a few developers with reference boards, not > > real products out in the wild, as far as i remember. > > > > Andrew > > The mentioned commit bit me amongst others, see > https://lkml.org/lkml/2016/8/21/62 > > In fact I expect the impact to be much lower this time around, before > 4.10 DSA was no contender for swconfig (out of tree switch driver as > used by OpenWrt and others). On Mamba ~200Mbit was top speed. Now they > perform roughly the same. When I said much lower I left out the obvious, this only affects a specific product line respectively a single device unlike the 38x change. I asked Chad McCue, principal developer of McDebian [1] (the only "firmware" using DSA I know of / could make out) about this. McDebain already uses "wan" across all devices in the series. Ralph [1] https://github.com/Chadster766/McDebian
diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts index a1b6e68..3efceda 100644 --- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts +++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts @@ -53,13 +53,13 @@ #address-cells = <1>; #size-cells = <0>; - wan_amber@0 { - label = "caiman:amber:wan"; + internet_amber@0 { + label = "caiman:amber:internet"; reg = <0x0>; }; - wan_white@1 { - label = "caiman:white:wan"; + internet_white@1 { + label = "caiman:white:internet"; reg = <0x1>; }; diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts index a1a75af..4f2e7f6 100644 --- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts +++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts @@ -53,13 +53,13 @@ #address-cells = <1>; #size-cells = <0>; - wan_amber@0 { - label = "cobra:amber:wan"; + internet_amber@0 { + label = "cobra:amber:internet"; reg = <0x0>; }; - wan_white@1 { - label = "cobra:white:wan"; + internet_white@1 { + label = "cobra:white:internet"; reg = <0x1>; }; diff --git a/arch/arm/boot/dts/armada-385-linksys-shelby.dts b/arch/arm/boot/dts/armada-385-linksys-shelby.dts index c7a8ddd..a7b47f7 100644 --- a/arch/arm/boot/dts/armada-385-linksys-shelby.dts +++ b/arch/arm/boot/dts/armada-385-linksys-shelby.dts @@ -53,13 +53,13 @@ #address-cells = <1>; #size-cells = <0>; - wan_amber@0 { - label = "shelby:amber:wan"; + internet_amber@0 { + label = "shelby:amber:internet"; reg = <0x0>; }; - wan_white@1 { - label = "shelby:white:wan"; + internet_white@1 { + label = "shelby:white:internet"; reg = <0x1>; }; diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi index aa0d225..8460066 100644 --- a/arch/arm/boot/dts/armada-385-linksys.dtsi +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi @@ -145,7 +145,7 @@ port@4 { reg = <4>; - label = "wan"; + label = "internet"; }; port@5 { @@ -360,7 +360,7 @@ port@4 { reg = <4>; - label = "wan"; + label = "internet"; }; port@5 { diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts index 9efcf59..ed2fe8f 100644 --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts @@ -140,13 +140,13 @@ compatible = "ti,tlc59116"; reg = <0x68>; - wan_amber@0 { - label = "mamba:amber:wan"; + internet_amber@0 { + label = "mamba:amber:internet"; reg = <0x0>; }; - wan_white@1 { - label = "mamba:white:wan"; + internet_white@1 { + label = "mamba:white:internet"; reg = <0x1>; };