| Message ID | 20170328011909.150513-1-mka@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > This generates smaller resulting object code when compiled with clang. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index b2faa9319372..66bcdbf58371 100644 > --- a/Makefile > +++ b/Makefile > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) > endif > > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) > else > ifdef CONFIG_PROFILE_ALL_BRANCHES > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) > -- > 2.12.2.564.g063fe858b8-goog > This is the same as the following commit in LLVMLinux except Author/Signed-off-by. Who should the authorship really belong to? commit 186e62808239c603bfa308d5ea994a10d67bb409 Author: Behan Webster <behanw@converseincode.com> Date: Thu Oct 16 14:28:54 2014 +0200 LLVMLinux: use -Oz instead of -Os when using clang This generates smaller resulting object code when compiled with clang. Signed-off-by: Behan Webster <behanw@converseincode.com>
El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit: > 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > > This generates smaller resulting object code when compiled with clang. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > --- > > Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index b2faa9319372..66bcdbf58371 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) > > endif > > > > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE > > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) > > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) > > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) > > else > > ifdef CONFIG_PROFILE_ALL_BRANCHES > > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) > > > > > > This is the same as the following commit in LLVMLinux > except Author/Signed-off-by. > > Who should the authorship really belong to? (this time without html, sorry for the noise) It should belong to Behan, I missed to add a 'From' tag, sorry about that. Should I resend with the tag or can you fix it when applying the patch? Matthias > commit 186e62808239c603bfa308d5ea994a10d67bb409 > Author: Behan Webster <behanw@converseincode.com> > Date: Thu Oct 16 14:28:54 2014 +0200 > > LLVMLinux: use -Oz instead of -Os when using clang > > This generates smaller resulting object code when compiled with clang. > > Signed-off-by: Behan Webster <behanw@converseincode.com> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Matthias, 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit: > >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: >> > This generates smaller resulting object code when compiled with clang. >> > >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> >> > --- >> > Makefile | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/Makefile b/Makefile >> > index b2faa9319372..66bcdbf58371 100644 >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) >> > endif >> > >> > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE >> > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) >> > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) >> > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) >> > else >> > ifdef CONFIG_PROFILE_ALL_BRANCHES >> > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) >> > >> >> >> >> This is the same as the following commit in LLVMLinux >> except Author/Signed-off-by. >> >> Who should the authorship really belong to? > > (this time without html, sorry for the noise) > > It should belong to Behan, I missed to add a 'From' tag, sorry about > that. Should I resend with the tag or can you fix it when applying the > patch? No need to re-send it. I can fixup it manually.
Hi Masahiro, El Fri, Mar 31, 2017 at 02:57:43AM +0900 Masahiro Yamada ha dit: > 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit: > > > >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > >> > This generates smaller resulting object code when compiled with clang. > >> > > >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > >> > --- > >> > Makefile | 3 ++- > >> > 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > >> > diff --git a/Makefile b/Makefile > >> > index b2faa9319372..66bcdbf58371 100644 > >> > --- a/Makefile > >> > +++ b/Makefile > >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) > >> > endif > >> > > >> > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE > >> > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) > >> > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) > >> > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) > >> > else > >> > ifdef CONFIG_PROFILE_ALL_BRANCHES > >> > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) > >> > > >> > >> > >> > >> This is the same as the following commit in LLVMLinux > >> except Author/Signed-off-by. > >> > >> Who should the authorship really belong to? > > > > (this time without html, sorry for the noise) > > > > It should belong to Behan, I missed to add a 'From' tag, sorry about > > that. Should I resend with the tag or can you fix it when applying the > > patch? > > > No need to re-send it. I can fixup it manually. I couldn't locate this patch in your tree, has it been picked up? Thanks Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Matthias, 2017-04-11 3:08 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: > Hi Masahiro, > > El Fri, Mar 31, 2017 at 02:57:43AM +0900 Masahiro Yamada ha dit: > >> 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: >> > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit: >> > >> >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: >> >> > This generates smaller resulting object code when compiled with clang. >> >> > >> >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> >> >> > --- >> >> > Makefile | 3 ++- >> >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> >> > >> >> > diff --git a/Makefile b/Makefile >> >> > index b2faa9319372..66bcdbf58371 100644 >> >> > --- a/Makefile >> >> > +++ b/Makefile >> >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) >> >> > endif >> >> > >> >> > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE >> >> > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) >> >> > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) >> >> > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) >> >> > else >> >> > ifdef CONFIG_PROFILE_ALL_BRANCHES >> >> > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) >> >> > >> >> >> >> >> >> >> >> This is the same as the following commit in LLVMLinux >> >> except Author/Signed-off-by. >> >> >> >> Who should the authorship really belong to? >> > >> > (this time without html, sorry for the noise) >> > >> > It should belong to Behan, I missed to add a 'From' tag, sorry about >> > that. Should I resend with the tag or can you fix it when applying the >> > patch? >> >> >> No need to re-send it. I can fixup it manually. > > I couldn't locate this patch in your tree, has it been picked up? > I will pick this up shortly. Sorry for the delay.
2017-04-12 12:38 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > Hi Matthias, > > > 2017-04-11 3:08 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: >> Hi Masahiro, >> >> El Fri, Mar 31, 2017 at 02:57:43AM +0900 Masahiro Yamada ha dit: >> >>> 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: >>> > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit: >>> > >>> >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>: >>> >> > This generates smaller resulting object code when compiled with clang. >>> >> > >>> >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> >>> >> > --- >>> >> > Makefile | 3 ++- >>> >> > 1 file changed, 2 insertions(+), 1 deletion(-) >>> >> > >>> >> > diff --git a/Makefile b/Makefile >>> >> > index b2faa9319372..66bcdbf58371 100644 >>> >> > --- a/Makefile >>> >> > +++ b/Makefile >>> >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) >>> >> > endif >>> >> > >>> >> > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE >>> >> > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) >>> >> > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) >>> >> > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) >>> >> > else >>> >> > ifdef CONFIG_PROFILE_ALL_BRANCHES >>> >> > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) >>> >> > >>> >> >>> >> >>> >> >>> >> This is the same as the following commit in LLVMLinux >>> >> except Author/Signed-off-by. >>> >> >>> >> Who should the authorship really belong to? >>> > >>> > (this time without html, sorry for the noise) >>> > >>> > It should belong to Behan, I missed to add a 'From' tag, sorry about >>> > that. Should I resend with the tag or can you fix it when applying the >>> > patch? >>> >>> >>> No need to re-send it. I can fixup it manually. >> >> I couldn't locate this patch in your tree, has it been picked up? >> > > > I will pick this up shortly. Sorry for the delay. > Applied to linux-kbuild/kbuild. Thanks!
diff --git a/Makefile b/Makefile index b2faa9319372..66bcdbf58371 100644 --- a/Makefile +++ b/Makefile @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,) endif ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os) +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,) else ifdef CONFIG_PROFILE_ALL_BRANCHES KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,)
This generates smaller resulting object code when compiled with clang. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)