| Message ID | 20170403091444.29876-2-clabbe.montjoie@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Alex do you can check if this has to be done for ST platforms? I do not remember that it was necessary when build as module so I cannot expect this should be only for dwmac-sun8i. Regards peppe On 4/3/2017 11:14 AM, Corentin Labbe wrote: > Thoses symbol will be needed for the dwmac-sun8i ethernet driver. > For letting it to be build as module, they need to be exported. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > index 38f9430..67af0bd 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > @@ -248,6 +248,7 @@ void stmmac_set_mac_addr(void __iomem *ioaddr, u8 addr[6], > data = (addr[3] << 24) | (addr[2] << 16) | (addr[1] << 8) | addr[0]; > writel(data, ioaddr + low); > } > +EXPORT_SYMBOL_GPL(stmmac_set_mac_addr); > > /* Enable disable MAC RX/TX */ > void stmmac_set_mac(void __iomem *ioaddr, bool enable) > @@ -279,4 +280,4 @@ void stmmac_get_mac_addr(void __iomem *ioaddr, unsigned char *addr, > addr[4] = hi_addr & 0xff; > addr[5] = (hi_addr >> 8) & 0xff; > } > - > +EXPORT_SYMBOL_GPL(stmmac_get_mac_addr);
On Mon, Apr 03, 2017 at 02:39:03PM +0200, Giuseppe CAVALLARO wrote: > Hello Alex > > do you can check if this has to be done for ST platforms? > I do not remember that it was necessary when build as module so > I cannot expect this should be only for dwmac-sun8i. > > Regards > peppe > dwmac-sun8i is simply the first "user" of stmmac_[sg]et_mac_addr outside of stmmac-objs Regards
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c index 38f9430..67af0bd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c @@ -248,6 +248,7 @@ void stmmac_set_mac_addr(void __iomem *ioaddr, u8 addr[6], data = (addr[3] << 24) | (addr[2] << 16) | (addr[1] << 8) | addr[0]; writel(data, ioaddr + low); } +EXPORT_SYMBOL_GPL(stmmac_set_mac_addr); /* Enable disable MAC RX/TX */ void stmmac_set_mac(void __iomem *ioaddr, bool enable) @@ -279,4 +280,4 @@ void stmmac_get_mac_addr(void __iomem *ioaddr, unsigned char *addr, addr[4] = hi_addr & 0xff; addr[5] = (hi_addr >> 8) & 0xff; } - +EXPORT_SYMBOL_GPL(stmmac_get_mac_addr);
Thoses symbol will be needed for the dwmac-sun8i ethernet driver. For letting it to be build as module, they need to be exported. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)