| Message ID | 20170412111400.2296-14-clabbe.montjoie@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 12, 2017 at 01:13:55PM +0200, Corentin Labbe wrote: > The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit > connections. It is very similar to the device found in the Allwinner > H3, but lacks the internal 100 Mbit PHY and its associated control > bits. > This adds the necessary bits to the Allwinner A64 SoC .dtsi, but keeps > it disabled at this level. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 37 +++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 0b0f4ab..2569827 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -287,6 +287,23 @@ > bias-pull-up; > }; > > + rmii_pins: rmii_pins { > + pins = "PD10", "PD11", "PD13", "PD14", > + "PD17", "PD18", "PD19", "PD20", > + "PD22", "PD23"; Please align the wrapped lines on the first pin. > + function = "emac"; > + drive-strength = <40>; Do you actually need that for all the boards, or only a few of them? Maxime
On Wed, Apr 12, 2017 at 02:41:53PM +0200, Maxime Ripard wrote: > On Wed, Apr 12, 2017 at 01:13:55PM +0200, Corentin Labbe wrote: > > The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit > > connections. It is very similar to the device found in the Allwinner > > H3, but lacks the internal 100 Mbit PHY and its associated control > > bits. > > This adds the necessary bits to the Allwinner A64 SoC .dtsi, but keeps > > it disabled at this level. > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 37 +++++++++++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > index 0b0f4ab..2569827 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -287,6 +287,23 @@ > > bias-pull-up; > > }; > > > > + rmii_pins: rmii_pins { > > + pins = "PD10", "PD11", "PD13", "PD14", > > + "PD17", "PD18", "PD19", "PD20", > > + "PD22", "PD23"; > > Please align the wrapped lines on the first pin. > OK > > + function = "emac"; > > + drive-strength = <40>; > > Do you actually need that for all the boards, or only a few of them? I have tried to use lower value without success on some boards. (opipc/pine64 in my memory) Regards Corentin Labbe
On Mon, Apr 24, 2017 at 8:24 PM, Corentin Labbe <clabbe.montjoie@gmail.com> wrote: > On Wed, Apr 12, 2017 at 02:41:53PM +0200, Maxime Ripard wrote: >> On Wed, Apr 12, 2017 at 01:13:55PM +0200, Corentin Labbe wrote: >> > The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit >> > connections. It is very similar to the device found in the Allwinner >> > H3, but lacks the internal 100 Mbit PHY and its associated control >> > bits. >> > This adds the necessary bits to the Allwinner A64 SoC .dtsi, but keeps >> > it disabled at this level. >> > >> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> >> > --- >> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 37 +++++++++++++++++++++++++++ >> > 1 file changed, 37 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> > index 0b0f4ab..2569827 100644 >> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> > @@ -287,6 +287,23 @@ >> > bias-pull-up; >> > }; >> > >> > + rmii_pins: rmii_pins { >> > + pins = "PD10", "PD11", "PD13", "PD14", >> > + "PD17", "PD18", "PD19", "PD20", >> > + "PD22", "PD23"; >> >> Please align the wrapped lines on the first pin. >> > > OK > >> > + function = "emac"; >> > + drive-strength = <40>; >> >> Do you actually need that for all the boards, or only a few of them? > > I have tried to use lower value without success on some boards. (opipc/pine64 in my memory) FYI we need them for all the boards that use RGMII. The signals at gigabit speed run at 125 MHz DDR. For RMII we probably don't need it. Even at 100 Mbps, it's only 50 MHz SDR. drive-strength = <30> should be enough. ChenYu
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 0b0f4ab..2569827 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -287,6 +287,23 @@ bias-pull-up; }; + rmii_pins: rmii_pins { + pins = "PD10", "PD11", "PD13", "PD14", + "PD17", "PD18", "PD19", "PD20", + "PD22", "PD23"; + function = "emac"; + drive-strength = <40>; + }; + + rgmii_pins: rgmii_pins { + pins = "PD8", "PD9", "PD10", "PD11", + "PD12", "PD13", "PD15", + "PD16", "PD17", "PD18", "PD19", + "PD20", "PD21", "PD22", "PD23"; + function = "emac"; + drive-strength = <40>; + }; + uart0_pins_a: uart0@0 { pins = "PB8", "PB9"; function = "uart0"; @@ -391,6 +408,26 @@ #size-cells = <0>; }; + emac: ethernet@1c30000 { + compatible = "allwinner,sun50i-a64-emac"; + syscon = <&syscon>; + reg = <0x01c30000 0x100>; + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq"; + resets = <&ccu RST_BUS_EMAC>; + reset-names = "stmmaceth"; + clocks = <&ccu CLK_BUS_EMAC>; + clock-names = "stmmaceth"; + status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; + + mdio: mdio { + #address-cells = <1>; + #size-cells = <0>; + }; + }; + gic: interrupt-controller@1c81000 { compatible = "arm,gic-400"; reg = <0x01c81000 0x1000>,
The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit connections. It is very similar to the device found in the Allwinner H3, but lacks the internal 100 Mbit PHY and its associated control bits. This adds the necessary bits to the Allwinner A64 SoC .dtsi, but keeps it disabled at this level. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 37 +++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)