| Message ID | 20170417213311.29924-2-alistair.francis@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 17, 2017 at 02:33:11PM -0700, Alistair Francis wrote: > The POSIX spec specifies to use: > #include <signal.h> > instead of: > #include <sys/signal.h> > as seen here: > http://pubs.opengroup.org/onlinepubs/009695399/functions/signal.html > > This removes the warning: > #warning redirecting incorrect #include <sys/signal.h> to <signal.h> > when building with the musl C-library. > > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> Acked-by: Wei Liu <wei.liu2@citrix.com>
On 04/18/2017 01:03 PM, Wei Liu wrote: > On Mon, Apr 17, 2017 at 02:33:11PM -0700, Alistair Francis wrote: >> The POSIX spec specifies to use: >> #include <signal.h> >> instead of: >> #include <sys/signal.h> >> as seen here: >> http://pubs.opengroup.org/onlinepubs/009695399/functions/signal.html >> >> This removes the warning: >> #warning redirecting incorrect #include <sys/signal.h> to <signal.h> >> when building with the musl C-library. >> >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > > Acked-by: Wei Liu <wei.liu2@citrix.com> FWIW: Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com> Thanks, Razvan
On Tue, Apr 18, 2017 at 01:16:04PM +0300, Razvan Cojocaru wrote: > On 04/18/2017 01:03 PM, Wei Liu wrote: > > On Mon, Apr 17, 2017 at 02:33:11PM -0700, Alistair Francis wrote: > >> The POSIX spec specifies to use: > >> #include <signal.h> > >> instead of: > >> #include <sys/signal.h> > >> as seen here: > >> http://pubs.opengroup.org/onlinepubs/009695399/functions/signal.html > >> > >> This removes the warning: > >> #warning redirecting incorrect #include <sys/signal.h> to <signal.h> > >> when building with the musl C-library. > >> > >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > > > > Acked-by: Wei Liu <wei.liu2@citrix.com> > > FWIW: > > Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com> > Thanks! > > Thanks, > Razvan
Alistair Francis writes ("[PATCH 2/2] tools: Use POSIX signal.h instead of sys/signal.h"):
> The POSIX spec specifies to use:
> #include <signal.h>
> instead of:
> #include <sys/signal.h>
> as seen here:
> http://pubs.opengroup.org/onlinepubs/009695399/functions/signal.html
Both:
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Julien, I think this pair are a candidate for 4.9.
Ian.
diff --git a/tools/blktap2/drivers/tapdisk-server.c b/tools/blktap2/drivers/tapdisk-server.c index eecde3d23f..71315bb069 100644 --- a/tools/blktap2/drivers/tapdisk-server.c +++ b/tools/blktap2/drivers/tapdisk-server.c @@ -30,7 +30,7 @@ #include <unistd.h> #include <stdlib.h> #include <sys/ioctl.h> -#include <sys/signal.h> +#include <signal.h> #include "tapdisk-utils.h" #include "tapdisk-server.h"
The POSIX spec specifies to use: #include <signal.h> instead of: #include <sys/signal.h> as seen here: http://pubs.opengroup.org/onlinepubs/009695399/functions/signal.html This removes the warning: #warning redirecting incorrect #include <sys/signal.h> to <signal.h> when building with the musl C-library. Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> --- tools/blktap2/drivers/tapdisk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)