| Message ID | 20170419202204.7689-1-alexandre.belloni@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Alexandre, On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote: > The rv4162 vendor is microcrystal, not ST. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Acked-by: Gary Bisson <gary.bisson@boundarydevices.com> Thanks for fixing it. Regards, Gary
On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote: > The rv4162 vendor is microcrystal, not ST. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > index bad3c9f9eeac..b63134e3b51a 100644 > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > @@ -408,7 +408,7 @@ > }; > > rtc: rtc@68 { > - compatible = "st,rv4162"; > + compatible = "microcrystal,rv4162"; The compatible is not documented? Shawn > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_rv4162>; > reg = <0x68>; > -- > 2.11.0 >
Hi Shawn, On Wed, May 3, 2017 at 5:50 AM, Shawn Guo <shawnguo@kernel.org> wrote: >> rtc: rtc@68 { >> - compatible = "st,rv4162"; >> + compatible = "microcrystal,rv4162"; > > The compatible is not documented? This compatible has been added in a897bf138c9b443 ("rtc: m41t80: Add proper compatible for rv4162") in linux-next, so it will be present in 4.12-rc1.
On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote: > On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote: > > The rv4162 vendor is microcrystal, not ST. > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > --- > > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > index bad3c9f9eeac..b63134e3b51a 100644 > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > @@ -408,7 +408,7 @@ > > }; > > > > rtc: rtc@68 { > > - compatible = "st,rv4162"; > > + compatible = "microcrystal,rv4162"; > > The compatible is not documented? > No, it wasn't. Like for many i2c devices, the driver predates DT and didn't need any specific code to be used from DT. Basically, the i2c core was using the i2c_device_ids to match the DT compatible string. This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811. I'm planning to document all the undocumented ones soon. > Shawn > > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_rv4162>; > > reg = <0x68>; > > -- > > 2.11.0 > >
On 03/05/2017 at 19:14:42 -0300, Fabio Estevam wrote: > Hi Shawn, > > On Wed, May 3, 2017 at 5:50 AM, Shawn Guo <shawnguo@kernel.org> wrote: > > >> rtc: rtc@68 { > >> - compatible = "st,rv4162"; > >> + compatible = "microcrystal,rv4162"; > > > > The compatible is not documented? > > This compatible has been added in a897bf138c9b443 ("rtc: m41t80: Add > proper compatible for rv4162") in linux-next, so it will be present in > 4.12-rc1. Yes, and to be clear, both patches are independent and can be applied in any order because the iéC core will still continue to match the i2c_device_ids if the compatible doesn't match.
On Thu, May 04, 2017 at 12:16:20AM +0200, Alexandre Belloni wrote: > On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote: > > On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote: > > > The rv4162 vendor is microcrystal, not ST. > > > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > > --- > > > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > > index bad3c9f9eeac..b63134e3b51a 100644 > > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > > @@ -408,7 +408,7 @@ > > > }; > > > > > > rtc: rtc@68 { > > > - compatible = "st,rv4162"; > > > + compatible = "microcrystal,rv4162"; > > > > The compatible is not documented? > > > > No, it wasn't. Like for many i2c devices, the driver predates DT and > didn't need any specific code to be used from DT. Basically, the i2c > core was using the i2c_device_ids to match the DT compatible string. > This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811. > > I'm planning to document all the undocumented ones soon. I applied all 3 patches. Please remember to document the compatible. Shawn
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi index bad3c9f9eeac..b63134e3b51a 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi @@ -408,7 +408,7 @@ }; rtc: rtc@68 { - compatible = "st,rv4162"; + compatible = "microcrystal,rv4162"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_rv4162>; reg = <0x68>;
The rv4162 vendor is microcrystal, not ST. Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> --- arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)