diff mbox

ASoC: tas2552: Propagate the error code in suspend/resume

Message ID 1493081029-23975-1-git-send-email-festevam@gmail.com (mailing list archive)
State Accepted
Commit 12dc0f3b1ee599d3951698a2927c584700840b03
Headers show

Commit Message

Fabio Estevam April 25, 2017, 12:43 a.m. UTC 
From: Fabio Estevam <fabio.estevam@nxp.com>

tas2552_suspend() and tas2552_resume() currently always return success,
even though they may fail.

Fix this behaviour by always propagating the error code.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 sound/soc/codecs/tas2552.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dan Murphy April 25, 2017, 12:12 p.m. UTC | #1 
On 04/24/2017 07:43 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> tas2552_suspend() and tas2552_resume() currently always return success,
> even though they may fail.
> 
> Fix this behaviour by always propagating the error code.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Reviewed-by: Dan Murphy <dmurphy@ti.com>

> ---
>  sound/soc/codecs/tas2552.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
> index fd5251e..8840f72 100644
> --- a/sound/soc/codecs/tas2552.c
> +++ b/sound/soc/codecs/tas2552.c
> @@ -637,7 +637,7 @@ static int tas2552_suspend(struct snd_soc_codec *codec)
>  	if (ret != 0)
>  		dev_err(codec->dev, "Failed to disable supplies: %d\n",
>  			ret);
> -	return 0;
> +	return ret;
>  }
>  
>  static int tas2552_resume(struct snd_soc_codec *codec)
> @@ -653,7 +653,7 @@ static int tas2552_resume(struct snd_soc_codec *codec)
>  			ret);
>  	}
>  
> -	return 0;
> +	return ret;
>  }
>  #else
>  #define tas2552_suspend NULL
>
diff mbox

Patch

diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
index fd5251e..8840f72 100644
--- a/sound/soc/codecs/tas2552.c
+++ b/sound/soc/codecs/tas2552.c
@@ -637,7 +637,7 @@  static int tas2552_suspend(struct snd_soc_codec *codec)
 	if (ret != 0)
 		dev_err(codec->dev, "Failed to disable supplies: %d\n",
 			ret);
-	return 0;
+	return ret;
 }
 
 static int tas2552_resume(struct snd_soc_codec *codec)
@@ -653,7 +653,7 @@  static int tas2552_resume(struct snd_soc_codec *codec)
 			ret);
 	}
 
-	return 0;
+	return ret;
 }
 #else
 #define tas2552_suspend NULL