| Message ID | 1493317564-18026-5-git-send-email-kbingham@kernel.org (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
Hello! On 4/27/2017 9:26 PM, Kieran Bingham wrote: > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Provide bindings between the VIN, CSI and the ADV7482 on the r8a7795. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 129 +++++++++++++++++++++ > 1 file changed, 129 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > index 27b9bae60dc0..a20623faa9d2 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts [...] > @@ -387,6 +403,50 @@ > }; > }; > > +&i2c4 { > + status = "okay"; > + > + clock-frequency = <100000>; > + > + video_receiver@70 { Hyphens are preferred in the node names. [...] MBR, Sergei
On Fri, Apr 28, 2017 at 10:52 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 4/27/2017 9:26 PM, Kieran Bingham wrote: >> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > > [...] >> >> @@ -387,6 +403,50 @@ >> }; >> }; >> >> +&i2c4 { >> + status = "okay"; >> + >> + clock-frequency = <100000>; >> + >> + video_receiver@70 { > > > Hyphens are preferred in the node names. Definitely: make W=1 dtbs Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 28/04/17 11:04, Geert Uytterhoeven wrote: > On Fri, Apr 28, 2017 at 10:52 AM, Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com> wrote: >> On 4/27/2017 9:26 PM, Kieran Bingham wrote: >>> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts >>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts >> >> [...] >>> >>> @@ -387,6 +403,50 @@ >>> }; >>> }; >>> >>> +&i2c4 { >>> + status = "okay"; >>> + >>> + clock-frequency = <100000>; >>> + >>> + video_receiver@70 { >> >> >> Hyphens are preferred in the node names. > > Definitely: make W=1 dtbs Thanks guys, - I didn't know about that one. I'll update my build script so it's always in place :) -- Regards Kieran > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts index 27b9bae60dc0..a20623faa9d2 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts @@ -196,6 +196,22 @@ }; }; }; + + hdmi { + port { + hdmi_in: endpoint { + remote-endpoint = <&adv7482_hdmi>; + }; + }; + }; + + cvbs { + port { + cvbs_in: endpoint { + remote-endpoint = <&adv7482_ain8>; + }; + }; + }; }; &du { @@ -387,6 +403,50 @@ }; }; +&i2c4 { + status = "okay"; + + clock-frequency = <100000>; + + video_receiver@70 { + compatible = "adi,adv7482"; + reg = <0x70>; + + #address-cells = <1>; + #size-cells = <0>; + + port@8 { + adv7482_ain8: endpoint@1 { + remote-endpoint = <&cvbs_in>; + }; + }; + + port@9 { + adv7482_hdmi: endpoint@1 { + remote-endpoint = <&hdmi_in>; + }; + }; + + port@11 { + reg = <11>; + adv7482_txa: endpoint@1 { + clock-lanes = <0>; + data-lanes = <1 2 3 4>; + remote-endpoint = <&csi40_in>; + }; + }; + + port@12 { + reg = <12>; + adv7482_txb: endpoint@1 { + clock-lanes = <0>; + data-lanes = <1>; + remote-endpoint = <&csi20_in>; + }; + }; + }; +}; + &rcar_sound { pinctrl-0 = <&sound_pins &sound_clk_pins>; pinctrl-names = "default"; @@ -577,3 +637,72 @@ &pciec1 { status = "okay"; }; + +&vin0 { + status = "okay"; +}; + +&vin1 { + status = "okay"; +}; + +&vin2 { + status = "okay"; +}; + +&vin3 { + status = "okay"; +}; + +&vin4 { + status = "okay"; +}; + +&vin5 { + status = "okay"; +}; + +&vin6 { + status = "okay"; +}; + +&vin7 { + status = "okay"; +}; + +&csi20 { + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + csi20_in: endpoint@0 { + clock-lanes = <0>; + data-lanes = <1>; + remote-endpoint = <&adv7482_txb>; + }; + }; + }; +}; + +&csi40 { + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + csi40_in: endpoint@0 { + clock-lanes = <0>; + data-lanes = <1 2 3 4>; + remote-endpoint = <&adv7482_txa>; + }; + }; + }; +};