| Message ID | 20170504105052.18579-1-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Anthony PERARD writes ("[PATCH for-4.9] libs/devicemodel: Fix dependency with libxencall"):
> libxendevicemodel.so do depends on libxencall.so but the dependency was
> missing at link time.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
IMO this should indeed go into 4.9.
Ian.
On 04/05/17 11:55, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH for-4.9] libs/devicemodel: Fix dependency with libxencall"): >> libxendevicemodel.so do depends on libxencall.so but the dependency was >> missing at link time. > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > > IMO this should indeed go into 4.9. Release-acked-by: Julien Grall <julien.grall@arm.com> > > Ian. >
On Thu, May 04, 2017 at 01:53:00PM +0100, Julien Grall wrote: > > > On 04/05/17 11:55, Ian Jackson wrote: > > Anthony PERARD writes ("[PATCH for-4.9] libs/devicemodel: Fix dependency with libxencall"): > > > libxendevicemodel.so do depends on libxencall.so but the dependency was > > > missing at link time. > > > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > > > > IMO this should indeed go into 4.9. > > Release-acked-by: Julien Grall <julien.grall@arm.com> > Acked + applied.
diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile index 55626a5049..81fa5a4ac4 100644 --- a/tools/libs/devicemodel/Makefile +++ b/tools/libs/devicemodel/Makefile @@ -63,7 +63,7 @@ libxendevicemodel.so.$(MAJOR): libxendevicemodel.so.$(MAJOR).$(MINOR) $(SYMLINK_SHLIB) $< $@ libxendevicemodel.so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxendevicemodel.map - $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxencall) $(APPEND_LDFLAGS) .PHONY: install install: build
libxendevicemodel.so do depends on libxencall.so but the dependency was missing at link time. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/libs/devicemodel/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)