diff mbox

power: supply: bq27xxx: make bq27xxx_battery_settings static

Message ID 20170503104554.23019-1-colin.king@canonical.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Colin King May 3, 2017, 10:45 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The function bq27xxx_battery_settings can be made static as it
does not need to be in global scope.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/power/supply/bq27xxx_battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Liam Breck May 4, 2017, 6:30 a.m. UTC | #1 
[dropped some CCs]

Hi Colin,

On Wed, May 3, 2017 at 3:45 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.

Thanks for flagging that. I've fixed it in the v13 series (just posted
to linux-pm); v12 landed in -next prematurely.


> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/power/supply/bq27xxx_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
>         /* assume bq27xxx_battery_update() is called hereafter */
>  }
>
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
>  {
>         struct power_supply_battery_info info = {};
>         unsigned int min, max;
> --
> 2.11.0
>
Pali Rohár May 4, 2017, 8:10 a.m. UTC | #2 
On Wednesday 03 May 2017 11:45:54 Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/power/supply/bq27xxx_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
>  	/* assume bq27xxx_battery_update() is called hereafter */
>  }
>  
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
>  {
>  	struct power_supply_battery_info info = {};
>  	unsigned int min, max;

Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Sebastian Reichel May 4, 2017, 3:24 p.m. UTC | #3 
Hi,

On Wed, May 03, 2017 at 11:45:54AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, I dropped Liam's patches instead.

-- Sebastian
diff mbox

Patch

diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
index 7152370b9d61..06f15da32464 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -1251,7 +1251,7 @@  static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
 	/* assume bq27xxx_battery_update() is called hereafter */
 }
 
-void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
+static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
 {
 	struct power_supply_battery_info info = {};
 	unsigned int min, max;