diff mbox

[1/5] ARM: dts: imx7-colibri: use OF graph to describe the display

Message ID 20170329232113.19078-1-stefan@agner.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Agner March 29, 2017, 11:21 p.m. UTC
To make use of the new eLCDIF DRM driver OF graph description is
required. Describe the display using OF graph nodes.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 38 +++++++++++------------------
 1 file changed, 14 insertions(+), 24 deletions(-)

Comments

Shawn Guo March 30, 2017, 1:16 p.m. UTC | #1
On Wed, Mar 29, 2017 at 04:21:09PM -0700, Stefan Agner wrote:
> To make use of the new eLCDIF DRM driver OF graph description is
> required. Describe the display using OF graph nodes.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Applied all, thanks.
Fabio Estevam May 5, 2017, 11:48 a.m. UTC | #2
Hi Stefan,

On Wed, Mar 29, 2017 at 8:21 PM, Stefan Agner <stefan@agner.ch> wrote:
> To make use of the new eLCDIF DRM driver OF graph description is
> required. Describe the display using OF graph nodes.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Could you please confirm that drm/mxsfb is working fine on 4.11 on your board?

I am converting mx6sx sdb to use drm/mxsfb and I noticed that when
board boots I get garbage on the display.

If I do a blank/unblank then things are displayed correctly.

Thanks
Fabio Estevam May 5, 2017, 1:18 p.m. UTC | #3
On Fri, May 5, 2017 at 8:48 AM, Fabio Estevam <festevam@gmail.com> wrote:

> Could you please confirm that drm/mxsfb is working fine on 4.11 on your board?
>
> I am converting mx6sx sdb to use drm/mxsfb and I noticed that when
> board boots I get garbage on the display.
>
> If I do a blank/unblank then things are displayed correctly.

Ok, I managed to fix the drm/mxsfb driver.

Will submit a patch shortly.
Stefan Agner May 5, 2017, 11:52 p.m. UTC | #4
On 2017-05-05 06:18, Fabio Estevam wrote:
> On Fri, May 5, 2017 at 8:48 AM, Fabio Estevam <festevam@gmail.com> wrote:
> 
>> Could you please confirm that drm/mxsfb is working fine on 4.11 on your board?
>>
>> I am converting mx6sx sdb to use drm/mxsfb and I noticed that when
>> board boots I get garbage on the display.
>>
>> If I do a blank/unblank then things are displayed correctly.
> 
> Ok, I managed to fix the drm/mxsfb driver.
> 
> Will submit a patch shortly.

FWIW, it works, on i.MX 7 here, but I also have a U-Boot which
initialized eLCDIF first.

Will check your patch and without U-Boot eLCDIF support.

--
Stefan
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
index 373ee19196a6..7a98a45a0d95 100644
--- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
@@ -44,6 +44,17 @@ 
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
+
+	panel: panel {
+		compatible = "edt,et057090dhu";
+		backlight = <&bl>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&lcdif_out>;
+			};
+		};
+	};
 };
 
 &bl {
@@ -75,32 +86,11 @@ 
 };
 
 &lcdif {
-	display = <&display0>;
 	status = "okay";
 
-	display0: lcd-display {
-		bits-per-pixel = <16>;
-		bus-width = <18>;
-
-		display-timings {
-			native-mode = <&timing_vga>;
-
-			/* Standard VGA timing */
-			timing_vga: 640x480 {
-				clock-frequency = <25175000>;
-				hactive = <640>;
-				vactive = <480>;
-				hback-porch = <40>;
-				hfront-porch = <24>;
-				vback-porch = <32>;
-				vfront-porch = <11>;
-				hsync-len = <96>;
-				vsync-len = <2>;
-				de-active = <1>;
-				hsync-active = <0>;
-				vsync-active = <0>;
-				pixelclk-active = <0>;
-			};
+	port {
+		lcdif_out: endpoint {
+			remote-endpoint = <&panel_in>;
 		};
 	};
 };