| Message ID | 20170508181825.19854-1-eric@anholt.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/08/2017 11:18 AM, Eric Anholt wrote: > With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" > to let the module get built on a cygnus-only kernel. However, I > anticipate having a port for Kona soon, so just present the module on > all of BCM. This seems reasonable, but by replacing ARCH_BCM2835 which is common to ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems to benefit from this driver unless COMPILE_TEST is also selected, right? This could be: depends on COMPILE_TEST depends on ARCH_BCM # 32-bit ARM depends on ARCH_BCM2835 || ARCH_BCM_IPROC # 64-bit ARM or maybe down to just: depends on COMPILE_TEST and let DRM, COMMON_CLK and SND drive the bulk of the dependencies? > > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > > I would be sending this through drm-misc-next, assuming BCM > maintainers like it. > > drivers/gpu/drm/vc4/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig > index 973b4203c0b2..f136813abf56 100644 > --- a/drivers/gpu/drm/vc4/Kconfig > +++ b/drivers/gpu/drm/vc4/Kconfig > @@ -1,6 +1,6 @@ > config DRM_VC4 > tristate "Broadcom VC4 Graphics" > - depends on ARCH_BCM2835 || COMPILE_TEST > + depends on ARCH_BCM || COMPILE_TEST > depends on DRM > depends on SND && SND_SOC > depends on COMMON_CLK >
On 17-05-08 11:30 AM, Florian Fainelli wrote: > On 05/08/2017 11:18 AM, Eric Anholt wrote: >> With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" >> to let the module get built on a cygnus-only kernel. However, I >> anticipate having a port for Kona soon, so just present the module on >> all of BCM. > > This seems reasonable, but by replacing ARCH_BCM2835 which is common to > ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems > to benefit from this driver unless COMPILE_TEST is also selected, right? > > This could be: > > depends on COMPILE_TEST > depends on ARCH_BCM # 32-bit ARM > depends on ARCH_BCM2835 || ARCH_BCM_IPROC # 64-bit ARM There are no 64-bit IPROC variants that use this. > > or maybe down to just: > > depends on COMPILE_TEST > > and let DRM, COMMON_CLK and SND drive the bulk of the dependencies? > >> >> Signed-off-by: Eric Anholt <eric@anholt.net> >> --- >> >> I would be sending this through drm-misc-next, assuming BCM >> maintainers like it. >> >> drivers/gpu/drm/vc4/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig >> index 973b4203c0b2..f136813abf56 100644 >> --- a/drivers/gpu/drm/vc4/Kconfig >> +++ b/drivers/gpu/drm/vc4/Kconfig >> @@ -1,6 +1,6 @@ >> config DRM_VC4 >> tristate "Broadcom VC4 Graphics" >> - depends on ARCH_BCM2835 || COMPILE_TEST >> + depends on ARCH_BCM || COMPILE_TEST >> depends on DRM >> depends on SND && SND_SOC >> depends on COMMON_CLK >> > >
Florian Fainelli <f.fainelli@gmail.com> writes: > On 05/08/2017 11:18 AM, Eric Anholt wrote: >> With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" >> to let the module get built on a cygnus-only kernel. However, I >> anticipate having a port for Kona soon, so just present the module on >> all of BCM. > > This seems reasonable, but by replacing ARCH_BCM2835 which is common to > ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems > to benefit from this driver unless COMPILE_TEST is also selected, right? > > This could be: > > depends on COMPILE_TEST > depends on ARCH_BCM # 32-bit ARM > depends on ARCH_BCM2835 || ARCH_BCM_IPROC # 64-bit ARM > > or maybe down to just: > > depends on COMPILE_TEST > > and let DRM, COMMON_CLK and SND drive the bulk of the dependencies? That would disable it on ARCH_BCM2835 && !COMPILE_TEST, right? COMPILE_TEST is typically disabled. I think I should use ARCH_BCM2835 || ARCH_BCM || COMPILE_TEST. Does that sound good?
diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig index 973b4203c0b2..f136813abf56 100644 --- a/drivers/gpu/drm/vc4/Kconfig +++ b/drivers/gpu/drm/vc4/Kconfig @@ -1,6 +1,6 @@ config DRM_VC4 tristate "Broadcom VC4 Graphics" - depends on ARCH_BCM2835 || COMPILE_TEST + depends on ARCH_BCM || COMPILE_TEST depends on DRM depends on SND && SND_SOC depends on COMMON_CLK
With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM. Signed-off-by: Eric Anholt <eric@anholt.net> --- I would be sending this through drm-misc-next, assuming BCM maintainers like it. drivers/gpu/drm/vc4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)