| Message ID | 1f16ba27-99cd-d16d-f09f-97dcda1bd358@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
HI Arek, On 05/09/2017 04:17 PM, Arek Burdach wrote: > Hi, > > I've tried described by you solution: > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 37084b645785..81f271554b6c 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -2510,6 +2510,7 @@ static const struct hid_device_id > hid_ignore_list[] = { You need to add this to the hid_have_special_driver[] and not the hid_ignore_list[]. But, if you do success in binding hid-rmi to a touchscreen it won't work. The firmware between touchpads and touchscreens are different enough that the hid-rmi driver will be looking for data which does not exist in touchscreen's HID report. These differences also mean that it really isn't a good idea to try to support touchscreens with hid-rmi. It would actually result in more transactions and be less efficient then simply using hid-multitouch. That's why hid-core checks for the HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a touchpad and not a touchscreen. > { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, > USB_DEVICE_ID_SYNAPTICS_WTP) }, > { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, > USB_DEVICE_ID_SYNAPTICS_DPAD) }, > #endif > + { HID_I2C_DEVICE(USB_VENDOR_ID_SYNAPTICS, 0x1786) }, > { HID_USB_DEVICE(USB_VENDOR_ID_YEALINK, > USB_DEVICE_ID_YEALINK_P1K_P4K_B2K) }, > { } > }; > diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c > index 5b40c2614599..ac2ea6ad2e53 100644 > --- a/drivers/hid/hid-rmi.c > +++ b/drivers/hid/hid-rmi.c > @@ -714,6 +714,7 @@ static void rmi_remove(struct hid_device *hdev) > } > > static const struct hid_device_id rmi_id[] = { > + { HID_I2C_DEVICE(USB_VENDOR_ID_SYNAPTICS, 0x1786) }, > { HID_USB_DEVICE(USB_VENDOR_ID_RAZER, > USB_DEVICE_ID_RAZER_BLADE_14), > .driver_data = RMI_DEVICE_HAS_PHYS_BUTTONS }, > { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, > USB_DEVICE_ID_LENOVO_X1_COVER) }, > > > and now neither hid-touchscreen nor hid-rmi peaking up my touchscreen > (also missing hidraw device) > > Any other idea how to force hid-rmi to peak the device? > > Cheers, > Arek > > On 09.05.2017 16:02, Benjamin Tissoires wrote: >> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach <arek.burdach@gmail.com> >> wrote: >>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach <arek.burdach@gmail.com> >>>> wrote: >>>>> Hi, >>>>> >>>>> Thank you for response. >>>>> >>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>> <arek.burdach@gmail.com> >>>>>> wrote: >>>>>>> Hi, >>>>>>> >>>>>>> A week ago I've reported a bug: >>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there anybody >>>>>>> that >>>>>>> can >>>>>>> help me with it? >>>>>> I can have a look at it. >>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>> in the >>>>>> bugs, or it'll be difficult for us to debug it. >>>>> I've attached full logs for two situations. More details in the >>>>> issue. >>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>> Sorry for my noob questions, but do you suggest that it can't be >>> fixed by >>> changes in kernel modules and I need to report it to the manufacturer? >> Yes. Though Andrew, in CC, works for Synaptics and might give us some >> pointers. >> >>> If it so, do you have an idea why it works well on Windows? Do they >>> have >>> some strange hacks in their drivers? >> I have no ideas how well it works under Windows, and I have no ideas >> if there are some strange hacks in the Windows nor in the Syanptics >> driver (I would assume so). >> We don't provide any drivers for touchscreens on Windows. So I don't know how Microsoft is handling a situation like this. Andrew >>> >>> >>>>>>> I found out that some touchpads (and possible touchscreens?) are >>>>>>> handled >>>>>>> by >>>>>>> both hid-multitouch and hid-rmi drivers. Is there a way to >>>>>>> verify how >>>>>>> the >>>>>>> touchscreen would work on hid-rmi drivers? I've tested it with >>>>>>> kernel >>>>>>> 4.11.0-rc1 version where was this change: >>>>>>> 279967a65b320d174a507498aea7d44db3fee7f4 HID: rmi: Handle all >>>>>>> Synaptics >>>>>>> touchpads using hid-rmi >>>>>>> which was reverted in later kernel's version. On this version, >>>>>>> only my >>>>>>> touchpad was handled by hid-rmi, touchscreen was still handled by >>>>>>> hid-multitouch. Maybe I should change something in code or in >>>>>>> compilation >>>>>>> configuration to force hid-rmi? >>>>>> Well, with 279967a65 applied, the system would know if the device >>>>>> can >>>>>> be handled through hid-rmi or not. If hid-multitouch was still used, >>>>>> that means that the device was not designed to be used as a rmi >>>>>> device >>>>>> at all (i.e. hid-rmi will not be able to talk to it). >>>>> In this patch, there is verified if hid group is >>>>> HID_GROUP_MULTITOUCH_WIN_8. >>>>> Maybe this touchscreen is in group with greater priority during >>>>> recognition. >>>>> Can I verify it somehow? >>>> With the logs you gave, the touchscreen is indeed Win 8 certified. >>>> >>>>> Also HID_GROUP_MULTITOUCH_WIN_8 recognition is done by this: >>>>>> usage == 0xff0000c5 && parser->global.report_count == 256 && >>>>>> parser->global.report_size == 8 >>>>> I assume that it is correct way to verify that. I wonder if it is >>>>> possible >>>>> that something changed for a new devices. >>>> Nope, looks good for your device. The reason why hid-rmi is not >>>> picking up your device is because of the check "parser->scan_flags & >>>> HID_SCAN_FLAG_GD_POINTER": this matches only to indirect devices >>>> (touchpads). >>>> >>>> If you can recompile your hid and hid-rmi modules, you can try >>>> giving a >>>> shot at: >>>> - adding HID_I2C_DEVICE(USB_VENDOR_ID_SYNAPTICS, 0x1786) }, in >>>> hid_have_special_driver[] in hid-core.c >>>> - adding a corresponding line in rmi_id[] in file hid-rmi.c. >>>> >>>> This should force the device to bind to hid-rmi and you'll be able to >>>> see if the device works better in this situation or not. >>> Sorry for another noob question, but if I switch to hid-rmi, it should >>> potentially produce other output in both /dev/hidraw output and >>> /dev/input/event output or only in the second one? >> The more, the better. Please provide all logs, hidraw and evemu. >> >>> I'm just wonder what is the pipeline. >>> >>> I'll give a try to it and revert back to you with results. Thank you >>> for >>> tip! >> No worries. >> >> Cheers, >> Benjamin >> >>> >>>> Cheers, >>>> Benjamin >>>> >>>>> Cheers, >>>>> Arek >>>>> >>>>> >>>>>> Cheers, >>>>>> Benjamin >>>>>> >>>>>>> Or it is a wrong way to go? I would be grateful for your help. >>>>>>> >>>>>>> Regards, >>>>>>> Arek >>>>> > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andrew, On 10.05.2017 01:47, Andrew Duggan wrote: > HI Arek, > > On 05/09/2017 04:17 PM, Arek Burdach wrote: >> Hi, >> >> I've tried described by you solution: >> >> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >> index 37084b645785..81f271554b6c 100644 >> --- a/drivers/hid/hid-core.c >> +++ b/drivers/hid/hid-core.c >> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >> hid_ignore_list[] = { > > You need to add this to the hid_have_special_driver[] and not the > hid_ignore_list[]. Nice score for me - two lines and one bug :-) > But, if you do success in binding hid-rmi to a touchscreen it won't > work. The firmware between touchpads and touchscreens are different > enough that the hid-rmi driver will be looking for data which does not > exist in touchscreen's HID report. These differences also mean that it > really isn't a good idea to try to support touchscreens with hid-rmi. > It would actually result in more transactions and be less efficient > then simply using hid-multitouch. That's why hid-core checks for the > HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a > touchpad and not a touchscreen. It was just like you predict. On rmi, after first tap on screen, hidraw produced infinite number of events and it is not usable anymore. >> >> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>> <arek.burdach@gmail.com> wrote: >>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>> <arek.burdach@gmail.com> >>>>> wrote: >>>>>> Hi, >>>>>> >>>>>> Thank you for response. >>>>>> >>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>> <arek.burdach@gmail.com> >>>>>>> wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> A week ago I've reported a bug: >>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>> anybody >>>>>>>> that >>>>>>>> can >>>>>>>> help me with it? >>>>>>> I can have a look at it. >>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>> in the >>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>> I've attached full logs for two situations. More details in the >>>>>> issue. >>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>> Sorry for my noob questions, but do you suggest that it can't be >>>> fixed by >>>> changes in kernel modules and I need to report it to the manufacturer? >>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>> some pointers. >>> >>>> If it so, do you have an idea why it works well on Windows? Do they >>>> have >>>> some strange hacks in their drivers? >>> I have no ideas how well it works under Windows, and I have no ideas >>> if there are some strange hacks in the Windows nor in the Syanptics >>> driver (I would assume so). >>> > > We don't provide any drivers for touchscreens on Windows. So I don't > know how Microsoft is handling a situation like this. Do you know what should be changed in firmware to make hid-touchscreen driver works correctly? Or maybe you know someone who is responsible for firmware for this device and whom I can call to gather this information? Cheers, Arek -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-05-10 11:36, Arek Burdach wrote: > Hi Andrew, > > On 10.05.2017 01:47, Andrew Duggan wrote: >> HI Arek, >> >> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>> Hi, >>> >>> I've tried described by you solution: >>> >>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>> index 37084b645785..81f271554b6c 100644 >>> --- a/drivers/hid/hid-core.c >>> +++ b/drivers/hid/hid-core.c >>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>> hid_ignore_list[] = { >> >> You need to add this to the hid_have_special_driver[] and not the >> hid_ignore_list[]. > Nice score for me - two lines and one bug :-) > >> But, if you do success in binding hid-rmi to a touchscreen it won't >> work. The firmware between touchpads and touchscreens are different >> enough that the hid-rmi driver will be looking for data which does not >> exist in touchscreen's HID report. These differences also mean that it >> really isn't a good idea to try to support touchscreens with hid-rmi. >> It would actually result in more transactions and be less efficient >> then simply using hid-multitouch. That's why hid-core checks for the >> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >> touchpad and not a touchscreen. > It was just like you predict. On rmi, after first tap on screen, hidraw > produced infinite number of events and it is not usable anymore. > > >>> >>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>> <arek.burdach@gmail.com> wrote: >>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>> <arek.burdach@gmail.com> >>>>>> wrote: >>>>>>> Hi, >>>>>>> >>>>>>> Thank you for response. >>>>>>> >>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>> <arek.burdach@gmail.com> >>>>>>>> wrote: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> A week ago I've reported a bug: >>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>> anybody >>>>>>>>> that >>>>>>>>> can >>>>>>>>> help me with it? >>>>>>>> I can have a look at it. >>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>> in the >>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>> I've attached full logs for two situations. More details in the >>>>>>> issue. >>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>> fixed by >>>>> changes in kernel modules and I need to report it to the manufacturer? >>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>> some pointers. >>>> >>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>> have >>>>> some strange hacks in their drivers? >>>> I have no ideas how well it works under Windows, and I have no ideas >>>> if there are some strange hacks in the Windows nor in the Syanptics >>>> driver (I would assume so). >>>> >> >> We don't provide any drivers for touchscreens on Windows. So I don't >> know how Microsoft is handling a situation like this. > Do you know what should be changed in firmware to make hid-touchscreen > driver works correctly? Or maybe you know someone who is responsible for > firmware for this device and whom I can call to gather this information? > In case there *really* is broken firmware out there, we can specifically identify via struct input_id's version number for example, I want to point out that I would accept adding a workaround in tslib's input-raw module ( http://tslib.org ) if it won't be done in the kernel. So, in case you can and want to use tslib as a workaround here, feel free to have a look and send the patches that make input-raw.c work for you over there. Again, only if it won't be done in-kernel. thanks martin
On 11.05.2017 11:48, Martin Kepplinger wrote: > > On 2017-05-10 11:36, Arek Burdach wrote: >> Hi Andrew, >> >> On 10.05.2017 01:47, Andrew Duggan wrote: >>> HI Arek, >>> >>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>> Hi, >>>> >>>> I've tried described by you solution: >>>> >>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>> index 37084b645785..81f271554b6c 100644 >>>> --- a/drivers/hid/hid-core.c >>>> +++ b/drivers/hid/hid-core.c >>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>> hid_ignore_list[] = { >>> You need to add this to the hid_have_special_driver[] and not the >>> hid_ignore_list[]. >> Nice score for me - two lines and one bug :-) >> >>> But, if you do success in binding hid-rmi to a touchscreen it won't >>> work. The firmware between touchpads and touchscreens are different >>> enough that the hid-rmi driver will be looking for data which does not >>> exist in touchscreen's HID report. These differences also mean that it >>> really isn't a good idea to try to support touchscreens with hid-rmi. >>> It would actually result in more transactions and be less efficient >>> then simply using hid-multitouch. That's why hid-core checks for the >>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>> touchpad and not a touchscreen. >> It was just like you predict. On rmi, after first tap on screen, hidraw >> produced infinite number of events and it is not usable anymore. >> >> >>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>> <arek.burdach@gmail.com> wrote: >>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>> <arek.burdach@gmail.com> >>>>>>> wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> Thank you for response. >>>>>>>> >>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>> wrote: >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>> anybody >>>>>>>>>> that >>>>>>>>>> can >>>>>>>>>> help me with it? >>>>>>>>> I can have a look at it. >>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>> in the >>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>> issue. >>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>> fixed by >>>>>> changes in kernel modules and I need to report it to the manufacturer? >>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>> some pointers. >>>>> >>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>> have >>>>>> some strange hacks in their drivers? >>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>> driver (I would assume so). >>>>> >>> We don't provide any drivers for touchscreens on Windows. So I don't >>> know how Microsoft is handling a situation like this. >> Do you know what should be changed in firmware to make hid-touchscreen >> driver works correctly? Or maybe you know someone who is responsible for >> firmware for this device and whom I can call to gather this information? >> > In case there *really* is broken firmware out there, we can specifically > identify via struct input_id's version number for example, I thought that Benjamin identified this as a broken firmware. I've attached hidraw log in the issue and there is no release event, so it looks like a firmware bug. How do you suggest to handle this situation in kernel? We can identify the device but what to do next if we have no information if user released finger or not? > I want to > point out that I would accept adding a workaround in tslib's input-raw > module ( http://tslib.org ) if it won't be done in the kernel. > > So, in case you can and want to use tslib as a workaround here, feel > free to have a look and send the patches that make input-raw.c work for > you over there. I want to be as handy as I can but I'm not sure how tslib could help in this situation. If we have too much data, it can filter out unnecessary events but I don't think that it can help when there is lack of events or I'm missing something? > Again, only if it won't be done in-kernel. > > thanks > martin > > > ________________________________ > > Ginzinger electronic systems GmbH > Gewerbegebiet Pirath 16 > 4952 Weng im Innkreis > www.ginzinger.com > > Firmenbuchnummer: FN 364958d > Firmenbuchgericht: Ried im Innkreis > UID-Nr.: ATU66521089 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-05-11 12:12, Arek Burdach wrote: > > > On 11.05.2017 11:48, Martin Kepplinger wrote: >> >> On 2017-05-10 11:36, Arek Burdach wrote: >>> Hi Andrew, >>> >>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>> HI Arek, >>>> >>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>> Hi, >>>>> >>>>> I've tried described by you solution: >>>>> >>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>> index 37084b645785..81f271554b6c 100644 >>>>> --- a/drivers/hid/hid-core.c >>>>> +++ b/drivers/hid/hid-core.c >>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>> hid_ignore_list[] = { >>>> You need to add this to the hid_have_special_driver[] and not the >>>> hid_ignore_list[]. >>> Nice score for me - two lines and one bug :-) >>> >>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>> work. The firmware between touchpads and touchscreens are different >>>> enough that the hid-rmi driver will be looking for data which does not >>>> exist in touchscreen's HID report. These differences also mean that it >>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>> It would actually result in more transactions and be less efficient >>>> then simply using hid-multitouch. That's why hid-core checks for the >>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>> touchpad and not a touchscreen. >>> It was just like you predict. On rmi, after first tap on screen, hidraw >>> produced infinite number of events and it is not usable anymore. >>> >>> >>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>> <arek.burdach@gmail.com> wrote: >>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>> <arek.burdach@gmail.com> >>>>>>>> wrote: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Thank you for response. >>>>>>>>> >>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>> anybody >>>>>>>>>>> that >>>>>>>>>>> can >>>>>>>>>>> help me with it? >>>>>>>>>> I can have a look at it. >>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>> in the >>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>> issue. >>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>> fixed by >>>>>>> changes in kernel modules and I need to report it to the >>>>>>> manufacturer? >>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>> some pointers. >>>>>> >>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>> have >>>>>>> some strange hacks in their drivers? >>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>> driver (I would assume so). >>>>>> >>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>> know how Microsoft is handling a situation like this. >>> Do you know what should be changed in firmware to make hid-touchscreen >>> driver works correctly? Or maybe you know someone who is responsible for >>> firmware for this device and whom I can call to gather this information? >>> >> In case there *really* is broken firmware out there, we can specifically >> identify via struct input_id's version number for example, > I thought that Benjamin identified this as a broken firmware. I've > attached hidraw log in the issue and there is no release event, so it > looks like a firmware bug. How do you suggest to handle this situation > in kernel? We can identify the device but what to do next if we have no > information if user released finger or not? > >> I want to >> point out that I would accept adding a workaround in tslib's input-raw >> module ( http://tslib.org ) if it won't be done in the kernel. >> >> So, in case you can and want to use tslib as a workaround here, feel >> free to have a look and send the patches that make input-raw.c work for >> you over there. > I want to be as handy as I can but I'm not sure how tslib could help in > this situation. If we have too much data, it can filter out unnecessary > events but I don't think that it can help when there is lack of events > or I'm missing something? Might as well be, I might not have thought it all through, but in tslib's module_raw input you can can get totally creative: Why not start *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You *are* able to add stuff. Filters don't usually do it though. martin
On Thu, May 11, 2017 at 1:22 PM, Martin Kepplinger <martin.kepplinger@ginzinger.com> wrote: > > > On 2017-05-11 12:12, Arek Burdach wrote: >> >> >> On 11.05.2017 11:48, Martin Kepplinger wrote: >>> >>> On 2017-05-10 11:36, Arek Burdach wrote: >>>> Hi Andrew, >>>> >>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>> HI Arek, >>>>> >>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>> Hi, >>>>>> >>>>>> I've tried described by you solution: >>>>>> >>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>> index 37084b645785..81f271554b6c 100644 >>>>>> --- a/drivers/hid/hid-core.c >>>>>> +++ b/drivers/hid/hid-core.c >>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>> hid_ignore_list[] = { >>>>> You need to add this to the hid_have_special_driver[] and not the >>>>> hid_ignore_list[]. >>>> Nice score for me - two lines and one bug :-) >>>> >>>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>>> work. The firmware between touchpads and touchscreens are different >>>>> enough that the hid-rmi driver will be looking for data which does not >>>>> exist in touchscreen's HID report. These differences also mean that it >>>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>>> It would actually result in more transactions and be less efficient >>>>> then simply using hid-multitouch. That's why hid-core checks for the >>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>>> touchpad and not a touchscreen. >>>> It was just like you predict. On rmi, after first tap on screen, hidraw >>>> produced infinite number of events and it is not usable anymore. >>>> >>>> >>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>> wrote: >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Thank you for response. >>>>>>>>>> >>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>> anybody >>>>>>>>>>>> that >>>>>>>>>>>> can >>>>>>>>>>>> help me with it? >>>>>>>>>>> I can have a look at it. >>>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>>> in the >>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>>> issue. >>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>>> fixed by >>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>> manufacturer? >>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>> some pointers. >>>>>>> >>>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>>> have >>>>>>>> some strange hacks in their drivers? >>>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>>> driver (I would assume so). >>>>>>> >>>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>>> know how Microsoft is handling a situation like this. >>>> Do you know what should be changed in firmware to make hid-touchscreen >>>> driver works correctly? Or maybe you know someone who is responsible for >>>> firmware for this device and whom I can call to gather this information? >>>> >>> In case there *really* is broken firmware out there, we can specifically >>> identify via struct input_id's version number for example, >> I thought that Benjamin identified this as a broken firmware. I've >> attached hidraw log in the issue and there is no release event, so it >> looks like a firmware bug. How do you suggest to handle this situation >> in kernel? We can identify the device but what to do next if we have no >> information if user released finger or not? >> >>> I want to >>> point out that I would accept adding a workaround in tslib's input-raw >>> module ( http://tslib.org ) if it won't be done in the kernel. >>> >>> So, in case you can and want to use tslib as a workaround here, feel >>> free to have a look and send the patches that make input-raw.c work for >>> you over there. >> I want to be as handy as I can but I'm not sure how tslib could help in >> this situation. If we have too much data, it can filter out unnecessary >> events but I don't think that it can help when there is lack of events >> or I'm missing something? > > Might as well be, I might not have thought it all through, but in > tslib's module_raw input you can can get totally creative: Why not start > *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You > *are* able to add stuff. Filters don't usually do it though. Ouch, please don't. You'll send an endless click/release sequence which will break drag and drop, double click and so on. Also, this won't solve the issue because the multitouch slot will not be released. The only solution (which i believe the Windows driver does, but I believed only for Windows 7 compatible touchscreen), is to arm a timer for each slot, and when you don't receive an update after let's say 5 seconds, you release the slot. It's awful and I always have been against adding such pain in the hid-multitouch driver. Cheers, Benjamin > > martin > > > ________________________________ > > Ginzinger electronic systems GmbH > Gewerbegebiet Pirath 16 > 4952 Weng im Innkreis > www.ginzinger.com > > Firmenbuchnummer: FN 364958d > Firmenbuchgericht: Ried im Innkreis > UID-Nr.: ATU66521089 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11.05.2017 13:22, Martin Kepplinger wrote: > > On 2017-05-11 12:12, Arek Burdach wrote: >> >> On 11.05.2017 11:48, Martin Kepplinger wrote: >>> On 2017-05-10 11:36, Arek Burdach wrote: >>>> Hi Andrew, >>>> >>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>> HI Arek, >>>>> >>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>> Hi, >>>>>> >>>>>> I've tried described by you solution: >>>>>> >>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>> index 37084b645785..81f271554b6c 100644 >>>>>> --- a/drivers/hid/hid-core.c >>>>>> +++ b/drivers/hid/hid-core.c >>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>> hid_ignore_list[] = { >>>>> You need to add this to the hid_have_special_driver[] and not the >>>>> hid_ignore_list[]. >>>> Nice score for me - two lines and one bug :-) >>>> >>>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>>> work. The firmware between touchpads and touchscreens are different >>>>> enough that the hid-rmi driver will be looking for data which does not >>>>> exist in touchscreen's HID report. These differences also mean that it >>>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>>> It would actually result in more transactions and be less efficient >>>>> then simply using hid-multitouch. That's why hid-core checks for the >>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>>> touchpad and not a touchscreen. >>>> It was just like you predict. On rmi, after first tap on screen, hidraw >>>> produced infinite number of events and it is not usable anymore. >>>> >>>> >>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>> wrote: >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Thank you for response. >>>>>>>>>> >>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>> anybody >>>>>>>>>>>> that >>>>>>>>>>>> can >>>>>>>>>>>> help me with it? >>>>>>>>>>> I can have a look at it. >>>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>>> in the >>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>>> issue. >>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>>> fixed by >>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>> manufacturer? >>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>> some pointers. >>>>>>> >>>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>>> have >>>>>>>> some strange hacks in their drivers? >>>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>>> driver (I would assume so). >>>>>>> >>>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>>> know how Microsoft is handling a situation like this. >>>> Do you know what should be changed in firmware to make hid-touchscreen >>>> driver works correctly? Or maybe you know someone who is responsible for >>>> firmware for this device and whom I can call to gather this information? >>>> >>> In case there *really* is broken firmware out there, we can specifically >>> identify via struct input_id's version number for example, >> I thought that Benjamin identified this as a broken firmware. I've >> attached hidraw log in the issue and there is no release event, so it >> looks like a firmware bug. How do you suggest to handle this situation >> in kernel? We can identify the device but what to do next if we have no >> information if user released finger or not? >> >>> I want to >>> point out that I would accept adding a workaround in tslib's input-raw >>> module ( http://tslib.org ) if it won't be done in the kernel. >>> >>> So, in case you can and want to use tslib as a workaround here, feel >>> free to have a look and send the patches that make input-raw.c work for >>> you over there. >> I want to be as handy as I can but I'm not sure how tslib could help in >> this situation. If we have too much data, it can filter out unnecessary >> events but I don't think that it can help when there is lack of events >> or I'm missing something? > Might as well be, I might not have thought it all through, but in > tslib's module_raw input you can can get totally creative: Why not start > *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You > *are* able to add stuff. Filters don't usually do it though. If I end every BTN_TOUCH 1 with BTN_TOUCH 0 after a while, we won't be able to do real drags. Of course we can introduce timeout for cursor move events, but this timeout would be extremely long because users quite often put finger on touchscreen and after a longer delay start dragging. I'm not sure that this workaround would be better than current situation. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-05-11 13:22, Martin Kepplinger wrote: > > > On 2017-05-11 12:12, Arek Burdach wrote: >> >> >> On 11.05.2017 11:48, Martin Kepplinger wrote: >>> >>> On 2017-05-10 11:36, Arek Burdach wrote: >>>> Hi Andrew, >>>> >>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>> HI Arek, >>>>> >>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>> Hi, >>>>>> >>>>>> I've tried described by you solution: >>>>>> >>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>> index 37084b645785..81f271554b6c 100644 >>>>>> --- a/drivers/hid/hid-core.c >>>>>> +++ b/drivers/hid/hid-core.c >>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>> hid_ignore_list[] = { >>>>> You need to add this to the hid_have_special_driver[] and not the >>>>> hid_ignore_list[]. >>>> Nice score for me - two lines and one bug :-) >>>> >>>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>>> work. The firmware between touchpads and touchscreens are different >>>>> enough that the hid-rmi driver will be looking for data which does not >>>>> exist in touchscreen's HID report. These differences also mean that it >>>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>>> It would actually result in more transactions and be less efficient >>>>> then simply using hid-multitouch. That's why hid-core checks for the >>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>>> touchpad and not a touchscreen. >>>> It was just like you predict. On rmi, after first tap on screen, hidraw >>>> produced infinite number of events and it is not usable anymore. >>>> >>>> >>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>> wrote: >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Thank you for response. >>>>>>>>>> >>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>> anybody >>>>>>>>>>>> that >>>>>>>>>>>> can >>>>>>>>>>>> help me with it? >>>>>>>>>>> I can have a look at it. >>>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>>> in the >>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>>> issue. >>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>>> fixed by >>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>> manufacturer? >>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>> some pointers. >>>>>>> >>>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>>> have >>>>>>>> some strange hacks in their drivers? >>>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>>> driver (I would assume so). >>>>>>> >>>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>>> know how Microsoft is handling a situation like this. >>>> Do you know what should be changed in firmware to make hid-touchscreen >>>> driver works correctly? Or maybe you know someone who is responsible for >>>> firmware for this device and whom I can call to gather this information? >>>> >>> In case there *really* is broken firmware out there, we can specifically >>> identify via struct input_id's version number for example, >> I thought that Benjamin identified this as a broken firmware. I've >> attached hidraw log in the issue and there is no release event, so it >> looks like a firmware bug. How do you suggest to handle this situation >> in kernel? We can identify the device but what to do next if we have no >> information if user released finger or not? >> >>> I want to >>> point out that I would accept adding a workaround in tslib's input-raw >>> module ( http://tslib.org ) if it won't be done in the kernel. >>> >>> So, in case you can and want to use tslib as a workaround here, feel >>> free to have a look and send the patches that make input-raw.c work for >>> you over there. >> I want to be as handy as I can but I'm not sure how tslib could help in >> this situation. If we have too much data, it can filter out unnecessary >> events but I don't think that it can help when there is lack of events >> or I'm missing something? > > Might as well be, I might not have thought it all through, but in > tslib's module_raw input you can can get totally creative: Why not start > *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? I definitely haven't thought it through :) One would have to say it diffently, and probably work on it properly: for each sync frame, assume you got "pen_down" first, for this device. take that sample (ts_sample or ts_sample_mt) and add a 2nd sample containing only pen_up. You are in tslib API world then, and should check the documentation on how to use it. but don't sue me if I'm just misleading you :) martin
On 11.05.2017 13:28, Benjamin Tissoires wrote: > On Thu, May 11, 2017 at 1:22 PM, Martin Kepplinger > <martin.kepplinger@ginzinger.com> wrote: >> >> On 2017-05-11 12:12, Arek Burdach wrote: >>> >>> On 11.05.2017 11:48, Martin Kepplinger wrote: >>>> On 2017-05-10 11:36, Arek Burdach wrote: >>>>> Hi Andrew, >>>>> >>>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>>> HI Arek, >>>>>> >>>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>>> Hi, >>>>>>> >>>>>>> I've tried described by you solution: >>>>>>> >>>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>>> index 37084b645785..81f271554b6c 100644 >>>>>>> --- a/drivers/hid/hid-core.c >>>>>>> +++ b/drivers/hid/hid-core.c >>>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>>> hid_ignore_list[] = { >>>>>> You need to add this to the hid_have_special_driver[] and not the >>>>>> hid_ignore_list[]. >>>>> Nice score for me - two lines and one bug :-) >>>>> >>>>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>>>> work. The firmware between touchpads and touchscreens are different >>>>>> enough that the hid-rmi driver will be looking for data which does not >>>>>> exist in touchscreen's HID report. These differences also mean that it >>>>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>>>> It would actually result in more transactions and be less efficient >>>>>> then simply using hid-multitouch. That's why hid-core checks for the >>>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>>>> touchpad and not a touchscreen. >>>>> It was just like you predict. On rmi, after first tap on screen, hidraw >>>>> produced infinite number of events and it is not usable anymore. >>>>> >>>>> >>>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> Thank you for response. >>>>>>>>>>> >>>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>>> anybody >>>>>>>>>>>>> that >>>>>>>>>>>>> can >>>>>>>>>>>>> help me with it? >>>>>>>>>>>> I can have a look at it. >>>>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>>>> in the >>>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>>>> issue. >>>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>>>> fixed by >>>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>>> manufacturer? >>>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>>> some pointers. >>>>>>>> >>>>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>>>> have >>>>>>>>> some strange hacks in their drivers? >>>>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>>>> driver (I would assume so). >>>>>>>> >>>>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>>>> know how Microsoft is handling a situation like this. >>>>> Do you know what should be changed in firmware to make hid-touchscreen >>>>> driver works correctly? Or maybe you know someone who is responsible for >>>>> firmware for this device and whom I can call to gather this information? >>>>> >>>> In case there *really* is broken firmware out there, we can specifically >>>> identify via struct input_id's version number for example, >>> I thought that Benjamin identified this as a broken firmware. I've >>> attached hidraw log in the issue and there is no release event, so it >>> looks like a firmware bug. How do you suggest to handle this situation >>> in kernel? We can identify the device but what to do next if we have no >>> information if user released finger or not? >>> >>>> I want to >>>> point out that I would accept adding a workaround in tslib's input-raw >>>> module ( http://tslib.org ) if it won't be done in the kernel. >>>> >>>> So, in case you can and want to use tslib as a workaround here, feel >>>> free to have a look and send the patches that make input-raw.c work for >>>> you over there. >>> I want to be as handy as I can but I'm not sure how tslib could help in >>> this situation. If we have too much data, it can filter out unnecessary >>> events but I don't think that it can help when there is lack of events >>> or I'm missing something? >> Might as well be, I might not have thought it all through, but in >> tslib's module_raw input you can can get totally creative: Why not start >> *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You >> *are* able to add stuff. Filters don't usually do it though. > Ouch, please don't. You'll send an endless click/release sequence > which will break drag and drop, double click and so on. > > Also, this won't solve the issue because the multitouch slot will not > be released. > > The only solution (which i believe the Windows driver does, but I > believed only for Windows 7 compatible touchscreen), is to arm a timer > for each slot, and when you don't receive an update after let's say 5 > seconds, you release the slot. I also thought that it works like you describe on Windows, but I've verified that on Windows you can observe when release appear. There is an animation for it. This animation is played just after real release happens - not after constant timeout. > > It's awful and I always have been against adding such pain in the > hid-multitouch driver. > > Cheers, > Benjamin > >> martin >> >> >> ________________________________ >> >> Ginzinger electronic systems GmbH >> Gewerbegebiet Pirath 16 >> 4952 Weng im Innkreis >> www.ginzinger.com >> >> Firmenbuchnummer: FN 364958d >> Firmenbuchgericht: Ried im Innkreis >> UID-Nr.: ATU66521089 >> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-05-11 13:28, Benjamin Tissoires wrote: > On Thu, May 11, 2017 at 1:22 PM, Martin Kepplinger > <martin.kepplinger@ginzinger.com> wrote: >> >> >> On 2017-05-11 12:12, Arek Burdach wrote: >>> >>> >>> On 11.05.2017 11:48, Martin Kepplinger wrote: >>>> >>>> On 2017-05-10 11:36, Arek Burdach wrote: >>>>> Hi Andrew, >>>>> >>>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>>> HI Arek, >>>>>> >>>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>>> Hi, >>>>>>> >>>>>>> I've tried described by you solution: >>>>>>> >>>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>>> index 37084b645785..81f271554b6c 100644 >>>>>>> --- a/drivers/hid/hid-core.c >>>>>>> +++ b/drivers/hid/hid-core.c >>>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>>> hid_ignore_list[] = { >>>>>> You need to add this to the hid_have_special_driver[] and not the >>>>>> hid_ignore_list[]. >>>>> Nice score for me - two lines and one bug :-) >>>>> >>>>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>>>> work. The firmware between touchpads and touchscreens are different >>>>>> enough that the hid-rmi driver will be looking for data which does not >>>>>> exist in touchscreen's HID report. These differences also mean that it >>>>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>>>> It would actually result in more transactions and be less efficient >>>>>> then simply using hid-multitouch. That's why hid-core checks for the >>>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>>>> touchpad and not a touchscreen. >>>>> It was just like you predict. On rmi, after first tap on screen, hidraw >>>>> produced infinite number of events and it is not usable anymore. >>>>> >>>>> >>>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> Thank you for response. >>>>>>>>>>> >>>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>>> anybody >>>>>>>>>>>>> that >>>>>>>>>>>>> can >>>>>>>>>>>>> help me with it? >>>>>>>>>>>> I can have a look at it. >>>>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>>>> in the >>>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>>>> issue. >>>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>>>> fixed by >>>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>>> manufacturer? >>>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>>> some pointers. >>>>>>>> >>>>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>>>> have >>>>>>>>> some strange hacks in their drivers? >>>>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>>>> driver (I would assume so). >>>>>>>> >>>>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>>>> know how Microsoft is handling a situation like this. >>>>> Do you know what should be changed in firmware to make hid-touchscreen >>>>> driver works correctly? Or maybe you know someone who is responsible for >>>>> firmware for this device and whom I can call to gather this information? >>>>> >>>> In case there *really* is broken firmware out there, we can specifically >>>> identify via struct input_id's version number for example, >>> I thought that Benjamin identified this as a broken firmware. I've >>> attached hidraw log in the issue and there is no release event, so it >>> looks like a firmware bug. How do you suggest to handle this situation >>> in kernel? We can identify the device but what to do next if we have no >>> information if user released finger or not? >>> >>>> I want to >>>> point out that I would accept adding a workaround in tslib's input-raw >>>> module ( http://tslib.org ) if it won't be done in the kernel. >>>> >>>> So, in case you can and want to use tslib as a workaround here, feel >>>> free to have a look and send the patches that make input-raw.c work for >>>> you over there. >>> I want to be as handy as I can but I'm not sure how tslib could help in >>> this situation. If we have too much data, it can filter out unnecessary >>> events but I don't think that it can help when there is lack of events >>> or I'm missing something? >> >> Might as well be, I might not have thought it all through, but in >> tslib's module_raw input you can can get totally creative: Why not start >> *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You >> *are* able to add stuff. Filters don't usually do it though. > > Ouch, please don't. You'll send an endless click/release sequence > which will break drag and drop, double click and so on. > ah you're right, that's nonsense. > Also, this won't solve the issue because the multitouch slot will not > be released. > > The only solution (which i believe the Windows driver does, but I > believed only for Windows 7 compatible touchscreen), is to arm a timer > for each slot, and when you don't receive an update after let's say 5 > seconds, you release the slot. > > It's awful and I always have been against adding such pain in the > hid-multitouch driver. yes. still breaks "move after hold>5s" but would probably be the only way to make this somewhat work.
On Thu, May 11, 2017 at 1:47 PM, Martin Kepplinger <martin.kepplinger@ginzinger.com> wrote: > > > On 2017-05-11 13:28, Benjamin Tissoires wrote: >> On Thu, May 11, 2017 at 1:22 PM, Martin Kepplinger >> <martin.kepplinger@ginzinger.com> wrote: >>> >>> >>> On 2017-05-11 12:12, Arek Burdach wrote: >>>> >>>> >>>> On 11.05.2017 11:48, Martin Kepplinger wrote: >>>>> >>>>> On 2017-05-10 11:36, Arek Burdach wrote: >>>>>> Hi Andrew, >>>>>> >>>>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>>>> HI Arek, >>>>>>> >>>>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> I've tried described by you solution: >>>>>>>> >>>>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>>>> index 37084b645785..81f271554b6c 100644 >>>>>>>> --- a/drivers/hid/hid-core.c >>>>>>>> +++ b/drivers/hid/hid-core.c >>>>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>>>> hid_ignore_list[] = { >>>>>>> You need to add this to the hid_have_special_driver[] and not the >>>>>>> hid_ignore_list[]. >>>>>> Nice score for me - two lines and one bug :-) >>>>>> >>>>>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>>>>> work. The firmware between touchpads and touchscreens are different >>>>>>> enough that the hid-rmi driver will be looking for data which does not >>>>>>> exist in touchscreen's HID report. These differences also mean that it >>>>>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>>>>> It would actually result in more transactions and be less efficient >>>>>>> then simply using hid-multitouch. That's why hid-core checks for the >>>>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>>>>> touchpad and not a touchscreen. >>>>>> It was just like you predict. On rmi, after first tap on screen, hidraw >>>>>> produced infinite number of events and it is not usable anymore. >>>>>> >>>>>> >>>>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> Thank you for response. >>>>>>>>>>>> >>>>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>> >>>>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>>>> anybody >>>>>>>>>>>>>> that >>>>>>>>>>>>>> can >>>>>>>>>>>>>> help me with it? >>>>>>>>>>>>> I can have a look at it. >>>>>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>>>>> in the >>>>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>>>>> issue. >>>>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>>>>> fixed by >>>>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>>>> manufacturer? >>>>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>>>> some pointers. >>>>>>>>> >>>>>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>>>>> have >>>>>>>>>> some strange hacks in their drivers? >>>>>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>>>>> driver (I would assume so). >>>>>>>>> >>>>>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>>>>> know how Microsoft is handling a situation like this. >>>>>> Do you know what should be changed in firmware to make hid-touchscreen >>>>>> driver works correctly? Or maybe you know someone who is responsible for >>>>>> firmware for this device and whom I can call to gather this information? >>>>>> >>>>> In case there *really* is broken firmware out there, we can specifically >>>>> identify via struct input_id's version number for example, >>>> I thought that Benjamin identified this as a broken firmware. I've >>>> attached hidraw log in the issue and there is no release event, so it >>>> looks like a firmware bug. How do you suggest to handle this situation >>>> in kernel? We can identify the device but what to do next if we have no >>>> information if user released finger or not? >>>> >>>>> I want to >>>>> point out that I would accept adding a workaround in tslib's input-raw >>>>> module ( http://tslib.org ) if it won't be done in the kernel. >>>>> >>>>> So, in case you can and want to use tslib as a workaround here, feel >>>>> free to have a look and send the patches that make input-raw.c work for >>>>> you over there. >>>> I want to be as handy as I can but I'm not sure how tslib could help in >>>> this situation. If we have too much data, it can filter out unnecessary >>>> events but I don't think that it can help when there is lack of events >>>> or I'm missing something? >>> >>> Might as well be, I might not have thought it all through, but in >>> tslib's module_raw input you can can get totally creative: Why not start >>> *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You >>> *are* able to add stuff. Filters don't usually do it though. >> >> Ouch, please don't. You'll send an endless click/release sequence >> which will break drag and drop, double click and so on. >> > > ah you're right, that's nonsense. > >> Also, this won't solve the issue because the multitouch slot will not >> be released. >> >> The only solution (which i believe the Windows driver does, but I >> believed only for Windows 7 compatible touchscreen), is to arm a timer >> for each slot, and when you don't receive an update after let's say 5 >> seconds, you release the slot. >> >> It's awful and I always have been against adding such pain in the >> hid-multitouch driver. > > yes. still breaks "move after hold>5s" but would probably be the only > way to make this somewhat work. No, you won't have "move after hold>5s" broken. Because at the HID level, the device is supposed to send an update on every touch when reporting a touch (for Windows 8 devices). So if there are tiny movements filtered at the input level in the kernel, we will get those and I suspect the timeout will only appear when the finger actual leaves the surface. Cheers, Benjamin > > ________________________________ > > Ginzinger electronic systems GmbH > Gewerbegebiet Pirath 16 > 4952 Weng im Innkreis > www.ginzinger.com > > Firmenbuchnummer: FN 364958d > Firmenbuchgericht: Ried im Innkreis > UID-Nr.: ATU66521089 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-05-11 14:28, Benjamin Tissoires wrote: > On Thu, May 11, 2017 at 1:47 PM, Martin Kepplinger > <martin.kepplinger@ginzinger.com> wrote: >> >> >> On 2017-05-11 13:28, Benjamin Tissoires wrote: >>> On Thu, May 11, 2017 at 1:22 PM, Martin Kepplinger >>> <martin.kepplinger@ginzinger.com> wrote: >>>> >>>> >>>> On 2017-05-11 12:12, Arek Burdach wrote: >>>>> >>>>> >>>>> On 11.05.2017 11:48, Martin Kepplinger wrote: >>>>>> >>>>>> On 2017-05-10 11:36, Arek Burdach wrote: >>>>>>> Hi Andrew, >>>>>>> >>>>>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>>>>> HI Arek, >>>>>>>> >>>>>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> I've tried described by you solution: >>>>>>>>> >>>>>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>>>>> index 37084b645785..81f271554b6c 100644 >>>>>>>>> --- a/drivers/hid/hid-core.c >>>>>>>>> +++ b/drivers/hid/hid-core.c >>>>>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>>>>> hid_ignore_list[] = { >>>>>>>> You need to add this to the hid_have_special_driver[] and not the >>>>>>>> hid_ignore_list[]. >>>>>>> Nice score for me - two lines and one bug :-) >>>>>>> >>>>>>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>>>>>> work. The firmware between touchpads and touchscreens are different >>>>>>>> enough that the hid-rmi driver will be looking for data which does not >>>>>>>> exist in touchscreen's HID report. These differences also mean that it >>>>>>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>>>>>> It would actually result in more transactions and be less efficient >>>>>>>> then simply using hid-multitouch. That's why hid-core checks for the >>>>>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>>>>>> touchpad and not a touchscreen. >>>>>>> It was just like you predict. On rmi, after first tap on screen, hidraw >>>>>>> produced infinite number of events and it is not usable anymore. >>>>>>> >>>>>>> >>>>>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> Thank you for response. >>>>>>>>>>>>> >>>>>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>>>>> anybody >>>>>>>>>>>>>>> that >>>>>>>>>>>>>>> can >>>>>>>>>>>>>>> help me with it? >>>>>>>>>>>>>> I can have a look at it. >>>>>>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>>>>>> in the >>>>>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>>>>>> issue. >>>>>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>>>>>> fixed by >>>>>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>>>>> manufacturer? >>>>>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>>>>> some pointers. >>>>>>>>>> >>>>>>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>>>>>> have >>>>>>>>>>> some strange hacks in their drivers? >>>>>>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>>>>>> driver (I would assume so). >>>>>>>>>> >>>>>>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>>>>>> know how Microsoft is handling a situation like this. >>>>>>> Do you know what should be changed in firmware to make hid-touchscreen >>>>>>> driver works correctly? Or maybe you know someone who is responsible for >>>>>>> firmware for this device and whom I can call to gather this information? >>>>>>> >>>>>> In case there *really* is broken firmware out there, we can specifically >>>>>> identify via struct input_id's version number for example, >>>>> I thought that Benjamin identified this as a broken firmware. I've >>>>> attached hidraw log in the issue and there is no release event, so it >>>>> looks like a firmware bug. How do you suggest to handle this situation >>>>> in kernel? We can identify the device but what to do next if we have no >>>>> information if user released finger or not? >>>>> >>>>>> I want to >>>>>> point out that I would accept adding a workaround in tslib's input-raw >>>>>> module ( http://tslib.org ) if it won't be done in the kernel. >>>>>> >>>>>> So, in case you can and want to use tslib as a workaround here, feel >>>>>> free to have a look and send the patches that make input-raw.c work for >>>>>> you over there. >>>>> I want to be as handy as I can but I'm not sure how tslib could help in >>>>> this situation. If we have too much data, it can filter out unnecessary >>>>> events but I don't think that it can help when there is lack of events >>>>> or I'm missing something? >>>> >>>> Might as well be, I might not have thought it all through, but in >>>> tslib's module_raw input you can can get totally creative: Why not start >>>> *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You >>>> *are* able to add stuff. Filters don't usually do it though. >>> >>> Ouch, please don't. You'll send an endless click/release sequence >>> which will break drag and drop, double click and so on. >>> >> >> ah you're right, that's nonsense. >> >>> Also, this won't solve the issue because the multitouch slot will not >>> be released. >>> >>> The only solution (which i believe the Windows driver does, but I >>> believed only for Windows 7 compatible touchscreen), is to arm a timer >>> for each slot, and when you don't receive an update after let's say 5 >>> seconds, you release the slot. >>> >>> It's awful and I always have been against adding such pain in the >>> hid-multitouch driver. >> >> yes. still breaks "move after hold>5s" but would probably be the only >> way to make this somewhat work. > > No, you won't have "move after hold>5s" broken. Because at the HID > level, the device is supposed to send an update on every touch when > reporting a touch (for Windows 8 devices). So if there are tiny > movements filtered at the input level in the kernel, we will get those > and I suspect the timeout will only appear when the finger actual > leaves the surface. ok. sounds a little more like a solution in the kernel would be justified. Isn't it? It still feels dangerously ugly. Mainly I wanted to point out that if you somehow have to stay with "no" for such broken devices, tslib would be a garbage can for userspace workarounds. (in this case, most probably a new device-specific hidraw based module). martin
On 11.05.2017 14:50, Martin Kepplinger wrote: > > On 2017-05-11 14:28, Benjamin Tissoires wrote: >> On Thu, May 11, 2017 at 1:47 PM, Martin Kepplinger >> <martin.kepplinger@ginzinger.com> wrote: >>> >>> On 2017-05-11 13:28, Benjamin Tissoires wrote: >>>> On Thu, May 11, 2017 at 1:22 PM, Martin Kepplinger >>>> <martin.kepplinger@ginzinger.com> wrote: >>>>> >>>>> On 2017-05-11 12:12, Arek Burdach wrote: >>>>>> >>>>>> On 11.05.2017 11:48, Martin Kepplinger wrote: >>>>>>> On 2017-05-10 11:36, Arek Burdach wrote: >>>>>>>> Hi Andrew, >>>>>>>> >>>>>>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>>>>>> HI Arek, >>>>>>>>> >>>>>>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> I've tried described by you solution: >>>>>>>>>> >>>>>>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>>>>>> index 37084b645785..81f271554b6c 100644 >>>>>>>>>> --- a/drivers/hid/hid-core.c >>>>>>>>>> +++ b/drivers/hid/hid-core.c >>>>>>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>>>>>> hid_ignore_list[] = { >>>>>>>>> You need to add this to the hid_have_special_driver[] and not the >>>>>>>>> hid_ignore_list[]. >>>>>>>> Nice score for me - two lines and one bug :-) >>>>>>>> >>>>>>>>> But, if you do success in binding hid-rmi to a touchscreen it won't >>>>>>>>> work. The firmware between touchpads and touchscreens are different >>>>>>>>> enough that the hid-rmi driver will be looking for data which does not >>>>>>>>> exist in touchscreen's HID report. These differences also mean that it >>>>>>>>> really isn't a good idea to try to support touchscreens with hid-rmi. >>>>>>>>> It would actually result in more transactions and be less efficient >>>>>>>>> then simply using hid-multitouch. That's why hid-core checks for the >>>>>>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a >>>>>>>>> touchpad and not a touchscreen. >>>>>>>> It was just like you predict. On rmi, after first tap on screen, hidraw >>>>>>>> produced infinite number of events and it is not usable anymore. >>>>>>>> >>>>>>>> >>>>>>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thank you for response. >>>>>>>>>>>>>> >>>>>>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>>>>>> anybody >>>>>>>>>>>>>>>> that >>>>>>>>>>>>>>>> can >>>>>>>>>>>>>>>> help me with it? >>>>>>>>>>>>>>> I can have a look at it. >>>>>>>>>>>>>>> Please attach the full outputs of hid-recorder and evemu-record >>>>>>>>>>>>>>> in the >>>>>>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>>>>>> I've attached full logs for two situations. More details in the >>>>>>>>>>>>>> issue. >>>>>>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>>>>>> Sorry for my noob questions, but do you suggest that it can't be >>>>>>>>>>>> fixed by >>>>>>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>>>>>> manufacturer? >>>>>>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>>>>>> some pointers. >>>>>>>>>>> >>>>>>>>>>>> If it so, do you have an idea why it works well on Windows? Do they >>>>>>>>>>>> have >>>>>>>>>>>> some strange hacks in their drivers? >>>>>>>>>>> I have no ideas how well it works under Windows, and I have no ideas >>>>>>>>>>> if there are some strange hacks in the Windows nor in the Syanptics >>>>>>>>>>> driver (I would assume so). >>>>>>>>>>> >>>>>>>>> We don't provide any drivers for touchscreens on Windows. So I don't >>>>>>>>> know how Microsoft is handling a situation like this. >>>>>>>> Do you know what should be changed in firmware to make hid-touchscreen >>>>>>>> driver works correctly? Or maybe you know someone who is responsible for >>>>>>>> firmware for this device and whom I can call to gather this information? >>>>>>>> >>>>>>> In case there *really* is broken firmware out there, we can specifically >>>>>>> identify via struct input_id's version number for example, >>>>>> I thought that Benjamin identified this as a broken firmware. I've >>>>>> attached hidraw log in the issue and there is no release event, so it >>>>>> looks like a firmware bug. How do you suggest to handle this situation >>>>>> in kernel? We can identify the device but what to do next if we have no >>>>>> information if user released finger or not? >>>>>> >>>>>>> I want to >>>>>>> point out that I would accept adding a workaround in tslib's input-raw >>>>>>> module ( http://tslib.org ) if it won't be done in the kernel. >>>>>>> >>>>>>> So, in case you can and want to use tslib as a workaround here, feel >>>>>>> free to have a look and send the patches that make input-raw.c work for >>>>>>> you over there. >>>>>> I want to be as handy as I can but I'm not sure how tslib could help in >>>>>> this situation. If we have too much data, it can filter out unnecessary >>>>>> events but I don't think that it can help when there is lack of events >>>>>> or I'm missing something? >>>>> Might as well be, I might not have thought it all through, but in >>>>> tslib's module_raw input you can can get totally creative: Why not start >>>>> *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You >>>>> *are* able to add stuff. Filters don't usually do it though. >>>> Ouch, please don't. You'll send an endless click/release sequence >>>> which will break drag and drop, double click and so on. >>>> >>> ah you're right, that's nonsense. >>> >>>> Also, this won't solve the issue because the multitouch slot will not >>>> be released. >>>> >>>> The only solution (which i believe the Windows driver does, but I >>>> believed only for Windows 7 compatible touchscreen), is to arm a timer >>>> for each slot, and when you don't receive an update after let's say 5 >>>> seconds, you release the slot. >>>> >>>> It's awful and I always have been against adding such pain in the >>>> hid-multitouch driver. >>> yes. still breaks "move after hold>5s" but would probably be the only >>> way to make this somewhat work. >> No, you won't have "move after hold>5s" broken. Because at the HID >> level, the device is supposed to send an update on every touch when >> reporting a touch (for Windows 8 devices). So if there are tiny >> movements filtered at the input level in the kernel, we will get those >> and I suspect the timeout will only appear when the finger actual >> leaves the surface. > ok. sounds a little more like a solution in the kernel would be > justified. Isn't it? It still feels dangerously ugly. > > Mainly I wanted to point out that if you somehow have to stay with "no" > for such broken devices, tslib would be a garbage can for userspace > workarounds. (in this case, most probably a new device-specific hidraw > based module). Sorry for a stupid question, but do we still discussing a solution for this device until Synaptics will correct firmware? What do you understand by firmware? A code in C compiled to kernel's module handling IRQs? Or a BIOS? Why we need to think about workarounds and not just solve the problem in the root? Will it take a long time and we want to have a quick fix for similar cases or for other reasons? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 11, 2017 at 4:30 PM, Arek Burdach <arek.burdach@gmail.com> wrote: > > > On 11.05.2017 14:50, Martin Kepplinger wrote: >> >> >> On 2017-05-11 14:28, Benjamin Tissoires wrote: >>> >>> On Thu, May 11, 2017 at 1:47 PM, Martin Kepplinger >>> <martin.kepplinger@ginzinger.com> wrote: >>>> >>>> >>>> On 2017-05-11 13:28, Benjamin Tissoires wrote: >>>>> >>>>> On Thu, May 11, 2017 at 1:22 PM, Martin Kepplinger >>>>> <martin.kepplinger@ginzinger.com> wrote: >>>>>> >>>>>> >>>>>> On 2017-05-11 12:12, Arek Burdach wrote: >>>>>>> >>>>>>> >>>>>>> On 11.05.2017 11:48, Martin Kepplinger wrote: >>>>>>>> >>>>>>>> On 2017-05-10 11:36, Arek Burdach wrote: >>>>>>>>> >>>>>>>>> Hi Andrew, >>>>>>>>> >>>>>>>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>>>>>>> >>>>>>>>>> HI Arek, >>>>>>>>>> >>>>>>>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> I've tried described by you solution: >>>>>>>>>>> >>>>>>>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>>>>>>> index 37084b645785..81f271554b6c 100644 >>>>>>>>>>> --- a/drivers/hid/hid-core.c >>>>>>>>>>> +++ b/drivers/hid/hid-core.c >>>>>>>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>>>>>>> hid_ignore_list[] = { >>>>>>>>>> >>>>>>>>>> You need to add this to the hid_have_special_driver[] and not the >>>>>>>>>> hid_ignore_list[]. >>>>>>>>> >>>>>>>>> Nice score for me - two lines and one bug :-) >>>>>>>>> >>>>>>>>>> But, if you do success in binding hid-rmi to a touchscreen it >>>>>>>>>> won't >>>>>>>>>> work. The firmware between touchpads and touchscreens are >>>>>>>>>> different >>>>>>>>>> enough that the hid-rmi driver will be looking for data which does >>>>>>>>>> not >>>>>>>>>> exist in touchscreen's HID report. These differences also mean >>>>>>>>>> that it >>>>>>>>>> really isn't a good idea to try to support touchscreens with >>>>>>>>>> hid-rmi. >>>>>>>>>> It would actually result in more transactions and be less >>>>>>>>>> efficient >>>>>>>>>> then simply using hid-multitouch. That's why hid-core checks for >>>>>>>>>> the >>>>>>>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding >>>>>>>>>> to a >>>>>>>>>> touchpad and not a touchscreen. >>>>>>>>> >>>>>>>>> It was just like you predict. On rmi, after first tap on screen, >>>>>>>>> hidraw >>>>>>>>> produced infinite number of events and it is not usable anymore. >>>>>>>>> >>>>>>>>> >>>>>>>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>>>>>>> >>>>>>>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thank you for response. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>>>>>>> anybody >>>>>>>>>>>>>>>>> that >>>>>>>>>>>>>>>>> can >>>>>>>>>>>>>>>>> help me with it? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I can have a look at it. >>>>>>>>>>>>>>>> Please attach the full outputs of hid-recorder and >>>>>>>>>>>>>>>> evemu-record >>>>>>>>>>>>>>>> in the >>>>>>>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I've attached full logs for two situations. More details in >>>>>>>>>>>>>>> the >>>>>>>>>>>>>>> issue. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>>>>>>> >>>>>>>>>>>>> Sorry for my noob questions, but do you suggest that it can't >>>>>>>>>>>>> be >>>>>>>>>>>>> fixed by >>>>>>>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>>>>>>> manufacturer? >>>>>>>>>>>> >>>>>>>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>>>>>>> some pointers. >>>>>>>>>>>> >>>>>>>>>>>>> If it so, do you have an idea why it works well on Windows? Do >>>>>>>>>>>>> they >>>>>>>>>>>>> have >>>>>>>>>>>>> some strange hacks in their drivers? >>>>>>>>>>>> >>>>>>>>>>>> I have no ideas how well it works under Windows, and I have no >>>>>>>>>>>> ideas >>>>>>>>>>>> if there are some strange hacks in the Windows nor in the >>>>>>>>>>>> Syanptics >>>>>>>>>>>> driver (I would assume so). >>>>>>>>>>>> >>>>>>>>>> We don't provide any drivers for touchscreens on Windows. So I >>>>>>>>>> don't >>>>>>>>>> know how Microsoft is handling a situation like this. >>>>>>>>> >>>>>>>>> Do you know what should be changed in firmware to make >>>>>>>>> hid-touchscreen >>>>>>>>> driver works correctly? Or maybe you know someone who is >>>>>>>>> responsible for >>>>>>>>> firmware for this device and whom I can call to gather this >>>>>>>>> information? >>>>>>>>> >>>>>>>> In case there *really* is broken firmware out there, we can >>>>>>>> specifically >>>>>>>> identify via struct input_id's version number for example, >>>>>>> >>>>>>> I thought that Benjamin identified this as a broken firmware. I've >>>>>>> attached hidraw log in the issue and there is no release event, so it >>>>>>> looks like a firmware bug. How do you suggest to handle this >>>>>>> situation >>>>>>> in kernel? We can identify the device but what to do next if we have >>>>>>> no >>>>>>> information if user released finger or not? >>>>>>> >>>>>>>> I want to >>>>>>>> point out that I would accept adding a workaround in tslib's >>>>>>>> input-raw >>>>>>>> module ( http://tslib.org ) if it won't be done in the kernel. >>>>>>>> >>>>>>>> So, in case you can and want to use tslib as a workaround here, feel >>>>>>>> free to have a look and send the patches that make input-raw.c work >>>>>>>> for >>>>>>>> you over there. >>>>>>> >>>>>>> I want to be as handy as I can but I'm not sure how tslib could help >>>>>>> in >>>>>>> this situation. If we have too much data, it can filter out >>>>>>> unnecessary >>>>>>> events but I don't think that it can help when there is lack of >>>>>>> events >>>>>>> or I'm missing something? >>>>>> >>>>>> Might as well be, I might not have thought it all through, but in >>>>>> tslib's module_raw input you can can get totally creative: Why not >>>>>> start >>>>>> *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You >>>>>> *are* able to add stuff. Filters don't usually do it though. >>>>> >>>>> Ouch, please don't. You'll send an endless click/release sequence >>>>> which will break drag and drop, double click and so on. >>>>> >>>> ah you're right, that's nonsense. >>>> >>>>> Also, this won't solve the issue because the multitouch slot will not >>>>> be released. >>>>> >>>>> The only solution (which i believe the Windows driver does, but I >>>>> believed only for Windows 7 compatible touchscreen), is to arm a timer >>>>> for each slot, and when you don't receive an update after let's say 5 >>>>> seconds, you release the slot. >>>>> >>>>> It's awful and I always have been against adding such pain in the >>>>> hid-multitouch driver. >>>> >>>> yes. still breaks "move after hold>5s" but would probably be the only >>>> way to make this somewhat work. >>> >>> No, you won't have "move after hold>5s" broken. Because at the HID >>> level, the device is supposed to send an update on every touch when >>> reporting a touch (for Windows 8 devices). So if there are tiny >>> movements filtered at the input level in the kernel, we will get those >>> and I suspect the timeout will only appear when the finger actual >>> leaves the surface. >> >> ok. sounds a little more like a solution in the kernel would be >> justified. Isn't it? It still feels dangerously ugly. >> >> Mainly I wanted to point out that if you somehow have to stay with "no" >> for such broken devices, tslib would be a garbage can for userspace >> workarounds. (in this case, most probably a new device-specific hidraw >> based module). > > Sorry for a stupid question, but do we still discussing a solution for this > device until Synaptics will correct firmware? What do you understand by > firmware? A code in C compiled to kernel's module handling IRQs? Or a BIOS? The firmware is the piece of code that is embedded in the touchscreen chip, so property of Synaptics. Everything we can do us developers will be a workaround. To upgrade the firmware, some times you need to upgrade the BIOS (UEFI) of your laptop, sometimes there is a different (but poprietary) way of doing it. > > Why we need to think about workarounds and not just solve the problem in the > root? Will it take a long time and we want to have a quick fix for similar > cases or for other reasons? That's in Synaptics' hands. If they say, yes, there is a bug on our side we will fix it in an upgrade, then we don't need to do anything. But given that Windows somewhat manages to not be affected, I guess Synaptics won't bother fixing this just for us, Linux users. Cheers, Benjamin > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11.05.2017 16:45, Benjamin Tissoires wrote: > On Thu, May 11, 2017 at 4:30 PM, Arek Burdach <arek.burdach@gmail.com> wrote: >> >> On 11.05.2017 14:50, Martin Kepplinger wrote: >>> >>> On 2017-05-11 14:28, Benjamin Tissoires wrote: >>>> On Thu, May 11, 2017 at 1:47 PM, Martin Kepplinger >>>> <martin.kepplinger@ginzinger.com> wrote: >>>>> >>>>> On 2017-05-11 13:28, Benjamin Tissoires wrote: >>>>>> On Thu, May 11, 2017 at 1:22 PM, Martin Kepplinger >>>>>> <martin.kepplinger@ginzinger.com> wrote: >>>>>>> >>>>>>> On 2017-05-11 12:12, Arek Burdach wrote: >>>>>>>> >>>>>>>> On 11.05.2017 11:48, Martin Kepplinger wrote: >>>>>>>>> On 2017-05-10 11:36, Arek Burdach wrote: >>>>>>>>>> Hi Andrew, >>>>>>>>>> >>>>>>>>>> On 10.05.2017 01:47, Andrew Duggan wrote: >>>>>>>>>>> HI Arek, >>>>>>>>>>> >>>>>>>>>>> On 05/09/2017 04:17 PM, Arek Burdach wrote: >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> I've tried described by you solution: >>>>>>>>>>>> >>>>>>>>>>>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c >>>>>>>>>>>> index 37084b645785..81f271554b6c 100644 >>>>>>>>>>>> --- a/drivers/hid/hid-core.c >>>>>>>>>>>> +++ b/drivers/hid/hid-core.c >>>>>>>>>>>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id >>>>>>>>>>>> hid_ignore_list[] = { >>>>>>>>>>> You need to add this to the hid_have_special_driver[] and not the >>>>>>>>>>> hid_ignore_list[]. >>>>>>>>>> Nice score for me - two lines and one bug :-) >>>>>>>>>> >>>>>>>>>>> But, if you do success in binding hid-rmi to a touchscreen it >>>>>>>>>>> won't >>>>>>>>>>> work. The firmware between touchpads and touchscreens are >>>>>>>>>>> different >>>>>>>>>>> enough that the hid-rmi driver will be looking for data which does >>>>>>>>>>> not >>>>>>>>>>> exist in touchscreen's HID report. These differences also mean >>>>>>>>>>> that it >>>>>>>>>>> really isn't a good idea to try to support touchscreens with >>>>>>>>>>> hid-rmi. >>>>>>>>>>> It would actually result in more transactions and be less >>>>>>>>>>> efficient >>>>>>>>>>> then simply using hid-multitouch. That's why hid-core checks for >>>>>>>>>>> the >>>>>>>>>>> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding >>>>>>>>>>> to a >>>>>>>>>>> touchpad and not a touchscreen. >>>>>>>>>> It was just like you predict. On rmi, after first tap on screen, >>>>>>>>>> hidraw >>>>>>>>>> produced infinite number of events and it is not usable anymore. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>>> On 09.05.2017 16:02, Benjamin Tissoires wrote: >>>>>>>>>>>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach >>>>>>>>>>>>> <arek.burdach@gmail.com> wrote: >>>>>>>>>>>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>>>>>>>>>>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach >>>>>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thank you for response. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>>>>>>>>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach >>>>>>>>>>>>>>>>> <arek.burdach@gmail.com> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> A week ago I've reported a bug: >>>>>>>>>>>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there >>>>>>>>>>>>>>>>>> anybody >>>>>>>>>>>>>>>>>> that >>>>>>>>>>>>>>>>>> can >>>>>>>>>>>>>>>>>> help me with it? >>>>>>>>>>>>>>>>> I can have a look at it. >>>>>>>>>>>>>>>>> Please attach the full outputs of hid-recorder and >>>>>>>>>>>>>>>>> evemu-record >>>>>>>>>>>>>>>>> in the >>>>>>>>>>>>>>>>> bugs, or it'll be difficult for us to debug it. >>>>>>>>>>>>>>>> I've attached full logs for two situations. More details in >>>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>> issue. >>>>>>>>>>>>>>> Thanks, looks like a firmware issue (I'll comment in the bug). >>>>>>>>>>>>>> Sorry for my noob questions, but do you suggest that it can't >>>>>>>>>>>>>> be >>>>>>>>>>>>>> fixed by >>>>>>>>>>>>>> changes in kernel modules and I need to report it to the >>>>>>>>>>>>>> manufacturer? >>>>>>>>>>>>> Yes. Though Andrew, in CC, works for Synaptics and might give us >>>>>>>>>>>>> some pointers. >>>>>>>>>>>>> >>>>>>>>>>>>>> If it so, do you have an idea why it works well on Windows? Do >>>>>>>>>>>>>> they >>>>>>>>>>>>>> have >>>>>>>>>>>>>> some strange hacks in their drivers? >>>>>>>>>>>>> I have no ideas how well it works under Windows, and I have no >>>>>>>>>>>>> ideas >>>>>>>>>>>>> if there are some strange hacks in the Windows nor in the >>>>>>>>>>>>> Syanptics >>>>>>>>>>>>> driver (I would assume so). >>>>>>>>>>>>> >>>>>>>>>>> We don't provide any drivers for touchscreens on Windows. So I >>>>>>>>>>> don't >>>>>>>>>>> know how Microsoft is handling a situation like this. >>>>>>>>>> Do you know what should be changed in firmware to make >>>>>>>>>> hid-touchscreen >>>>>>>>>> driver works correctly? Or maybe you know someone who is >>>>>>>>>> responsible for >>>>>>>>>> firmware for this device and whom I can call to gather this >>>>>>>>>> information? >>>>>>>>>> >>>>>>>>> In case there *really* is broken firmware out there, we can >>>>>>>>> specifically >>>>>>>>> identify via struct input_id's version number for example, >>>>>>>> I thought that Benjamin identified this as a broken firmware. I've >>>>>>>> attached hidraw log in the issue and there is no release event, so it >>>>>>>> looks like a firmware bug. How do you suggest to handle this >>>>>>>> situation >>>>>>>> in kernel? We can identify the device but what to do next if we have >>>>>>>> no >>>>>>>> information if user released finger or not? >>>>>>>> >>>>>>>>> I want to >>>>>>>>> point out that I would accept adding a workaround in tslib's >>>>>>>>> input-raw >>>>>>>>> module ( http://tslib.org ) if it won't be done in the kernel. >>>>>>>>> >>>>>>>>> So, in case you can and want to use tslib as a workaround here, feel >>>>>>>>> free to have a look and send the patches that make input-raw.c work >>>>>>>>> for >>>>>>>>> you over there. >>>>>>>> I want to be as handy as I can but I'm not sure how tslib could help >>>>>>>> in >>>>>>>> this situation. If we have too much data, it can filter out >>>>>>>> unnecessary >>>>>>>> events but I don't think that it can help when there is lack of >>>>>>>> events >>>>>>>> or I'm missing something? >>>>>>> Might as well be, I might not have thought it all through, but in >>>>>>> tslib's module_raw input you can can get totally creative: Why not >>>>>>> start >>>>>>> *every* sync frame with BTN_TOUCH 1 and end it with BTN_TOUCH 0? You >>>>>>> *are* able to add stuff. Filters don't usually do it though. >>>>>> Ouch, please don't. You'll send an endless click/release sequence >>>>>> which will break drag and drop, double click and so on. >>>>>> >>>>> ah you're right, that's nonsense. >>>>> >>>>>> Also, this won't solve the issue because the multitouch slot will not >>>>>> be released. >>>>>> >>>>>> The only solution (which i believe the Windows driver does, but I >>>>>> believed only for Windows 7 compatible touchscreen), is to arm a timer >>>>>> for each slot, and when you don't receive an update after let's say 5 >>>>>> seconds, you release the slot. >>>>>> >>>>>> It's awful and I always have been against adding such pain in the >>>>>> hid-multitouch driver. >>>>> yes. still breaks "move after hold>5s" but would probably be the only >>>>> way to make this somewhat work. >>>> No, you won't have "move after hold>5s" broken. Because at the HID >>>> level, the device is supposed to send an update on every touch when >>>> reporting a touch (for Windows 8 devices). So if there are tiny >>>> movements filtered at the input level in the kernel, we will get those >>>> and I suspect the timeout will only appear when the finger actual >>>> leaves the surface. >>> ok. sounds a little more like a solution in the kernel would be >>> justified. Isn't it? It still feels dangerously ugly. >>> >>> Mainly I wanted to point out that if you somehow have to stay with "no" >>> for such broken devices, tslib would be a garbage can for userspace >>> workarounds. (in this case, most probably a new device-specific hidraw >>> based module). >> Sorry for a stupid question, but do we still discussing a solution for this >> device until Synaptics will correct firmware? What do you understand by >> firmware? A code in C compiled to kernel's module handling IRQs? Or a BIOS? > The firmware is the piece of code that is embedded in the touchscreen > chip, so property of Synaptics. Everything we can do us developers > will be a workaround. > To upgrade the firmware, some times you need to upgrade the BIOS > (UEFI) of your laptop, sometimes there is a different (but poprietary) > way of doing it. > >> Why we need to think about workarounds and not just solve the problem in the >> root? Will it take a long time and we want to have a quick fix for similar >> cases or for other reasons? > That's in Synaptics' hands. If they say, yes, there is a bug on our > side we will fix it in an upgrade, then we don't need to do anything. > But given that Windows somewhat manages to not be affected, I guess > Synaptics won't bother fixing this just for us, Linux users. > Thank you for clarification. So do someone have an idea how it is possible that Windows manages this? From my point of view, they can't rely on timeouts because effect is visible immediately after releasing finger. Is it possible that they use other protocol for communication with device then we do? Because beside that, I don't see any other option - there is too few information from device to correctly handle this situation. Cheers, Arek -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> No, you won't have "move after hold>5s" broken. Because at the HID >>>>> level, the device is supposed to send an update on every touch when >>>>> reporting a touch (for Windows 8 devices). So if there are tiny >>>>> movements filtered at the input level in the kernel, we will get those >>>>> and I suspect the timeout will only appear when the finger actual >>>>> leaves the surface. >>>> ok. sounds a little more like a solution in the kernel would be >>>> justified. Isn't it? It still feels dangerously ugly. >>>> >>>> Mainly I wanted to point out that if you somehow have to stay with "no" >>>> for such broken devices, tslib would be a garbage can for userspace >>>> workarounds. (in this case, most probably a new device-specific hidraw >>>> based module). (...) > Thank you for clarification. So do someone have an idea how it is > possible that Windows manages this? From my point of view, they can't > rely on timeouts because effect is visible immediately after releasing > finger. Is it possible that they use other protocol for communication > with device then we do? Because beside that, I don't see any other > option - there is too few information from device to correctly handle > this situation. hey, Benjamin explained what most probably is going on, see above, so: 1. convice yourself that microsoft isn't using out-of-band data by sniffing the connection. 2. if not, and Benjamin is right, come up with a timer- and hidraw based solution (I guess) and convince him and Dmitry to take it. 3. if they don't see any chance to support such broken behaviour in the kernel, which could as well be and also has it's benefits in some way, you write the thing in userspace (a tslib raw module is only one example that would make it easy for you). Even *if* Synaptics would come up with a firmware update: 1. the current firmware is already out there in the wild; 2. it takes time and work to get people to update so, if I had the device, I'd write a workaround. martin
On 12.05.2017 08:56, Martin Kepplinger wrote: >>>>>> No, you won't have "move after hold>5s" broken. Because at the HID >>>>>> level, the device is supposed to send an update on every touch when >>>>>> reporting a touch (for Windows 8 devices). So if there are tiny >>>>>> movements filtered at the input level in the kernel, we will get those >>>>>> and I suspect the timeout will only appear when the finger actual >>>>>> leaves the surface. >>>>> ok. sounds a little more like a solution in the kernel would be >>>>> justified. Isn't it? It still feels dangerously ugly. >>>>> >>>>> Mainly I wanted to point out that if you somehow have to stay with "no" >>>>> for such broken devices, tslib would be a garbage can for userspace >>>>> workarounds. (in this case, most probably a new device-specific hidraw >>>>> based module). > (...) > >> Thank you for clarification. So do someone have an idea how it is >> possible that Windows manages this? From my point of view, they can't >> rely on timeouts because effect is visible immediately after releasing >> finger. Is it possible that they use other protocol for communication >> with device then we do? Because beside that, I don't see any other >> option - there is too few information from device to correctly handle >> this situation. > hey, Benjamin explained what most probably is going on, see above, so: > > 1. convice yourself that microsoft isn't using out-of-band data by > sniffing the connection. Touchscreen is communicating via i2c - am i right? Can you recommend some i2c sniffer for windows? > 2. if not, and Benjamin is right, come up with a timer- and hidraw based > solution (I guess) and convince him and Dmitry to take it. > > 3. if they don't see any chance to support such broken behaviour in the > kernel, which could as well be and also has it's benefits in some way, > you write the thing in userspace (a tslib raw module is only one example > that would make it easy for you). > > Even *if* Synaptics would come up with a firmware update: > 1. the current firmware is already out there in the wild; > 2. it takes time and work to get people to update > > so, if I had the device, I'd write a workaround. It is reasonable what you've wrote. The only blocker for me is that I have almost zero-experience in low level programming. I'm from java world :-) It is why I was looking for some low entry level solution. I'll do my best but every helping hand will be appreciated. Cheers, Arek -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017-05-12 09:25, Arek Burdach wrote: > > > On 12.05.2017 08:56, Martin Kepplinger wrote: >>>>>>> No, you won't have "move after hold>5s" broken. Because at the HID >>>>>>> level, the device is supposed to send an update on every touch when >>>>>>> reporting a touch (for Windows 8 devices). So if there are tiny >>>>>>> movements filtered at the input level in the kernel, we will get >>>>>>> those >>>>>>> and I suspect the timeout will only appear when the finger actual >>>>>>> leaves the surface. >>>>>> ok. sounds a little more like a solution in the kernel would be >>>>>> justified. Isn't it? It still feels dangerously ugly. >>>>>> >>>>>> Mainly I wanted to point out that if you somehow have to stay with >>>>>> "no" >>>>>> for such broken devices, tslib would be a garbage can for userspace >>>>>> workarounds. (in this case, most probably a new device-specific >>>>>> hidraw >>>>>> based module). >> (...) >> >>> Thank you for clarification. So do someone have an idea how it is >>> possible that Windows manages this? From my point of view, they can't >>> rely on timeouts because effect is visible immediately after releasing >>> finger. Is it possible that they use other protocol for communication >>> with device then we do? Because beside that, I don't see any other >>> option - there is too few information from device to correctly handle >>> this situation. >> hey, Benjamin explained what most probably is going on, see above, so: >> >> 1. convice yourself that microsoft isn't using out-of-band data by >> sniffing the connection. > Touchscreen is communicating via i2c - am i right? Can you recommend > some i2c sniffer for windows? no, I can only look for one, like you. https://lmddgtfy.net/?q=buy%20i2c%20sniffer > >> 2. if not, and Benjamin is right, come up with a timer- and hidraw based >> solution (I guess) and convince him and Dmitry to take it. >> >> 3. if they don't see any chance to support such broken behaviour in the >> kernel, which could as well be and also has it's benefits in some way, >> you write the thing in userspace (a tslib raw module is only one example >> that would make it easy for you). >> >> Even *if* Synaptics would come up with a firmware update: >> 1. the current firmware is already out there in the wild; >> 2. it takes time and work to get people to update >> >> so, if I had the device, I'd write a workaround. > It is reasonable what you've wrote. The only blocker for me is that I > have almost zero-experience in low level programming. I'm from java > world :-) It is why I was looking for some low entry level solution. > I'll do my best but every helping hand will be appreciated. > Keep asking Synaptics for answers then. Or pay somebody to write a driver. Or be patient and do it yourself. martin
On Fri, May 12, 2017 at 9:25 AM, Arek Burdach <arek.burdach@gmail.com> wrote: > > > On 12.05.2017 08:56, Martin Kepplinger wrote: >>>>>>> >>>>>>> No, you won't have "move after hold>5s" broken. Because at the HID >>>>>>> level, the device is supposed to send an update on every touch when >>>>>>> reporting a touch (for Windows 8 devices). So if there are tiny >>>>>>> movements filtered at the input level in the kernel, we will get >>>>>>> those >>>>>>> and I suspect the timeout will only appear when the finger actual >>>>>>> leaves the surface. >>>>>> >>>>>> ok. sounds a little more like a solution in the kernel would be >>>>>> justified. Isn't it? It still feels dangerously ugly. >>>>>> >>>>>> Mainly I wanted to point out that if you somehow have to stay with >>>>>> "no" >>>>>> for such broken devices, tslib would be a garbage can for userspace >>>>>> workarounds. (in this case, most probably a new device-specific hidraw >>>>>> based module). >> >> (...) >> >>> Thank you for clarification. So do someone have an idea how it is >>> possible that Windows manages this? From my point of view, they can't >>> rely on timeouts because effect is visible immediately after releasing >>> finger. Is it possible that they use other protocol for communication >>> with device then we do? Because beside that, I don't see any other >>> option - there is too few information from device to correctly handle >>> this situation. >> >> hey, Benjamin explained what most probably is going on, see above, so: >> >> 1. convice yourself that microsoft isn't using out-of-band data by >> sniffing the connection. > > Touchscreen is communicating via i2c - am i right? Can you recommend some > i2c sniffer for windows? I wrote something few months ago: https://github.com/bentiss/SimplePeripheralBusProbe But it requires you to have confidence in not breaking your EFI :) I can help you setting the bits up if you want. > >> 2. if not, and Benjamin is right, come up with a timer- and hidraw based >> solution (I guess) and convince him and Dmitry to take it. >> >> 3. if they don't see any chance to support such broken behaviour in the >> kernel, which could as well be and also has it's benefits in some way, >> you write the thing in userspace (a tslib raw module is only one example >> that would make it easy for you). >> >> Even *if* Synaptics would come up with a firmware update: >> 1. the current firmware is already out there in the wild; >> 2. it takes time and work to get people to update >> >> so, if I had the device, I'd write a workaround. > > It is reasonable what you've wrote. The only blocker for me is that I have > almost zero-experience in low level programming. I'm from java world :-) It > is why I was looking for some low entry level solution. I'll do my best but > every helping hand will be appreciated. I am currently checking the requirements for the devices to be validated by Microsoft: https://msdn.microsoft.com/en-us/windows/hardware/commercialize/design/compatibility/1703/device-input-digitizer I would believe that the Latency and ReportRate requirements mean that as long as a finger is there, it should be reported at at least 60Hz, meaning that if there are no input reports for more than 16 ms, all fingers should be lifted. I think we can work something like that (taking an arbitrary multiple of 60 Hz would prevent any system lag), and release the touches if nothing comes in for, lets say, 250ms. I should be able to work on that for Win8 devices. Win7 devices are a different beast, but hopefully they are nearly extinct or at least quirked in the kernel for them to be working. Cheers, Benjamin > > Cheers, > Arek -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12.05.2017 09:39, Benjamin Tissoires wrote: > On Fri, May 12, 2017 at 9:25 AM, Arek Burdach <arek.burdach@gmail.com> wrote: >> >> On 12.05.2017 08:56, Martin Kepplinger wrote: >>>>>>>> No, you won't have "move after hold>5s" broken. Because at the HID >>>>>>>> level, the device is supposed to send an update on every touch when >>>>>>>> reporting a touch (for Windows 8 devices). So if there are tiny >>>>>>>> movements filtered at the input level in the kernel, we will get >>>>>>>> those >>>>>>>> and I suspect the timeout will only appear when the finger actual >>>>>>>> leaves the surface. >>>>>>> ok. sounds a little more like a solution in the kernel would be >>>>>>> justified. Isn't it? It still feels dangerously ugly. >>>>>>> >>>>>>> Mainly I wanted to point out that if you somehow have to stay with >>>>>>> "no" >>>>>>> for such broken devices, tslib would be a garbage can for userspace >>>>>>> workarounds. (in this case, most probably a new device-specific hidraw >>>>>>> based module). >>> (...) >>> >>>> Thank you for clarification. So do someone have an idea how it is >>>> possible that Windows manages this? From my point of view, they can't >>>> rely on timeouts because effect is visible immediately after releasing >>>> finger. Is it possible that they use other protocol for communication >>>> with device then we do? Because beside that, I don't see any other >>>> option - there is too few information from device to correctly handle >>>> this situation. >>> hey, Benjamin explained what most probably is going on, see above, so: >>> >>> 1. convice yourself that microsoft isn't using out-of-band data by >>> sniffing the connection. >> Touchscreen is communicating via i2c - am i right? Can you recommend some >> i2c sniffer for windows? > I wrote something few months ago: > https://github.com/bentiss/SimplePeripheralBusProbe > But it requires you to have confidence in not breaking your EFI :) > > I can help you setting the bits up if you want. > >>> 2. if not, and Benjamin is right, come up with a timer- and hidraw based >>> solution (I guess) and convince him and Dmitry to take it. >>> >>> 3. if they don't see any chance to support such broken behaviour in the >>> kernel, which could as well be and also has it's benefits in some way, >>> you write the thing in userspace (a tslib raw module is only one example >>> that would make it easy for you). >>> >>> Even *if* Synaptics would come up with a firmware update: >>> 1. the current firmware is already out there in the wild; >>> 2. it takes time and work to get people to update >>> >>> so, if I had the device, I'd write a workaround. >> It is reasonable what you've wrote. The only blocker for me is that I have >> almost zero-experience in low level programming. I'm from java world :-) It >> is why I was looking for some low entry level solution. I'll do my best but >> every helping hand will be appreciated. > I am currently checking the requirements for the devices to be > validated by Microsoft: > https://msdn.microsoft.com/en-us/windows/hardware/commercialize/design/compatibility/1703/device-input-digitizer > > I would believe that the Latency and ReportRate requirements mean that > as long as a finger is there, it should be reported at at least 60Hz, > meaning that if there are no input reports for more than 16 ms, all > fingers should be lifted. I think we can work something like that > (taking an arbitrary multiple of 60 Hz would prevent any system lag), > and release the touches if nothing comes in for, lets say, 250ms. Thank you Benjamin, it is significant brick for building knowledge how this devices are handled in Windows. I will take a look in our drivers and will try to understand the code and find the way how to handle it. > > I should be able to work on that for Win8 devices. Win7 devices are a > different beast, but hopefully they are nearly extinct or at least > quirked in the kernel for them to be working. > > Cheers, > Benjamin > >> Cheers, >> Arek -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 37084b645785..81f271554b6c 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2510,6 +2510,7 @@ static const struct hid_device_id hid_ignore_list[] = { { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_WTP) }, { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_DPAD) }, #endif + { HID_I2C_DEVICE(USB_VENDOR_ID_SYNAPTICS, 0x1786) }, { HID_USB_DEVICE(USB_VENDOR_ID_YEALINK, USB_DEVICE_ID_YEALINK_P1K_P4K_B2K) }, { } }; diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 5b40c2614599..ac2ea6ad2e53 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -714,6 +714,7 @@ static void rmi_remove(struct hid_device *hdev) } static const struct hid_device_id rmi_id[] = { + { HID_I2C_DEVICE(USB_VENDOR_ID_SYNAPTICS, 0x1786) }, { HID_USB_DEVICE(USB_VENDOR_ID_RAZER, USB_DEVICE_ID_RAZER_BLADE_14), .driver_data = RMI_DEVICE_HAS_PHYS_BUTTONS },
Hi, I've tried described by you solution: { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X1_COVER) }, and now neither hid-touchscreen nor hid-rmi peaking up my touchscreen (also missing hidraw device) Any other idea how to force hid-rmi to peak the device? Cheers, Arek On 09.05.2017 16:02, Benjamin Tissoires wrote: > On Tue, May 9, 2017 at 2:51 PM, Arek Burdach <arek.burdach@gmail.com> wrote: >> On 09.05.2017 14:20, Benjamin Tissoires wrote: >>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach <arek.burdach@gmail.com> >>> wrote: >>>> Hi, >>>> >>>> Thank you for response. >>>> >>>> On 09.05.2017 10:35, Benjamin Tissoires wrote: >>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach <arek.burdach@gmail.com> >>>>> wrote: >>>>>> Hi, >>>>>> >>>>>> A week ago I've reported a bug: >>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there anybody >>>>>> that >>>>>> can >>>>>> help me with it? >>>>> I can have a look at it. >>>>> Please attach the full outputs of hid-recorder and evemu-record in the >>>>> bugs, or it'll be difficult for us to debug it. >>>> I've attached full logs for two situations. More details in the issue. >>> Thanks, looks like a firmware issue (I'll comment in the bug). >> Sorry for my noob questions, but do you suggest that it can't be fixed by >> changes in kernel modules and I need to report it to the manufacturer? > Yes. Though Andrew, in CC, works for Synaptics and might give us some pointers. > >> If it so, do you have an idea why it works well on Windows? Do they have >> some strange hacks in their drivers? > I have no ideas how well it works under Windows, and I have no ideas > if there are some strange hacks in the Windows nor in the Syanptics > driver (I would assume so). > >> >> >>>>>> I found out that some touchpads (and possible touchscreens?) are >>>>>> handled >>>>>> by >>>>>> both hid-multitouch and hid-rmi drivers. Is there a way to verify how >>>>>> the >>>>>> touchscreen would work on hid-rmi drivers? I've tested it with kernel >>>>>> 4.11.0-rc1 version where was this change: >>>>>> 279967a65b320d174a507498aea7d44db3fee7f4 HID: rmi: Handle all Synaptics >>>>>> touchpads using hid-rmi >>>>>> which was reverted in later kernel's version. On this version, only my >>>>>> touchpad was handled by hid-rmi, touchscreen was still handled by >>>>>> hid-multitouch. Maybe I should change something in code or in >>>>>> compilation >>>>>> configuration to force hid-rmi? >>>>> Well, with 279967a65 applied, the system would know if the device can >>>>> be handled through hid-rmi or not. If hid-multitouch was still used, >>>>> that means that the device was not designed to be used as a rmi device >>>>> at all (i.e. hid-rmi will not be able to talk to it). >>>> In this patch, there is verified if hid group is >>>> HID_GROUP_MULTITOUCH_WIN_8. >>>> Maybe this touchscreen is in group with greater priority during >>>> recognition. >>>> Can I verify it somehow? >>> With the logs you gave, the touchscreen is indeed Win 8 certified. >>> >>>> Also HID_GROUP_MULTITOUCH_WIN_8 recognition is done by this: >>>>> usage == 0xff0000c5 && parser->global.report_count == 256 && >>>>> parser->global.report_size == 8 >>>> I assume that it is correct way to verify that. I wonder if it is >>>> possible >>>> that something changed for a new devices. >>> Nope, looks good for your device. The reason why hid-rmi is not >>> picking up your device is because of the check "parser->scan_flags & >>> HID_SCAN_FLAG_GD_POINTER": this matches only to indirect devices >>> (touchpads). >>> >>> If you can recompile your hid and hid-rmi modules, you can try giving a >>> shot at: >>> - adding HID_I2C_DEVICE(USB_VENDOR_ID_SYNAPTICS, 0x1786) }, in >>> hid_have_special_driver[] in hid-core.c >>> - adding a corresponding line in rmi_id[] in file hid-rmi.c. >>> >>> This should force the device to bind to hid-rmi and you'll be able to >>> see if the device works better in this situation or not. >> Sorry for another noob question, but if I switch to hid-rmi, it should >> potentially produce other output in both /dev/hidraw output and >> /dev/input/event output or only in the second one? > The more, the better. Please provide all logs, hidraw and evemu. > >> I'm just wonder what is the pipeline. >> >> I'll give a try to it and revert back to you with results. Thank you for >> tip! > No worries. > > Cheers, > Benjamin > >> >>> Cheers, >>> Benjamin >>> >>>> Cheers, >>>> Arek >>>> >>>> >>>>> Cheers, >>>>> Benjamin >>>>> >>>>>> Or it is a wrong way to go? I would be grateful for your help. >>>>>> >>>>>> Regards, >>>>>> Arek >>>> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html