| Message ID | 20170509214604.GA7643@embeddedgus (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 05/09/2017 02:46 PM, Gustavo A. R. Silva wrote: > Local variable _ret_ is assigned to a constant value and it is never > updated again. Remove this variable and the dead code it guards. > > Addresses-Coverity-ID: 140761 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2017-05-11 at 13:39 -0700, Tyrel Datwyler wrote: > On 05/09/2017 02:46 PM, Gustavo A. R. Silva wrote: > > Local variable _ret_ is assigned to a constant value and it is never > > updated again. Remove this variable and the dead code it guards. > > > > Addresses-Coverity-ID: 140761 > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > --- > > Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> > Applied to target-pending/for-next. Thanks Gustavo + Tyrel. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/target/target_core_rd.c b/drivers/target/target_core_rd.c index ddc216c..6e8ef23 100644 --- a/drivers/target/target_core_rd.c +++ b/drivers/target/target_core_rd.c @@ -568,7 +568,7 @@ static ssize_t rd_set_configfs_dev_params(struct se_device *dev, struct rd_dev *rd_dev = RD_DEV(dev); char *orig, *ptr, *opts; substring_t args[MAX_OPT_ARGS]; - int ret = 0, arg, token; + int arg, token; opts = kstrdup(page, GFP_KERNEL); if (!opts) @@ -603,7 +603,7 @@ static ssize_t rd_set_configfs_dev_params(struct se_device *dev, } kfree(orig); - return (!ret) ? count : ret; + return count; } static ssize_t rd_show_configfs_dev_params(struct se_device *dev, char *b)
Local variable _ret_ is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 140761 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/target/target_core_rd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)