| Message ID | 20170507143446.11502-1-ayaka@soulik.info (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Randy, Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li: > The PWM devices need to access the grf to switch the PWM IP. The grf property is not part of the pwm binding and I remember this coming up in veyron times, when Thiery didn't want such settings in the pwm driver. So the kernel pwm driver does not switch anything right now. > And tsadc uses it to shutdown the system. No it doesn't. The tsadc on rk3288 does not do any grf settings right now, as it is using the v2_initialize function. Only rk3366 and rk3399 seem to do any grf settings in the current v4.12-rc1 . Or is there some tsadc patch from you pending to change that? Heiko
On 05/14/2017 10:59 PM, Heiko Stuebner wrote: > Hi Randy, > > Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li: >> The PWM devices need to access the grf to switch the PWM IP. > The grf property is not part of the pwm binding and I remember > this coming up in veyron times, when Thiery didn't want such settings > in the pwm driver. So the kernel pwm driver does not switch anything > right now. OK, I see, I will contact the u-boot, submit a patch there. > > >> And tsadc uses it to shutdown the system. > No it doesn't. The tsadc on rk3288 does not do any grf settings right now, > as it is using the v2_initialize function. Only rk3366 and rk3399 seem > to do any grf settings in the current v4.12-rc1 . Or is there some tsadc > patch from you pending to change that? Not yet, there is a register CRU_GLB_RST_ST at rk3288 cru. I think I need to submit a patch for it. > > > Heiko
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 26b8886..c1d3b1f 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -546,6 +546,7 @@ pinctrl-2 = <&otp_gpio>; #thermal-sensor-cells = <1>; rockchip,hw-tshut-temp = <95000>; + rockchip,grf = <&grf>; status = "disabled"; }; @@ -654,6 +655,7 @@ pinctrl-0 = <&pwm0_pin>; clocks = <&cru PCLK_PWM>; clock-names = "pwm"; + rockchip,grf = <&grf>; status = "disabled"; }; @@ -665,6 +667,7 @@ pinctrl-0 = <&pwm1_pin>; clocks = <&cru PCLK_PWM>; clock-names = "pwm"; + rockchip,grf = <&grf>; status = "disabled"; }; @@ -676,6 +679,7 @@ pinctrl-0 = <&pwm2_pin>; clocks = <&cru PCLK_PWM>; clock-names = "pwm"; + rockchip,grf = <&grf>; status = "disabled"; }; @@ -687,6 +691,7 @@ pinctrl-0 = <&pwm3_pin>; clocks = <&cru PCLK_PWM>; clock-names = "pwm"; + rockchip,grf = <&grf>; status = "disabled"; };
The PWM devices need to access the grf to switch the PWM IP. And tsadc uses it to shutdown the system. Signed-off-by: Randy Li <ayaka@soulik.info> --- arch/arm/boot/dts/rk3288.dtsi | 5 +++++ 1 file changed, 5 insertions(+)