| Message ID | 1493883438-19462-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 967d6941f49f1ddd5764d3a09423a63841b9394c |
| Headers | show |
On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined! > > Add a dependency on HAS_DMA to fix this. There's no progress on fixing the architectures that don't do DMA to stub it out? :(
Hi Mark, On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote: > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote: >> If NO_DMA=y: >> >> ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined! >> >> Add a dependency on HAS_DMA to fix this. > > There's no progress on fixing the architectures that don't do DMA to > stub it out? :( Then it has to become "depends on HAS_DMA || COMPILE_TEST"? Even more typing work for me ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote: > On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote: > > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote: > >> If NO_DMA=y: > >> ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined! > >> Add a dependency on HAS_DMA to fix this. > > There's no progress on fixing the architectures that don't do DMA to > > stub it out? :( > Then it has to become "depends on HAS_DMA || COMPILE_TEST"? No, I was thinking more just not needing the dependency at all.
Hi Mark, On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote: > On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote: >> On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote: >> > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote: >> >> If NO_DMA=y: > >> >> ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined! > >> >> Add a dependency on HAS_DMA to fix this. > >> > There's no progress on fixing the architectures that don't do DMA to >> > stub it out? :( > >> Then it has to become "depends on HAS_DMA || COMPILE_TEST"? > > No, I was thinking more just not needing the dependency at all. Then what's the point of the existence of COMPILE_TEST? We can just have stubs for everything, and always build everything. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 15, 2017 at 12:21:33PM +0200, Geert Uytterhoeven wrote: > On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote: > > No, I was thinking more just not needing the dependency at all. > Then what's the point of the existence of COMPILE_TEST? > We can just have stubs for everything, and always build everything. It's useful for platform specific devices (like this one should be) but having to add dependencies for basic kernel APIs like the DMA one is just making for a lot of noise. There's plenty of platforms without DMA that also have no real use for this driver, it's not really a relevant thing when deciding if the driver might be useful if what you're trying to do is hide drivers that aren't useful on the platform.
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 6caff35af8815cda..51bf4da6dc18e7e8 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -463,6 +463,7 @@ config SPI_OMAP24XX config SPI_TI_QSPI tristate "DRA7xxx QSPI controller support" + depends on HAS_DMA depends on ARCH_OMAP2PLUS || COMPILE_TEST help QSPI master controller for DRA7xxx used for flash devices.
If NO_DMA=y: ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined! Add a dependency on HAS_DMA to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)