| Message ID | 20170526054013.299-1-n54@gmx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi On Fri, May 26, 2017 at 9:49 AM Kamil Rytarowski <n54@gmx.com> wrote: > Currently ivshmem requires eventfd() which is Linux specific. > Do not and build it unconditionally on every Linux/BSD/Solaris. > > I think it should be able to use pipe fallback from event_notifier_init() . > This patch indirectly fixes build failure on NetBSD, where these tools > additionally require -lrl for shm_open(3). In future there should be > added support for NetBSD and the linking addressed appropriately. > > Signed-off-by: Kamil Rytarowski <n54@gmx.com> > --- > configure | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configure b/configure > index 1a5ee4b909..84d8660354 100755 > --- a/configure > +++ b/configure > @@ -4928,6 +4928,8 @@ if test "$want_tools" = "yes" ; then > tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools" > if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then > tools="qemu-nbd\$(EXESUF) $tools" > + fi > + if [ "$eventfd" != "no" ]; then > tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools" > fi > fi > -- > 2.13.0 > > > -- Marc-André Lureau
diff --git a/configure b/configure index 1a5ee4b909..84d8660354 100755 --- a/configure +++ b/configure @@ -4928,6 +4928,8 @@ if test "$want_tools" = "yes" ; then tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools" if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then tools="qemu-nbd\$(EXESUF) $tools" + fi + if [ "$eventfd" != "no" ]; then tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools" fi fi
Currently ivshmem requires eventfd() which is Linux specific. Do not and build it unconditionally on every Linux/BSD/Solaris. This patch indirectly fixes build failure on NetBSD, where these tools additionally require -lrl for shm_open(3). In future there should be added support for NetBSD and the linking addressed appropriately. Signed-off-by: Kamil Rytarowski <n54@gmx.com> --- configure | 2 ++ 1 file changed, 2 insertions(+)