| Message ID | 20170419091326.11226-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Apr 19, 2017 at 11:13 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > These compatible strings need to be added to extend support > for the RPM CC to cover MSM8660/APQ8060. We also need to add > enumberators to the include file for a few clocks that were > missing. > > Cc: devicetree@vger.kernel.org > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v1->v2: > - Collect Rob's ACK Ping on this patch set. It's been sitting for a month and was not changed from v1 either, if you want me to change something it'd be good to know. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 17, 2017 at 9:23 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Apr 19, 2017 at 11:13 AM, Linus Walleij > <linus.walleij@linaro.org> wrote: > >> These compatible strings need to be added to extend support >> for the RPM CC to cover MSM8660/APQ8060. We also need to add >> enumberators to the include file for a few clocks that were >> missing. >> >> Cc: devicetree@vger.kernel.org >> Acked-by: Rob Herring <robh@kernel.org> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> >> --- >> ChangeLog v1->v2: >> - Collect Rob's ACK > > Ping on this patch set. It's been sitting for a month and was > not changed from v1 either, if you want me to change something > it'd be good to know. Ping on this again. I am sorry if you guys are swamped, I just don't know what to do, clock drivers are starting to become the bottleneck for everything I do. I bet the ARM SoC maintainers must be noticing it too. Unfortunately I am already managing two subsystems and cannot volunteer to help out with a third, I would blow a fuse. But it seems the CLK subsystem could use some co-maintainers? Peter de Schrijver is a big authority in all things clocking (I clearly remember him discussing the subject a lot at conferences with lots of good points) so I would ask him to help, but I don't know how busy Peter may be with nVidia business etc these days... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 24, 2017 at 11:16:22AM +0200, Linus Walleij wrote: > On Wed, May 17, 2017 at 9:23 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Apr 19, 2017 at 11:13 AM, Linus Walleij > > <linus.walleij@linaro.org> wrote: > > > >> These compatible strings need to be added to extend support > >> for the RPM CC to cover MSM8660/APQ8060. We also need to add > >> enumberators to the include file for a few clocks that were > >> missing. > >> > >> Cc: devicetree@vger.kernel.org > >> Acked-by: Rob Herring <robh@kernel.org> > >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > >> --- > >> ChangeLog v1->v2: > >> - Collect Rob's ACK > > > > Ping on this patch set. It's been sitting for a month and was > > not changed from v1 either, if you want me to change something > > it'd be good to know. > > Ping on this again. > > I am sorry if you guys are swamped, I just don't know what to do, > clock drivers are starting to become the bottleneck for everything > I do. I bet the ARM SoC maintainers must be noticing it too. > > Unfortunately I am already managing two subsystems and cannot > volunteer to help out with a third, I would blow a fuse. > > But it seems the CLK subsystem could use some co-maintainers? > > Peter de Schrijver is a big authority in all things clocking (I clearly > remember him discussing the subject a lot at conferences with lots > of good points) so I would ask him to help, but I don't know how busy > Peter may be with nVidia business etc these days... > I'm usually rather busy yes, but I could try to find some time for this if asked for. Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/24, Linus Walleij wrote: > On Wed, May 17, 2017 at 9:23 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Apr 19, 2017 at 11:13 AM, Linus Walleij > > <linus.walleij@linaro.org> wrote: > > > >> These compatible strings need to be added to extend support > >> for the RPM CC to cover MSM8660/APQ8060. We also need to add > >> enumberators to the include file for a few clocks that were > >> missing. > >> > >> Cc: devicetree@vger.kernel.org > >> Acked-by: Rob Herring <robh@kernel.org> > >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > >> --- > >> ChangeLog v1->v2: > >> - Collect Rob's ACK > > > > Ping on this patch set. It's been sitting for a month and was > > not changed from v1 either, if you want me to change something > > it'd be good to know. > > Ping on this again. > > I am sorry if you guys are swamped, I just don't know what to do, > clock drivers are starting to become the bottleneck for everything > I do. I bet the ARM SoC maintainers must be noticing it too. > > Unfortunately I am already managing two subsystems and cannot > volunteer to help out with a third, I would blow a fuse. > > But it seems the CLK subsystem could use some co-maintainers? > > Peter de Schrijver is a big authority in all things clocking (I clearly > remember him discussing the subject a lot at conferences with lots > of good points) so I would ask him to help, but I don't know how busy > Peter may be with nVidia business etc these days... Meh. Life happens and msm8660 is about a decade old now and not something that I can easily review without digging through old websites to find documentation on the code I worked on 7 years ago. So sorry, but these sorts of patches are basically approaching priority none for me and I have to steal time to review them. I'm getting back up to speed though on my mails, so things should be good. Let me know if things seem broken next week please.
On 04/19, Linus Walleij wrote: > These compatible strings need to be added to extend support > for the RPM CC to cover MSM8660/APQ8060. We also need to add > enumberators to the include file for a few clocks that were > missing. > > Cc: devicetree@vger.kernel.org > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- Applied to clk-qcom-rpm
On Thu, Jun 1, 2017 at 9:38 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 05/24, Linus Walleij wrote: >> I am sorry if you guys are swamped, I just don't know what to do, >> clock drivers are starting to become the bottleneck for everything >> I do. I bet the ARM SoC maintainers must be noticing it too. (...) > Meh. Life happens and msm8660 is about a decade old now and not > something that I can easily review without digging through old > websites to find documentation on the code I worked on 7 years > ago. So sorry, but these sorts of patches are basically > approaching priority none for me and I have to steal time to > review them. Sorry the reference above was mainly to the Gemini SoC clock driver which was blocking ARM consolidation, the fact that this MSM8660 thing was stalled too just got me to think it was related. I understand the MSM8660 is low prio, but the first DragonBoard was pushed to developers en masse in 2012 (yours truly included), which was just half a decade ago, and started the community boards effort from Qualcomm, and yeah, community moves slower than markets usually, the board is still supported by the BSquare company that managed the board release for Qualcomm, I can still login and check schematics and support forums, cool isn't it :D Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt index a7235e9e1c97..d470a0187035 100644 --- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt @@ -10,6 +10,8 @@ Required properties : - compatible : shall contain only one of the following. The generic compatible "qcom,rpmcc" should be also included. + "qcom,rpmcc-msm8660", "qcom,rpmcc" + "qcom,rpmcc-apq8060", "qcom,rpmcc" "qcom,rpmcc-msm8916", "qcom,rpmcc" "qcom,rpmcc-msm8974", "qcom,rpmcc" "qcom,rpmcc-apq8064", "qcom,rpmcc" diff --git a/include/dt-bindings/clock/qcom,rpmcc.h b/include/dt-bindings/clock/qcom,rpmcc.h index 96b63c00249e..44358562a031 100644 --- a/include/dt-bindings/clock/qcom,rpmcc.h +++ b/include/dt-bindings/clock/qcom,rpmcc.h @@ -37,6 +37,10 @@ #define RPM_SYS_FABRIC_A_CLK 19 #define RPM_SFPB_CLK 20 #define RPM_SFPB_A_CLK 21 +#define RPM_PLL4_CLK 22 +#define RPM_PLL4_A_CLK 23 +#define RPM_SMI_CLK 24 +#define RPM_SMI_A_CLK 25 /* SMD RPM clocks */ #define RPM_SMD_XO_CLK_SRC 0