| Message ID | 1495791789-19230-2-git-send-email-ryder.lee@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 26/05/17 11:43, Ryder Lee wrote: > This patch removes unnecessary clock in binding file. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- In the driver clocks are get by name, so this change does not break backwards compatibility. Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > index c204725..450da36 100644 > --- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > +++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > @@ -6,8 +6,7 @@ Required properties: > - interrupts: Should contain the five crypto engines interrupts in numeric > order. These are global system and four descriptor rings. > - clocks: the clock used by the core > -- clock-names: the names of the clock listed in the clocks property. These are > - "ethif", "cryp" > +- clock-names: Must contain "cryp". > - power-domains: Must contain a reference to the PM domain. > > > @@ -20,8 +19,7 @@ Example: > <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>, > <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>, > <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>; > - clocks = <&topckgen CLK_TOP_ETHIF_SEL>, > - <ðsys CLK_ETHSYS_CRYPTO>; > - clock-names = "ethif","cryp"; > + clocks = <ðsys CLK_ETHSYS_CRYPTO>; > + clock-names = "cryp"; > power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; > }; >
On Fri, May 26, 2017 at 05:43:09PM +0800, Ryder Lee wrote:
> This patch removes unnecessary clock in binding file.
Why is the clock unnecessary? A h/w block either has a clock or doesn't.
The subject needs some work. Perhaps "dt-bindings: crypto: remove
mediatek ethif clock".
Rob
On Wed, 2017-05-31 at 13:46 -0500, Rob Herring wrote: > On Fri, May 26, 2017 at 05:43:09PM +0800, Ryder Lee wrote: > > This patch removes unnecessary clock in binding file. > > Why is the clock unnecessary? A h/w block either has a clock or doesn't. > > The subject needs some work. Perhaps "dt-bindings: crypto: remove > mediatek ethif clock". > > Rob I'll write more clearly, thanks. Ryder.
diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt index c204725..450da36 100644 --- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt +++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt @@ -6,8 +6,7 @@ Required properties: - interrupts: Should contain the five crypto engines interrupts in numeric order. These are global system and four descriptor rings. - clocks: the clock used by the core -- clock-names: the names of the clock listed in the clocks property. These are - "ethif", "cryp" +- clock-names: Must contain "cryp". - power-domains: Must contain a reference to the PM domain. @@ -20,8 +19,7 @@ Example: <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>, <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>, <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>; - clocks = <&topckgen CLK_TOP_ETHIF_SEL>, - <ðsys CLK_ETHSYS_CRYPTO>; - clock-names = "ethif","cryp"; + clocks = <ðsys CLK_ETHSYS_CRYPTO>; + clock-names = "cryp"; power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; };
This patch removes unnecessary clock in binding file. Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> --- Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)