| Message ID | 20170529202738.2167-13-antoine.tenart@free-electrons.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
On Mon, May 29, 2017 at 10:27:38PM +0200, Antoine Tenart wrote: > Add a node for the cryptographic engine that can be found on sun5i SoCs. > This cryptographic engine is compatible with the Allwinner cryptographic > accelerator driver. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > --- > arch/arm/boot/dts/sun5i.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi > index 5175f9cc9bed..9bfefa2c7224 100644 > --- a/arch/arm/boot/dts/sun5i.dtsi > +++ b/arch/arm/boot/dts/sun5i.dtsi > @@ -355,6 +355,14 @@ > status = "disabled"; > }; > > + crypto: crypto-engine@01c15000 { > + compatible = "allwinner,sun4i-a10-crypto"; you should add a SoC-specific compatible here, just so that if we ever need to fix something in there we don't have to update our DT. Thanks! Maxime
Hi Maxime, On Tue, May 30, 2017 at 08:48:11AM +0200, Maxime Ripard wrote: > On Mon, May 29, 2017 at 10:27:38PM +0200, Antoine Tenart wrote: > > Add a node for the cryptographic engine that can be found on sun5i SoCs. > > This cryptographic engine is compatible with the Allwinner cryptographic > > accelerator driver. > > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > > --- > > arch/arm/boot/dts/sun5i.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi > > index 5175f9cc9bed..9bfefa2c7224 100644 > > --- a/arch/arm/boot/dts/sun5i.dtsi > > +++ b/arch/arm/boot/dts/sun5i.dtsi > > @@ -355,6 +355,14 @@ > > status = "disabled"; > > }; > > > > + crypto: crypto-engine@01c15000 { > > + compatible = "allwinner,sun4i-a10-crypto"; > > you should add a SoC-specific compatible here, just so that if we ever > need to fix something in there we don't have to update our DT. Sure. I'll also make patches for the other sunXi crypto nodes as they do no have SoC-specific compatibles either. Thanks, Antoine
diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi index 5175f9cc9bed..9bfefa2c7224 100644 --- a/arch/arm/boot/dts/sun5i.dtsi +++ b/arch/arm/boot/dts/sun5i.dtsi @@ -355,6 +355,14 @@ status = "disabled"; }; + crypto: crypto-engine@01c15000 { + compatible = "allwinner,sun4i-a10-crypto"; + reg = <0x01c15000 0x1000>; + interrupts = <54>; + clocks = <&ccu CLK_AHB_SS>, <&ccu CLK_SS>; + clock-names = "ahb", "mod"; + }; + spi2: spi@01c17000 { compatible = "allwinner,sun4i-a10-spi"; reg = <0x01c17000 0x1000>;
Add a node for the cryptographic engine that can be found on sun5i SoCs. This cryptographic engine is compatible with the Allwinner cryptographic accelerator driver. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- arch/arm/boot/dts/sun5i.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)