| Message ID | 20170530092224.1204037-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 30, 2017 at 11:22 AM, Arnd Bergmann <arnd@arndb.de> wrote: > When DRM_PANEL is disabled, we get a link error for pl111: > > drivers/gpu/built-in.o: In function `pl111_connector_destroy': > pl111_connector.c:(.text+0x3487e6): undefined reference to `drm_panel_detach' > > For some reason this only appears in the latest linux-next > although the driver appears to have used the symbol for a few > weeks already. The solution however is simple enough, we just > need to add a 'select' statement. > > Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Tested-by: Linus Walleij <linus.walleij@linaro.org> I had the same patch in my tree, just haven't had time to send it out. Yours, Linus Walleij
On Tue, May 30, 2017 at 01:35:51PM +0200, Linus Walleij wrote: > On Tue, May 30, 2017 at 11:22 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > > When DRM_PANEL is disabled, we get a link error for pl111: > > > > drivers/gpu/built-in.o: In function `pl111_connector_destroy': > > pl111_connector.c:(.text+0x3487e6): undefined reference to `drm_panel_detach' > > > > For some reason this only appears in the latest linux-next > > although the driver appears to have used the symbol for a few > > weeks already. The solution however is simple enough, we just > > need to add a 'select' statement. > > > > Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Tested-by: Linus Walleij <linus.walleij@linaro.org> > > I had the same patch in my tree, just haven't had time to send > it out. Eric seems out, so I picked this up for him. Thanks for the patch&testing. -Daniel
diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig index 309f4fd52de7..bbfba87cd1a8 100644 --- a/drivers/gpu/drm/pl111/Kconfig +++ b/drivers/gpu/drm/pl111/Kconfig @@ -6,6 +6,7 @@ config DRM_PL111 select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER + select DRM_PANEL select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE help Choose this option for DRM support for the PL111 CLCD controller.
When DRM_PANEL is disabled, we get a link error for pl111: drivers/gpu/built-in.o: In function `pl111_connector_destroy': pl111_connector.c:(.text+0x3487e6): undefined reference to `drm_panel_detach' For some reason this only appears in the latest linux-next although the driver appears to have used the symbol for a few weeks already. The solution however is simple enough, we just need to add a 'select' statement. Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/pl111/Kconfig | 1 + 1 file changed, 1 insertion(+)