| Message ID | 20170419091326.11226-2-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, Apr 19, 2017 at 11:13:23AM +0200, Linus Walleij wrote: > The concept of "active" clocks is just explained in a bried comment in the > device driver, let's explain it a bit more in the device tree bindings > so everyone understands this. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v1->v2: > - Reword slighty in accordance with Stephens feedback. > --- > Documentation/devicetree/bindings/clock/qcom,rpmcc.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) Despite my objections, you're just documenting what is already there. Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/28, Rob Herring wrote: > On Wed, Apr 19, 2017 at 11:13:23AM +0200, Linus Walleij wrote: > > The concept of "active" clocks is just explained in a bried comment in the > > device driver, let's explain it a bit more in the device tree bindings > > so everyone understands this. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > --- > > ChangeLog v1->v2: > > - Reword slighty in accordance with Stephens feedback. > > --- > > Documentation/devicetree/bindings/clock/qcom,rpmcc.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > Despite my objections, you're just documenting what is already there. > > Acked-by: Rob Herring <robh@kernel.org> Perhaps this can be put into the clk driver instead? Is that the concern?
diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt index d470a0187035..833a89f06ae0 100644 --- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt @@ -18,6 +18,14 @@ Required properties : - #clock-cells : shall contain 1 +The clock enumerators are defined in <dt-bindings/clock/qcom,rpmcc.h> +and come in pairs: FOO_CLK followed by FOO_A_CLK. The latter clock +is an "active" clock, which means that the consumer only care that the +clock is available when the apps CPU subsystem is active, i.e. not +suspended or in deep idle. If it is important that the clock keeps running +during system suspend, you need to specify the non-active clock, the one +not containing *_A_* in the enumerator name. + Example: smd { compatible = "qcom,smd";
The concept of "active" clocks is just explained in a bried comment in the device driver, let's explain it a bit more in the device tree bindings so everyone understands this. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ChangeLog v1->v2: - Reword slighty in accordance with Stephens feedback. --- Documentation/devicetree/bindings/clock/qcom,rpmcc.txt | 8 ++++++++ 1 file changed, 8 insertions(+)