| Message ID | 0f8b6a7b-c1d2-bc95-7970-7572991495cb@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Mon, 5 Jun 2017, Milan P. Gandhi wrote: > Remove the white spaces in do/while loop used for checking fcoe > debug logging Is it converting spaces to tabs? If so, saying that would be clearer. julia > > Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com> > --- > drivers/scsi/fcoe/fcoe.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/fcoe/fcoe.h b/drivers/scsi/fcoe/fcoe.h > index 6aa4820..7406376 100644 > --- a/drivers/scsi/fcoe/fcoe.h > +++ b/drivers/scsi/fcoe/fcoe.h > @@ -46,7 +46,7 @@ extern unsigned int fcoe_debug_logging; > #define FCOE_NETDEV_LOGGING 0x02 /* Netdevice logging */ > > #define FCOE_CHECK_LOGGING(LEVEL, CMD) \ > -do { \ > +do { \ > if (unlikely(fcoe_debug_logging & LEVEL)) \ > do { \ > CMD; \ > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
On 06/05/2017 02:48 PM, Julia Lawall wrote: > > > On Mon, 5 Jun 2017, Milan P. Gandhi wrote: > >> Remove the white spaces in do/while loop used for checking fcoe >> debug logging > > Is it converting spaces to tabs? If so, saying that would be clearer. yeah, it converts the white spaces to tabs. > > julia > >> >> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com> >> --- >> drivers/scsi/fcoe/fcoe.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/fcoe/fcoe.h b/drivers/scsi/fcoe/fcoe.h >> index 6aa4820..7406376 100644 >> --- a/drivers/scsi/fcoe/fcoe.h >> +++ b/drivers/scsi/fcoe/fcoe.h >> @@ -46,7 +46,7 @@ extern unsigned int fcoe_debug_logging; >> #define FCOE_NETDEV_LOGGING 0x02 /* Netdevice logging */ >> >> #define FCOE_CHECK_LOGGING(LEVEL, CMD) \ >> -do { \ >> +do { \ >> if (unlikely(fcoe_debug_logging & LEVEL)) \ >> do { \ >> CMD; \ >> -- >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >>
diff --git a/drivers/scsi/fcoe/fcoe.h b/drivers/scsi/fcoe/fcoe.h index 6aa4820..7406376 100644 --- a/drivers/scsi/fcoe/fcoe.h +++ b/drivers/scsi/fcoe/fcoe.h @@ -46,7 +46,7 @@ extern unsigned int fcoe_debug_logging; #define FCOE_NETDEV_LOGGING 0x02 /* Netdevice logging */ #define FCOE_CHECK_LOGGING(LEVEL, CMD) \ -do { \ +do { \ if (unlikely(fcoe_debug_logging & LEVEL)) \ do { \ CMD; \
Remove the white spaces in do/while loop used for checking fcoe debug logging Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com> --- drivers/scsi/fcoe/fcoe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)