| Message ID | 1496201877-34373-2-git-send-email-xiaolei.li@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 31/05/17 05:37, Xiaolei Li wrote: > Add MT2712 NAND Flash Controller dt bindings documentation. > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- Subject line should be something like; dt-bindings: mtd: Update mediatek bindings. > Documentation/devicetree/bindings/mtd/mtk-nand.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/mtk-nand.txt b/Documentation/devicetree/bindings/mtd/mtk-nand.txt > index 069c192..dbf9e05 100644 > --- a/Documentation/devicetree/bindings/mtd/mtk-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/mtk-nand.txt > @@ -12,7 +12,8 @@ tree nodes. > > The first part of NFC is NAND Controller Interface (NFI) HW. > Required NFI properties: > -- compatible: Should be "mediatek,mtxxxx-nfc". > +- compatible: Should be one of "mediatek,mt2701-nfc", > + "mediatek,mt2712-nfc". > - reg: Base physical address and size of NFI. > - interrupts: Interrupts of NFI. > - clocks: NFI required clocks. > @@ -141,7 +142,7 @@ Example: > ============== > > Required BCH properties: > -- compatible: Should be "mediatek,mtxxxx-ecc". > +- compatible: Should be one of "mediatek,mt2701-ecc", "mediatek,mt2712-ecc". > - reg: Base physical address and size of ECC. > - interrupts: Interrupts of ECC. > - clocks: ECC required clocks. >
Hi Mattias, On Tue, 2017-06-06 at 12:55 +0200, Matthias Brugger wrote: > > On 31/05/17 05:37, Xiaolei Li wrote: > > Add MT2712 NAND Flash Controller dt bindings documentation. > > > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > --- > > Subject line should be something like; > dt-bindings: mtd: Update mediatek bindings. This patch has been accepted on PATCH v5 by Boris. So, should I send PATCH v6? Thanks. > > > Documentation/devicetree/bindings/mtd/mtk-nand.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mtd/mtk-nand.txt b/Documentation/devicetree/bindings/mtd/mtk-nand.txt > > index 069c192..dbf9e05 100644 > > --- a/Documentation/devicetree/bindings/mtd/mtk-nand.txt > > +++ b/Documentation/devicetree/bindings/mtd/mtk-nand.txt > > @@ -12,7 +12,8 @@ tree nodes. > > > > The first part of NFC is NAND Controller Interface (NFI) HW. > > Required NFI properties: > > -- compatible: Should be "mediatek,mtxxxx-nfc". > > +- compatible: Should be one of "mediatek,mt2701-nfc", > > + "mediatek,mt2712-nfc". > > - reg: Base physical address and size of NFI. > > - interrupts: Interrupts of NFI. > > - clocks: NFI required clocks. > > @@ -141,7 +142,7 @@ Example: > > ============== > > > > Required BCH properties: > > -- compatible: Should be "mediatek,mtxxxx-ecc". > > +- compatible: Should be one of "mediatek,mt2701-ecc", "mediatek,mt2712-ecc". > > - reg: Base physical address and size of ECC. > > - interrupts: Interrupts of ECC. > > - clocks: ECC required clocks. > >
On Wed, 7 Jun 2017 15:24:57 +0800 xiaolei li <xiaolei.li@mediatek.com> wrote: > Hi Mattias, > > On Tue, 2017-06-06 at 12:55 +0200, Matthias Brugger wrote: > > > > On 31/05/17 05:37, Xiaolei Li wrote: > > > Add MT2712 NAND Flash Controller dt bindings documentation. > > > > > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > > --- > > > > Subject line should be something like; > > dt-bindings: mtd: Update mediatek bindings. > > This patch has been accepted on PATCH v5 by Boris. So, should I send > PATCH v6? No, I already applied the patch, and it's not such a big deal anyway. Try to use this prefix for you future DT bindings contributions ;-).
On Wed, 2017-06-07 at 09:34 +0200, Boris Brezillon wrote: > On Wed, 7 Jun 2017 15:24:57 +0800 > xiaolei li <xiaolei.li@mediatek.com> wrote: > > > Hi Mattias, > > > > On Tue, 2017-06-06 at 12:55 +0200, Matthias Brugger wrote: > > > > > > On 31/05/17 05:37, Xiaolei Li wrote: > > > > Add MT2712 NAND Flash Controller dt bindings documentation. > > > > > > > > Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com> > > > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > > > --- > > > > > > Subject line should be something like; > > > dt-bindings: mtd: Update mediatek bindings. > > > > This patch has been accepted on PATCH v5 by Boris. So, should I send > > PATCH v6? > > No, I already applied the patch, and it's not such a big deal anyway. > Try to use this prefix for you future DT bindings contributions ;-). OK. Thanks Boris, Matthias.
diff --git a/Documentation/devicetree/bindings/mtd/mtk-nand.txt b/Documentation/devicetree/bindings/mtd/mtk-nand.txt index 069c192..dbf9e05 100644 --- a/Documentation/devicetree/bindings/mtd/mtk-nand.txt +++ b/Documentation/devicetree/bindings/mtd/mtk-nand.txt @@ -12,7 +12,8 @@ tree nodes. The first part of NFC is NAND Controller Interface (NFI) HW. Required NFI properties: -- compatible: Should be "mediatek,mtxxxx-nfc". +- compatible: Should be one of "mediatek,mt2701-nfc", + "mediatek,mt2712-nfc". - reg: Base physical address and size of NFI. - interrupts: Interrupts of NFI. - clocks: NFI required clocks. @@ -141,7 +142,7 @@ Example: ============== Required BCH properties: -- compatible: Should be "mediatek,mtxxxx-ecc". +- compatible: Should be one of "mediatek,mt2701-ecc", "mediatek,mt2712-ecc". - reg: Base physical address and size of ECC. - interrupts: Interrupts of ECC. - clocks: ECC required clocks.