| Message ID | 1496860977-22516-1-git-send-email-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07.06.2017 20:42, Thomas Huth wrote: > When building the kvm-unit-tests for s390x in parallel ("make -j10" > for example), the build sometimes fails since asm-offsets.h has not > been generated yet. The problem is a bad rule in the Makefile: The > test cases are stored in the the "tests" variable, and not in > "test_cases" (which is just an abstract target, not a variable). > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > s390x/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/s390x/Makefile b/s390x/Makefile > index a61e163..470cbba 100644 > --- a/s390x/Makefile > +++ b/s390x/Makefile > @@ -43,4 +43,4 @@ arch_clean: asm_offsets_clean > $(RM) $(TEST_DIR)/*.{o,elf} $(TEST_DIR)/.*.d lib/s390x/.*.d > > generated-files = $(asm-offsets) > -$(test_cases:.elf=.o) $(cstart.o) $(cflatobjs): $(generated-files) > +$(tests:.elf=.o) $(cstart.o) $(cflatobjs): $(generated-files) > Reviewed-by: David Hildenbrand <david@redhat.com>
On 07/06/2017 20:42, Thomas Huth wrote: > When building the kvm-unit-tests for s390x in parallel ("make -j10" > for example), the build sometimes fails since asm-offsets.h has not > been generated yet. The problem is a bad rule in the Makefile: The > test cases are stored in the the "tests" variable, and not in > "test_cases" (which is just an abstract target, not a variable). > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > s390x/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/s390x/Makefile b/s390x/Makefile > index a61e163..470cbba 100644 > --- a/s390x/Makefile > +++ b/s390x/Makefile > @@ -43,4 +43,4 @@ arch_clean: asm_offsets_clean > $(RM) $(TEST_DIR)/*.{o,elf} $(TEST_DIR)/.*.d lib/s390x/.*.d > > generated-files = $(asm-offsets) > -$(test_cases:.elf=.o) $(cstart.o) $(cflatobjs): $(generated-files) > +$(tests:.elf=.o) $(cstart.o) $(cflatobjs): $(generated-files) > Applied, thanks. Paolo
diff --git a/s390x/Makefile b/s390x/Makefile index a61e163..470cbba 100644 --- a/s390x/Makefile +++ b/s390x/Makefile @@ -43,4 +43,4 @@ arch_clean: asm_offsets_clean $(RM) $(TEST_DIR)/*.{o,elf} $(TEST_DIR)/.*.d lib/s390x/.*.d generated-files = $(asm-offsets) -$(test_cases:.elf=.o) $(cstart.o) $(cflatobjs): $(generated-files) +$(tests:.elf=.o) $(cstart.o) $(cflatobjs): $(generated-files)
When building the kvm-unit-tests for s390x in parallel ("make -j10" for example), the build sometimes fails since asm-offsets.h has not been generated yet. The problem is a bad rule in the Makefile: The test cases are stored in the the "tests" variable, and not in "test_cases" (which is just an abstract target, not a variable). Signed-off-by: Thomas Huth <thuth@redhat.com> --- s390x/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)