| Message ID | 20170521094447.m4thpavivflyqtf6@pd.tnic (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-05-21 18:44 GMT+09:00 Borislav Petkov <bp@alien8.de>: > On Sun, May 21, 2017 at 06:15:53PM +0900, Masahiro Yamada wrote: >> Could you change line 199 >> >> $(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog >> >> to >> >> $(addprefix $(obj)/, mconf.o $(lxdialog)): $(obj)/dochecklxdialog >> >> and send v2, please? > > Here it is: > > --- > From: Borislav Petkov <bp@suse.de> > Date: Sun, 9 Apr 2017 15:07:08 +0200 > Subject: [PATCH v2] kconfig: Check for libncurses before menuconfig > > There is a check and a nice user-friendly message when the curses > library is not present on the system and the user wants to do "make > menuconfig". It doesn't get issued, though. Instead, we fail the build > when mconf.c doesn't find the curses.h header: > > HOSTCC scripts/kconfig/mconf.o > In file included from scripts/kconfig/mconf.c:23:0: > scripts/kconfig/lxdialog/dialog.h:38:20: fatal error: curses.h: No such file or directory > #include CURSES_LOC > ^ > compilation terminated. > > Make sure dochecklxdialog gets run before mconf is compiled so that the > user sees the error message instead: > > $ make menuconfig > *** Unable to find the ncurses libraries or the > *** required header files. > *** 'make menuconfig' requires the ncurses libraries. > *** > *** Install ncurses (ncurses-devel) and try again. > *** > scripts/kconfig/Makefile:203: recipe for target 'scripts/kconfig/dochecklxdialog' failed > make[1]: *** [scripts/kconfig/dochecklxdialog] Error 1 > Makefile:548: recipe for target 'menuconfig' failed > make: *** [menuconfig] Error 2 > > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: linux-kbuild@vger.kernel.org > Link: http://lkml.kernel.org/r/20170409130708.4753-1-bp@alien8.de > --- > scripts/kconfig/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > index 90a091b6ae4d..eb8144643b78 100644 > --- a/scripts/kconfig/Makefile > +++ b/scripts/kconfig/Makefile > @@ -196,7 +196,7 @@ clean-files += config.pot linux.pot > > # Check that we have the required ncurses stuff installed for lxdialog (menuconfig) > PHONY += $(obj)/dochecklxdialog > -$(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog > +$(addprefix $(obj)/, mconf.o $(lxdialog)): $(obj)/dochecklxdialog > $(obj)/dochecklxdialog: > $(Q)$(CONFIG_SHELL) $(check-lxdialog) -check $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTLOADLIBES_mconf) > Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> I will pick it up for v4.13 if it is not applied via kconfig. I still will somebody can maintain the kconfig subsystem, though.
2017-05-21 18:44 GMT+09:00 Borislav Petkov <bp@alien8.de>: > On Sun, May 21, 2017 at 06:15:53PM +0900, Masahiro Yamada wrote: >> Could you change line 199 >> >> $(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog >> >> to >> >> $(addprefix $(obj)/, mconf.o $(lxdialog)): $(obj)/dochecklxdialog >> >> and send v2, please? > > Here it is: > > --- > From: Borislav Petkov <bp@suse.de> > Date: Sun, 9 Apr 2017 15:07:08 +0200 > Subject: [PATCH v2] kconfig: Check for libncurses before menuconfig > > There is a check and a nice user-friendly message when the curses > library is not present on the system and the user wants to do "make > menuconfig". It doesn't get issued, though. Instead, we fail the build > when mconf.c doesn't find the curses.h header: > > HOSTCC scripts/kconfig/mconf.o > In file included from scripts/kconfig/mconf.c:23:0: > scripts/kconfig/lxdialog/dialog.h:38:20: fatal error: curses.h: No such file or directory > #include CURSES_LOC > ^ > compilation terminated. > > Make sure dochecklxdialog gets run before mconf is compiled so that the > user sees the error message instead: > > $ make menuconfig > *** Unable to find the ncurses libraries or the > *** required header files. > *** 'make menuconfig' requires the ncurses libraries. > *** > *** Install ncurses (ncurses-devel) and try again. > *** > scripts/kconfig/Makefile:203: recipe for target 'scripts/kconfig/dochecklxdialog' failed > make[1]: *** [scripts/kconfig/dochecklxdialog] Error 1 > Makefile:548: recipe for target 'menuconfig' failed > make: *** [menuconfig] Error 2 > > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: linux-kbuild@vger.kernel.org > Link: http://lkml.kernel.org/r/20170409130708.4753-1-bp@alien8.de > --- Applied to linux-kbuild/fixes. Thanks!
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index 90a091b6ae4d..eb8144643b78 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -196,7 +196,7 @@ clean-files += config.pot linux.pot # Check that we have the required ncurses stuff installed for lxdialog (menuconfig) PHONY += $(obj)/dochecklxdialog -$(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog +$(addprefix $(obj)/, mconf.o $(lxdialog)): $(obj)/dochecklxdialog $(obj)/dochecklxdialog: $(Q)$(CONFIG_SHELL) $(check-lxdialog) -check $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTLOADLIBES_mconf)