| Message ID | 20170602101024.18940-20-wens@csie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Jun 3, 2017 at 3:42 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Fri, Jun 02, 2017 at 06:10:24PM +0800, Chen-Yu Tsai wrote: >> The MSI Primo81 tablet has a micro HDMI connector at the bottom. >> This is connected to the SoCs HDMI output. >> >> Enable the display pipeline and the HDMI output. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun6i-a31s-primo81.dts | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts >> index f3712753fa42..26154b2f87a3 100644 >> --- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts >> +++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts >> @@ -52,17 +52,42 @@ >> / { >> model = "MSI Primo81 tablet"; >> compatible = "msi,primo81", "allwinner,sun6i-a31s"; >> + >> + hdmi-connector { >> + compatible = "hdmi-connector"; >> + type = "c"; > > Should we add a connector type for this one? To be honest I don't know. DRM has HDMI-B to differentiate dual-link connections, but that is only used by Intel and AMD GPU drivers. AMD driver has "/* HDMI-B is basically DL-DVI; analog works fine */", which makes sense since actual HDMI B-type connectors only exist on paper. None of the other drivers seem to care. ChenYu
On Fri, Jun 02, 2017 at 09:42:19PM +0200, Maxime Ripard wrote: > On Fri, Jun 02, 2017 at 06:10:24PM +0800, Chen-Yu Tsai wrote: > > The MSI Primo81 tablet has a micro HDMI connector at the bottom. > > This is connected to the SoCs HDMI output. > > > > Enable the display pipeline and the HDMI output. > > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm/boot/dts/sun6i-a31s-primo81.dts | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts > > index f3712753fa42..26154b2f87a3 100644 > > --- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts > > +++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts > > @@ -52,17 +52,42 @@ > > / { > > model = "MSI Primo81 tablet"; > > compatible = "msi,primo81", "allwinner,sun6i-a31s"; > > + > > + hdmi-connector { > > + compatible = "hdmi-connector"; > > + type = "c"; > > Should we add a connector type for this one? c as in USB Type C? I'd prefer to see a new compatible string. Is type even documented? Rob
On Wed, Jun 7, 2017 at 6:36 PM, Rob Herring <robh@kernel.org> wrote: > On Fri, Jun 02, 2017 at 09:42:19PM +0200, Maxime Ripard wrote: >> On Fri, Jun 02, 2017 at 06:10:24PM +0800, Chen-Yu Tsai wrote: >> > The MSI Primo81 tablet has a micro HDMI connector at the bottom. >> > This is connected to the SoCs HDMI output. >> > >> > Enable the display pipeline and the HDMI output. >> > >> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> > --- >> > arch/arm/boot/dts/sun6i-a31s-primo81.dts | 25 +++++++++++++++++++++++++ >> > 1 file changed, 25 insertions(+) >> > >> > diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts >> > index f3712753fa42..26154b2f87a3 100644 >> > --- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts >> > +++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts >> > @@ -52,17 +52,42 @@ >> > / { >> > model = "MSI Primo81 tablet"; >> > compatible = "msi,primo81", "allwinner,sun6i-a31s"; >> > + >> > + hdmi-connector { >> > + compatible = "hdmi-connector"; >> > + type = "c"; >> >> Should we add a connector type for this one? > > c as in USB Type C? I'd prefer to see a new compatible string. Is type > even documented? Probably as in HDMI Type C (there are Type A, C, and D connectors, aka "regular", "mini", and "micro").
On Thu, Jun 8, 2017 at 6:47 AM, Ilia Mirkin <imirkin@alum.mit.edu> wrote: > On Wed, Jun 7, 2017 at 6:36 PM, Rob Herring <robh@kernel.org> wrote: >> On Fri, Jun 02, 2017 at 09:42:19PM +0200, Maxime Ripard wrote: >>> On Fri, Jun 02, 2017 at 06:10:24PM +0800, Chen-Yu Tsai wrote: >>> > The MSI Primo81 tablet has a micro HDMI connector at the bottom. >>> > This is connected to the SoCs HDMI output. >>> > >>> > Enable the display pipeline and the HDMI output. >>> > >>> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> >>> > --- >>> > arch/arm/boot/dts/sun6i-a31s-primo81.dts | 25 +++++++++++++++++++++++++ >>> > 1 file changed, 25 insertions(+) >>> > >>> > diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts >>> > index f3712753fa42..26154b2f87a3 100644 >>> > --- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts >>> > +++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts >>> > @@ -52,17 +52,42 @@ >>> > / { >>> > model = "MSI Primo81 tablet"; >>> > compatible = "msi,primo81", "allwinner,sun6i-a31s"; >>> > + >>> > + hdmi-connector { >>> > + compatible = "hdmi-connector"; >>> > + type = "c"; >>> >>> Should we add a connector type for this one? >> >> c as in USB Type C? I'd prefer to see a new compatible string. Is type >> even documented? Indeed it is: http://elixir.free-electrons.com/linux/latest/source/Documentation/devicetree/bindings/display/connector/hdmi-connector.txt#L6 > Probably as in HDMI Type C (there are Type A, C, and D connectors, aka > "regular", "mini", and "micro"). Correct. ChenYu
On Fri, Jun 9, 2017 at 11:08 AM, Chen-Yu Tsai <wens@csie.org> wrote: > On Thu, Jun 8, 2017 at 6:47 AM, Ilia Mirkin <imirkin@alum.mit.edu> wrote: >> On Wed, Jun 7, 2017 at 6:36 PM, Rob Herring <robh@kernel.org> wrote: >>> On Fri, Jun 02, 2017 at 09:42:19PM +0200, Maxime Ripard wrote: >>>> On Fri, Jun 02, 2017 at 06:10:24PM +0800, Chen-Yu Tsai wrote: >>>> > The MSI Primo81 tablet has a micro HDMI connector at the bottom. >>>> > This is connected to the SoCs HDMI output. >>>> > >>>> > Enable the display pipeline and the HDMI output. >>>> > >>>> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> >>>> > --- >>>> > arch/arm/boot/dts/sun6i-a31s-primo81.dts | 25 +++++++++++++++++++++++++ >>>> > 1 file changed, 25 insertions(+) >>>> > >>>> > diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts >>>> > index f3712753fa42..26154b2f87a3 100644 >>>> > --- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts >>>> > +++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts >>>> > @@ -52,17 +52,42 @@ >>>> > / { >>>> > model = "MSI Primo81 tablet"; >>>> > compatible = "msi,primo81", "allwinner,sun6i-a31s"; >>>> > + >>>> > + hdmi-connector { >>>> > + compatible = "hdmi-connector"; >>>> > + type = "c"; >>>> >>>> Should we add a connector type for this one? >>> >>> c as in USB Type C? I'd prefer to see a new compatible string. Is type >>> even documented? > > Indeed it is: > > http://elixir.free-electrons.com/linux/latest/source/Documentation/devicetree/bindings/display/connector/hdmi-connector.txt#L6 -ETOOMANYBINDINGS I guess I don't understand the original question then. This looks fine to me. Rob
diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts index f3712753fa42..26154b2f87a3 100644 --- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts +++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts @@ -52,17 +52,42 @@ / { model = "MSI Primo81 tablet"; compatible = "msi,primo81", "allwinner,sun6i-a31s"; + + hdmi-connector { + compatible = "hdmi-connector"; + type = "c"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <&hdmi_out_con>; + }; + }; + }; }; &cpu0 { cpu-supply = <®_dcdc3>; }; +&de { + status = "okay"; +}; + &ehci0 { /* rtl8188etv wifi is connected here */ status = "okay"; }; +&hdmi { + status = "okay"; +}; + +&hdmi_out { + hdmi_out_con: endpoint { + remote-endpoint = <&hdmi_con_in>; + }; +}; + &i2c0 { /* pull-ups and device VDDIO use AXP221 DLDO3 */ pinctrl-names = "default";
The MSI Primo81 tablet has a micro HDMI connector at the bottom. This is connected to the SoCs HDMI output. Enable the display pipeline and the HDMI output. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun6i-a31s-primo81.dts | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)