diff mbox

[v4,2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

Message ID 7d4b2333912ad23e62dbb8cc3792ad70e9cc1702.1497313626.git-series.kieran.bingham+renesas@ideasonboard.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kieran Bingham June 13, 2017, 12:35 a.m. UTC
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Provide ADV7482, and the needed connectors

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

v4:
 - dt: Rebase to dts/renesas/salvator-x.dtsi
 - dt: Use AIN0-7 rather than AIN1-8

 arch/arm64/boot/dts/renesas/salvator-x.dtsi | 123 +++++++++++++++++++++-
 1 file changed, 123 insertions(+)

Comments

Simon Horman June 14, 2017, 9:04 a.m. UTC | #1
On Tue, Jun 13, 2017 at 01:35:08AM +0100, Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> Provide ADV7482, and the needed connectors
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

I am marking this as deferred pending acceptance of the bindings.
Kieran Bingham June 14, 2017, 9:11 a.m. UTC | #2
Hi Simon,

On 14/06/17 10:04, Simon Horman wrote:
> On Tue, Jun 13, 2017 at 01:35:08AM +0100, Kieran Bingham wrote:
>> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>
>> Provide ADV7482, and the needed connectors
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> I am marking this as deferred pending acceptance of the bindings.

Good point - I didn't include RobH / DT-relevant lists on the mailing :)
If only there was a script called get_maintainer.pl to remind me who to include :D

Thanks for the heads up.
I'll aim to send out a v5 today and include the required lists.

--
Kieran
Geert Uytterhoeven June 14, 2017, 9:39 a.m. UTC | #3
Hi Kieran,

On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham <kbingham@kernel.org> wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Provide ADV7482, and the needed connectors
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Thanks for your patch!

> v4:
>  - dt: Rebase to dts/renesas/salvator-x.dtsi
>  - dt: Use AIN0-7 rather than AIN1-8
>
>  arch/arm64/boot/dts/renesas/salvator-x.dtsi | 123 +++++++++++++++++++++-

I believe all of this applies to both Salvator-X and Salvator-XS?

Hence it should be applied to salvator-common.dtsi instead of salvator-x.dtsi.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Kieran Bingham June 14, 2017, 9:43 a.m. UTC | #4
Hi Geert,

On 14/06/17 10:39, Geert Uytterhoeven wrote:
> Hi Kieran,
> 
> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham <kbingham@kernel.org> wrote:
>> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>
>> Provide ADV7482, and the needed connectors
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> Thanks for your patch!
> 
>> v4:
>>  - dt: Rebase to dts/renesas/salvator-x.dtsi
>>  - dt: Use AIN0-7 rather than AIN1-8
>>
>>  arch/arm64/boot/dts/renesas/salvator-x.dtsi | 123 +++++++++++++++++++++-
> 
> I believe all of this applies to both Salvator-X and Salvator-XS?
> 
> Hence it should be applied to salvator-common.dtsi instead of salvator-x.dtsi.

Hrm ... I don't have a salator-common.dtsi ... I'll need a new rebase.

But it sounds logical :)

--
Thanks

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>
Geert Uytterhoeven June 14, 2017, 11:33 a.m. UTC | #5
Hi Kieran,

On Wed, Jun 14, 2017 at 11:43 AM, Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> On 14/06/17 10:39, Geert Uytterhoeven wrote:
>> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham <kbingham@kernel.org> wrote:
>>> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>>
>>> Provide ADV7482, and the needed connectors
>>>
>>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>
>> Thanks for your patch!
>>
>>> v4:
>>>  - dt: Rebase to dts/renesas/salvator-x.dtsi
>>>  - dt: Use AIN0-7 rather than AIN1-8
>>>
>>>  arch/arm64/boot/dts/renesas/salvator-x.dtsi | 123 +++++++++++++++++++++-
>>
>> I believe all of this applies to both Salvator-X and Salvator-XS?
>>
>> Hence it should be applied to salvator-common.dtsi instead of salvator-x.dtsi.
>
> Hrm ... I don't have a salator-common.dtsi ... I'll need a new rebase.

It's always a good idea to base your Renesas DT patches on Simon's latest
devel branch.

> But it sounds logical :)

Good :-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/salvator-x.dtsi b/arch/arm64/boot/dts/renesas/salvator-x.dtsi
index 937bdf8842f2..c073baf6aeb7 100644
--- a/arch/arm64/boot/dts/renesas/salvator-x.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-x.dtsi
@@ -68,6 +68,16 @@ 
 		enable-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>;
 	};
 
+	cvbs-in {
+		compatible = "composite-video-connector";
+		label = "CVBS IN";
+
+		port {
+			cvbs_con: endpoint {
+			};
+		};
+	};
+
 	reg_1p8v: regulator0 {
 		compatible = "regulator-fixed";
 		regulator-name = "fixed-1.8V";
@@ -183,6 +193,17 @@ 
 		};
 	};
 
+	hdmi-in {
+		compatible = "hdmi-connector";
+		label = "HDMI IN";
+		type = "a";
+
+		port {
+			hdmi_in_con: endpoint {
+			};
+		};
+	};
+
 	vga {
 		compatible = "vga-connector";
 
@@ -260,6 +281,51 @@ 
 	};
 };
 
+&csi20 {
+	status = "okay";
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			csi20_in: endpoint {
+				clock-lanes = <0>;
+				data-lanes = <1>;
+				remote-endpoint = <&adv7482_txb>;
+			};
+		};
+	};
+};
+
+&csi40 {
+	status = "okay";
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+
+			csi40_in: endpoint {
+				clock-lanes = <0>;
+				data-lanes = <1 2 3 4>;
+				remote-endpoint = <&adv7482_txa>;
+			};
+		};
+	};
+};
+
+&cvbs_con {
+	port {
+		cvbs_in: endpoint {
+			remote-endpoint = <&adv7482_ain7>;
+		};
+	};
+};
+
 &du {
 	pinctrl-0 = <&du_pins>;
 	pinctrl-names = "default";
@@ -294,6 +360,14 @@ 
 	clock-frequency = <32768>;
 };
 
+&hdmi_in_con {
+	port {
+		hdmi_in: endpoint {
+			remote-endpoint = <&adv7482_hdmi>;
+		};
+	};
+};
+
 &hsusb {
 	status = "okay";
 };
@@ -358,6 +432,55 @@ 
 
 		shunt-resistor-micro-ohms = <5000>;
 	};
+
+	video-receiver@70 {
+		compatible = "adi,adv7482";
+		reg = <0x70>;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		interrupt-parent = <&gpio6>;
+		interrupt-names = "intrq1", "intrq2";
+		interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
+			     <31 IRQ_TYPE_LEVEL_LOW>;
+
+		port@7 {
+			reg = <7>;
+
+			adv7482_ain7: endpoint {
+				remote-endpoint = <&cvbs_in>;
+			};
+		};
+
+		port@8 {
+			reg = <8>;
+
+			adv7482_hdmi: endpoint {
+				remote-endpoint = <&hdmi_in>;
+			};
+		};
+
+		port@10 {
+			reg = <10>;
+
+			adv7482_txa: endpoint {
+				clock-lanes = <0>;
+				data-lanes = <1 2 3 4>;
+				remote-endpoint = <&csi40_in>;
+			};
+		};
+
+		port@11 {
+			reg = <11>;
+
+			adv7482_txb: endpoint {
+				clock-lanes = <0>;
+				data-lanes = <1>;
+				remote-endpoint = <&csi20_in>;
+			};
+		};
+	};
 };
 
 &i2c_dvfs {