| Message ID | 20170613202517.26558-1-alexandre.belloni@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 13/06/2017 22:25, Alexandre Belloni wrote: > Now that AVR32 is gone, the specific wrappers for that architecture are > unnecessary and will not be compiled anymore. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Acked-by: Richard Genoud <richard.genoud@gmail.com>
On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: > Now that AVR32 is gone, the specific wrappers for that architecture are > unnecessary and will not be compiled anymore. > Can you rebase this on top of tty-next? I'm pretty sure this patch will gone. > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > drivers/tty/serial/atmel_serial.c | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 937d67f22fba..8bfc566df2da 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -228,21 +228,6 @@ static inline void atmel_uart_writel(struct uart_port *port, u32 reg, u32 value) > __raw_writel(value, port->membase + reg); > } > > -#ifdef CONFIG_AVR32 > - > -/* AVR32 cannot handle 8 or 16bit I/O accesses but only 32bit I/O accesses */ > -static inline u8 atmel_uart_read_char(struct uart_port *port) > -{ > - return __raw_readl(port->membase + ATMEL_US_RHR); > -} > - > -static inline void atmel_uart_write_char(struct uart_port *port, u8 value) > -{ > - __raw_writel(value, port->membase + ATMEL_US_THR); > -} > - > -#else > - > static inline u8 atmel_uart_read_char(struct uart_port *port) > { > return __raw_readb(port->membase + ATMEL_US_RHR); > @@ -253,8 +238,6 @@ static inline void atmel_uart_write_char(struct uart_port *port, u8 value) > __raw_writeb(value, port->membase + ATMEL_US_THR); > } > > -#endif > - > #ifdef CONFIG_SERIAL_ATMEL_PDC > static bool atmel_use_pdc_rx(struct uart_port *port) > { > -- > 2.11.0 >
On Tue, Jun 13, 2017 at 10:25:17PM +0200, Alexandre Belloni wrote: > Now that AVR32 is gone, the specific wrappers for that architecture are > unnecessary and will not be compiled anymore. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > drivers/tty/serial/atmel_serial.c | 17 ----------------- > 1 file changed, 17 deletions(-) Does not apply to my tty-next tree at all :(
On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote: > On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni > <alexandre.belloni@free-electrons.com> wrote: > > Now that AVR32 is gone, the specific wrappers for that architecture are > > unnecessary and will not be compiled anymore. > > > > Can you rebase this on top of tty-next? > > I'm pretty sure this patch will gone. > So you avoided most of the bikeshedding by not copying any of the maintainers, nice...
On 14/06/2017 at 12:49:29 +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 13, 2017 at 10:25:17PM +0200, Alexandre Belloni wrote: > > Now that AVR32 is gone, the specific wrappers for that architecture are > > unnecessary and will not be compiled anymore. > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > --- > > drivers/tty/serial/atmel_serial.c | 17 ----------------- > > 1 file changed, 17 deletions(-) > > Does not apply to my tty-next tree at all :( > That's fine, as Andy pointed out, he did the job.
On Wed, Jun 14, 2017 at 4:27 PM, Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: > On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote: >> On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni >> <alexandre.belloni@free-electrons.com> wrote: >> > Now that AVR32 is gone, the specific wrappers for that architecture are >> > unnecessary and will not be compiled anymore. >> > >> >> Can you rebase this on top of tty-next? >> >> I'm pretty sure this patch will gone. >> > > So you avoided most of the bikeshedding by not copying any of the > maintainers, nice... Wait, what? I used get_maintainer.pl script and I took its output + Greg.
On 14/06/2017 at 17:15:32 +0300, Andy Shevchenko wrote: > On Wed, Jun 14, 2017 at 4:27 PM, Alexandre Belloni > <alexandre.belloni@free-electrons.com> wrote: > > On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote: > >> On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni > >> <alexandre.belloni@free-electrons.com> wrote: > >> > Now that AVR32 is gone, the specific wrappers for that architecture are > >> > unnecessary and will not be compiled anymore. > >> > > >> > >> Can you rebase this on top of tty-next? > >> > >> I'm pretty sure this patch will gone. > >> > > > > So you avoided most of the bikeshedding by not copying any of the > > maintainers, nice... > > Wait, what? I used get_maintainer.pl script and I took its output + Greg. > Yeah, get_maintainer is not ideal but that's fine. Probably the lakml should be added.
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 937d67f22fba..8bfc566df2da 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c @@ -228,21 +228,6 @@ static inline void atmel_uart_writel(struct uart_port *port, u32 reg, u32 value) __raw_writel(value, port->membase + reg); } -#ifdef CONFIG_AVR32 - -/* AVR32 cannot handle 8 or 16bit I/O accesses but only 32bit I/O accesses */ -static inline u8 atmel_uart_read_char(struct uart_port *port) -{ - return __raw_readl(port->membase + ATMEL_US_RHR); -} - -static inline void atmel_uart_write_char(struct uart_port *port, u8 value) -{ - __raw_writel(value, port->membase + ATMEL_US_THR); -} - -#else - static inline u8 atmel_uart_read_char(struct uart_port *port) { return __raw_readb(port->membase + ATMEL_US_RHR); @@ -253,8 +238,6 @@ static inline void atmel_uart_write_char(struct uart_port *port, u8 value) __raw_writeb(value, port->membase + ATMEL_US_THR); } -#endif - #ifdef CONFIG_SERIAL_ATMEL_PDC static bool atmel_use_pdc_rx(struct uart_port *port) {
Now that AVR32 is gone, the specific wrappers for that architecture are unnecessary and will not be compiled anymore. Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> --- drivers/tty/serial/atmel_serial.c | 17 ----------------- 1 file changed, 17 deletions(-)