| Message ID | 1497619944-61410-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hello! On 06/16/2017 04:32 PM, Biju Das wrote: > Renesas RZ/G1M (R8A7743 SoC) GPIO blocks are identical to the R-Car Gen2 SoC should be outside the parens. > family. Add support for its GPIO controllers. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > --- > Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 + > drivers/gpio/gpio-rcar.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > index 7c1ab3b..1cc3cfe 100644 > --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > @@ -3,6 +3,7 @@ > Required Properties: > > - compatible: should contain one of the following. > + - "renesas,gpio-r8a7743": for R8A7743 (RZ-G1M) compatible GPIO controller. Not RZ/G1M? [...] MBR, Sergei
> Subject: Re: [PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support > > Hello! > > On 06/16/2017 04:32 PM, Biju Das wrote: > > > Renesas RZ/G1M (R8A7743 SoC) GPIO blocks are identical to the R-Car > Gen2 > > SoC should be outside the parens. Thanks. I will correct it. > > > family. Add support for its GPIO controllers. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > --- > > Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 + > > drivers/gpio/gpio-rcar.c | 4 ++++ > > 2 files changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > > index 7c1ab3b..1cc3cfe 100644 > > --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > > +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > > @@ -3,6 +3,7 @@ > > Required Properties: > > > > - compatible: should contain one of the following. > > + - "renesas,gpio-r8a7743": for R8A7743 (RZ-G1M) compatible GPIO > controller. > > Not RZ/G1M? I will change this to RZ/G1M and will push V2. Regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt index 7c1ab3b..1cc3cfe 100644 --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt @@ -3,6 +3,7 @@ Required Properties: - compatible: should contain one of the following. + - "renesas,gpio-r8a7743": for R8A7743 (RZ-G1M) compatible GPIO controller. - "renesas,gpio-r8a7778": for R8A7778 (R-Mobile M1) compatible GPIO controller. - "renesas,gpio-r8a7779": for R8A7779 (R-Car H1) compatible GPIO controller. - "renesas,gpio-r8a7790": for R8A7790 (R-Car H2) compatible GPIO controller. diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 31ad288..4a1536a 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -344,6 +344,10 @@ struct gpio_rcar_info { static const struct of_device_id gpio_rcar_of_table[] = { { + .compatible = "renesas,gpio-r8a7743", + /* RZ/G1 GPIO is identical to R-Car Gen2. */ + .data = &gpio_rcar_info_gen2, + }, { .compatible = "renesas,gpio-r8a7790", .data = &gpio_rcar_info_gen2, }, {