| Message ID | 20170619165753.25049-9-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jun 19, 2017 at 05:57:45PM +0100, Julien Grall wrote: > The file xen/arch/arm/livepatch.c is using typesafe MFN in most of > the place. The only caller to virt_to_mfn is using with _mfn(...). > > To avoid extra _mfn(...), re-define virt_to_mfn within > xen/arch/arm/livepatch.c to handle typesafe MFN. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > > Cc: Ross Lagerwall <ross.lagerwall@citrix.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > Changes in v2: > - Add Stefano's reviewed-by > - Still missing an ack from Konrad and/or Ross. > --- > xen/arch/arm/livepatch.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c > index de95e54744..3e53524365 100644 > --- a/xen/arch/arm/livepatch.c > +++ b/xen/arch/arm/livepatch.c > @@ -12,6 +12,10 @@ > #include <asm/livepatch.h> > #include <asm/mm.h> > > +/* Override macros from asm/page.h to make them work with mfn_t */ > +#undef virt_to_mfn > +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) > + > void *vmap_of_xen_text; > > int arch_livepatch_quiesce(void) > @@ -22,7 +26,7 @@ int arch_livepatch_quiesce(void) > if ( vmap_of_xen_text ) > return -EINVAL; > > - text_mfn = _mfn(virt_to_mfn(_start)); > + text_mfn = virt_to_mfn(_start); > text_order = get_order_from_bytes(_end - _start); > > /* > -- > 2.11.0 >
diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c index de95e54744..3e53524365 100644 --- a/xen/arch/arm/livepatch.c +++ b/xen/arch/arm/livepatch.c @@ -12,6 +12,10 @@ #include <asm/livepatch.h> #include <asm/mm.h> +/* Override macros from asm/page.h to make them work with mfn_t */ +#undef virt_to_mfn +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) + void *vmap_of_xen_text; int arch_livepatch_quiesce(void) @@ -22,7 +26,7 @@ int arch_livepatch_quiesce(void) if ( vmap_of_xen_text ) return -EINVAL; - text_mfn = _mfn(virt_to_mfn(_start)); + text_mfn = virt_to_mfn(_start); text_order = get_order_from_bytes(_end - _start); /*