| Message ID | 20170616193427.13955-2-jlayton@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 16, 2017 at 03:34:06PM -0400, Jeff Layton wrote: > Requested-by: Christoph Hellwig <hch@infradead.org> > Signed-off-by: Jeff Layton <jlayton@redhat.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
On Fri 16-06-17 15:34:06, Jeff Layton wrote: > Requested-by: Christoph Hellwig <hch@infradead.org> > Signed-off-by: Jeff Layton <jlayton@redhat.com> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/sync.c | 2 +- > include/linux/fs.h | 6 ------ > ipc/shm.c | 2 +- > 3 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/fs/sync.c b/fs/sync.c > index 11ba023434b1..2a54c1f22035 100644 > --- a/fs/sync.c > +++ b/fs/sync.c > @@ -192,7 +192,7 @@ int vfs_fsync_range(struct file *file, loff_t start, loff_t end, int datasync) > spin_unlock(&inode->i_lock); > mark_inode_dirty_sync(inode); > } > - return call_fsync(file, start, end, datasync); > + return file->f_op->fsync(file, start, end, datasync); > } > EXPORT_SYMBOL(vfs_fsync_range); > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 4929a8f28cc3..1a135274b4f8 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1740,12 +1740,6 @@ static inline int call_mmap(struct file *file, struct vm_area_struct *vma) > return file->f_op->mmap(file, vma); > } > > -static inline int call_fsync(struct file *file, loff_t start, loff_t end, > - int datasync) > -{ > - return file->f_op->fsync(file, start, end, datasync); > -} > - > ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector, > unsigned long nr_segs, unsigned long fast_segs, > struct iovec *fast_pointer, > diff --git a/ipc/shm.c b/ipc/shm.c > index ec5688e98f25..28a444861a8f 100644 > --- a/ipc/shm.c > +++ b/ipc/shm.c > @@ -453,7 +453,7 @@ static int shm_fsync(struct file *file, loff_t start, loff_t end, int datasync) > > if (!sfd->file->f_op->fsync) > return -EINVAL; > - return call_fsync(sfd->file, start, end, datasync); > + return sfd->file->f_op->fsync(sfd->file, start, end, datasync); > } > > static long shm_fallocate(struct file *file, int mode, loff_t offset, > -- > 2.13.0 >
On Fri, Jun 16, 2017 at 03:34:06PM -0400, Jeff Layton wrote: > Requested-by: Christoph Hellwig <hch@infradead.org> > Signed-off-by: Jeff Layton <jlayton@redhat.com> > --- > fs/sync.c | 2 +- > include/linux/fs.h | 6 ------ > ipc/shm.c | 2 +- > 3 files changed, 2 insertions(+), 8 deletions(-) > > 2.13.0 If it's worth to have one more reviewer, you can add: Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> >
diff --git a/fs/sync.c b/fs/sync.c index 11ba023434b1..2a54c1f22035 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -192,7 +192,7 @@ int vfs_fsync_range(struct file *file, loff_t start, loff_t end, int datasync) spin_unlock(&inode->i_lock); mark_inode_dirty_sync(inode); } - return call_fsync(file, start, end, datasync); + return file->f_op->fsync(file, start, end, datasync); } EXPORT_SYMBOL(vfs_fsync_range); diff --git a/include/linux/fs.h b/include/linux/fs.h index 4929a8f28cc3..1a135274b4f8 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1740,12 +1740,6 @@ static inline int call_mmap(struct file *file, struct vm_area_struct *vma) return file->f_op->mmap(file, vma); } -static inline int call_fsync(struct file *file, loff_t start, loff_t end, - int datasync) -{ - return file->f_op->fsync(file, start, end, datasync); -} - ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector, unsigned long nr_segs, unsigned long fast_segs, struct iovec *fast_pointer, diff --git a/ipc/shm.c b/ipc/shm.c index ec5688e98f25..28a444861a8f 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -453,7 +453,7 @@ static int shm_fsync(struct file *file, loff_t start, loff_t end, int datasync) if (!sfd->file->f_op->fsync) return -EINVAL; - return call_fsync(sfd->file, start, end, datasync); + return sfd->file->f_op->fsync(sfd->file, start, end, datasync); } static long shm_fallocate(struct file *file, int mode, loff_t offset,
Requested-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/sync.c | 2 +- include/linux/fs.h | 6 ------ ipc/shm.c | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-)