| Message ID | 1497986735-14418-12-git-send-email-peda@axentia.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Peter,
[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20170621]
[cannot apply to v4.12-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Peter-Rosin/improve-the-fb_setcmap-helper/20170621-205441
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
>> drivers/gpu//drm/armada/armada_fbdev.c:121:2: error: unknown field 'gamma_set' specified in initializer
.gamma_set = armada_drm_crtc_gamma_set,
^
>> drivers/gpu//drm/armada/armada_fbdev.c:121:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.gamma_set = armada_drm_crtc_gamma_set,
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/armada/armada_fbdev.c:121:15: note: (near initialization for 'armada_fb_helper_funcs.fb_probe')
>> drivers/gpu//drm/armada/armada_fbdev.c:122:2: error: unknown field 'gamma_get' specified in initializer
.gamma_get = armada_drm_crtc_gamma_get,
^
drivers/gpu//drm/armada/armada_fbdev.c:122:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.gamma_get = armada_drm_crtc_gamma_get,
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/armada/armada_fbdev.c:122:15: note: (near initialization for 'armada_fb_helper_funcs.initial_config')
cc1: some warnings being treated as errors
vim +/gamma_set +121 drivers/gpu//drm/armada/armada_fbdev.c
96f60e37 Russell King 2012-08-15 115 ret = 1;
96f60e37 Russell King 2012-08-15 116 }
96f60e37 Russell King 2012-08-15 117 return ret;
96f60e37 Russell King 2012-08-15 118 }
96f60e37 Russell King 2012-08-15 119
3a493879 Thierry Reding 2014-06-27 120 static const struct drm_fb_helper_funcs armada_fb_helper_funcs = {
96f60e37 Russell King 2012-08-15 @121 .gamma_set = armada_drm_crtc_gamma_set,
96f60e37 Russell King 2012-08-15 @122 .gamma_get = armada_drm_crtc_gamma_get,
96f60e37 Russell King 2012-08-15 123 .fb_probe = armada_fb_probe,
96f60e37 Russell King 2012-08-15 124 };
96f60e37 Russell King 2012-08-15 125
:::::: The code at line 121 was first introduced by commit
:::::: 96f60e37dc66091bde8d5de136ff6fda09f2d799 DRM: Armada: Add Armada DRM driver
:::::: TO: Russell King <rmk+kernel@arm.linux.org.uk>
:::::: CC: Russell King <rmk+kernel@arm.linux.org.uk>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Thu, Jun 22, 2017 at 12:34:36AM +0800, kbuild test robot wrote: > Hi Peter, > > [auto build test ERROR on drm/drm-next] > [also build test ERROR on next-20170621] > [cannot apply to v4.12-rc6] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Peter-Rosin/improve-the-fb_setcmap-helper/20170621-205441 > base: git://people.freedesktop.org/~airlied/linux.git drm-next > config: arm-allmodconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All errors (new ones prefixed by >>): > > >> drivers/gpu//drm/armada/armada_fbdev.c:121:2: error: unknown field 'gamma_set' specified in initializer > .gamma_set = armada_drm_crtc_gamma_set, Looks like you've missed at least the armada driver in your conversion? -Daniel > ^ > >> drivers/gpu//drm/armada/armada_fbdev.c:121:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .gamma_set = armada_drm_crtc_gamma_set, > ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu//drm/armada/armada_fbdev.c:121:15: note: (near initialization for 'armada_fb_helper_funcs.fb_probe') > >> drivers/gpu//drm/armada/armada_fbdev.c:122:2: error: unknown field 'gamma_get' specified in initializer > .gamma_get = armada_drm_crtc_gamma_get, > ^ > drivers/gpu//drm/armada/armada_fbdev.c:122:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > .gamma_get = armada_drm_crtc_gamma_get, > ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu//drm/armada/armada_fbdev.c:122:15: note: (near initialization for 'armada_fb_helper_funcs.initial_config') > cc1: some warnings being treated as errors > > vim +/gamma_set +121 drivers/gpu//drm/armada/armada_fbdev.c > > 96f60e37 Russell King 2012-08-15 115 ret = 1; > 96f60e37 Russell King 2012-08-15 116 } > 96f60e37 Russell King 2012-08-15 117 return ret; > 96f60e37 Russell King 2012-08-15 118 } > 96f60e37 Russell King 2012-08-15 119 > 3a493879 Thierry Reding 2014-06-27 120 static const struct drm_fb_helper_funcs armada_fb_helper_funcs = { > 96f60e37 Russell King 2012-08-15 @121 .gamma_set = armada_drm_crtc_gamma_set, > 96f60e37 Russell King 2012-08-15 @122 .gamma_get = armada_drm_crtc_gamma_get, > 96f60e37 Russell King 2012-08-15 123 .fb_probe = armada_fb_probe, > 96f60e37 Russell King 2012-08-15 124 }; > 96f60e37 Russell King 2012-08-15 125 > > :::::: The code at line 121 was first introduced by commit > :::::: 96f60e37dc66091bde8d5de136ff6fda09f2d799 DRM: Armada: Add Armada DRM driver > > :::::: TO: Russell King <rmk+kernel@arm.linux.org.uk> > :::::: CC: Russell King <rmk+kernel@arm.linux.org.uk> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, 22 Jun 2017 08:37:55 +0200 Daniel Vetter <daniel@ffwll.ch> wrote: > On Thu, Jun 22, 2017 at 12:34:36AM +0800, kbuild test robot wrote: > > Hi Peter, > > > > [auto build test ERROR on drm/drm-next] > > [also build test ERROR on next-20170621] > > [cannot apply to v4.12-rc6] > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > url: https://github.com/0day-ci/linux/commits/Peter-Rosin/improve-the-fb_setcmap-helper/20170621-205441 > > base: git://people.freedesktop.org/~airlied/linux.git drm-next > > config: arm-allmodconfig (attached as .config) > > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 > > reproduce: > > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # save the attached .config to linux build tree > > make.cross ARCH=arm > > > > All errors (new ones prefixed by >>): > > > > >> drivers/gpu//drm/armada/armada_fbdev.c:121:2: error: unknown field 'gamma_set' specified in initializer > > .gamma_set = armada_drm_crtc_gamma_set, > > Looks like you've missed at least the armada driver in your conversion? Already fixed in v2 ;-).
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 119e5e4..80d9853 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -85,38 +85,6 @@ struct drm_fb_helper_surface_size { */ struct drm_fb_helper_funcs { /** - * @gamma_set: - * - * Set the given gamma LUT register on the given CRTC. - * - * This callback is optional. - * - * FIXME: - * - * This callback is functionally redundant with the core gamma table - * support and simply exists because the fbdev hasn't yet been - * refactored to use the core gamma table interfaces. - */ - void (*gamma_set)(struct drm_crtc *crtc, u16 red, u16 green, - u16 blue, int regno); - /** - * @gamma_get: - * - * Read the given gamma LUT register on the given CRTC, used to save the - * current LUT when force-restoring the fbdev for e.g. kdbg. - * - * This callback is optional. - * - * FIXME: - * - * This callback is functionally redundant with the core gamma table - * support and simply exists because the fbdev hasn't yet been - * refactored to use the core gamma table interfaces. - */ - void (*gamma_get)(struct drm_crtc *crtc, u16 *red, u16 *green, - u16 *blue, int regno); - - /** * @fb_probe: * * Driver callback to allocate and initialize the fbdev info structure. diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h index 85984b2..0773db9 100644 --- a/include/drm/drm_modeset_helper_vtables.h +++ b/include/drm/drm_modeset_helper_vtables.h @@ -267,22 +267,6 @@ struct drm_crtc_helper_funcs { enum mode_set_atomic); /** - * @load_lut: - * - * Load a LUT prepared with the &drm_fb_helper_funcs.gamma_set vfunc. - * - * This callback is optional and is only used by the fbdev emulation - * helpers. - * - * FIXME: - * - * This callback is functionally redundant with the core gamma table - * support and simply exists because the fbdev hasn't yet been - * refactored to use the core gamma table interfaces. - */ - void (*load_lut)(struct drm_crtc *crtc); - - /** * @disable: * * This callback should be used to disable the CRTC. With the atomic
Drivers no longer have any need for these callbacks, and there are no users. Zap. Zap-zap-zzzap-p-pp-p. Signed-off-by: Peter Rosin <peda@axentia.se> --- include/drm/drm_fb_helper.h | 32 -------------------------------- include/drm/drm_modeset_helper_vtables.h | 16 ---------------- 2 files changed, 48 deletions(-)